From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 948D5C36001 for ; Mon, 24 Mar 2025 04:18:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E45B9280002; Mon, 24 Mar 2025 00:18:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCBD6280001; Mon, 24 Mar 2025 00:18:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C474F280002; Mon, 24 Mar 2025 00:18:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A45D4280001 for ; Mon, 24 Mar 2025 00:18:07 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CE1551A0EF2 for ; Mon, 24 Mar 2025 04:18:08 +0000 (UTC) X-FDA: 83255137056.29.6B3F447 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 885EE20011 for ; Mon, 24 Mar 2025 04:18:06 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W33V5CrR; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of ruyang@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=ruyang@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742789886; a=rsa-sha256; cv=none; b=AQ460fIh7oIhthiILwYat54CKN4//1BPkK3oBro2h6NGKMnh0GX6T8X1yoSIycks7n3E8S /gAuTiqhjGp48JvKyai0SeT/81t/xzO0SsVQe8iF7jir3PzodAnOajEF5FurWugCX4HX71 ogCtV3Pl9DfKNrzWh8mZz1WPdThQkMw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W33V5CrR; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of ruyang@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=ruyang@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742789886; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tauycDhLSHK8+Z4SEw1ULV8RR4SX0dqi01Ofyz18GyY=; b=ijAr37zdCE0Ygiatl98hxKbu59Vaox1O+hutI5evIKk4YdXxn+7WEI7Kg5migWTyZCQD2z aUg/tisOQfCuplnXieKSvOvFTIFSPNpirw3jL6h5LHar1D8JSFRgb6Nnv4uMLbqGwCzHFy qbRIFJQeUAHQZiUvrXqXQcXLMw5oFP8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742789885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tauycDhLSHK8+Z4SEw1ULV8RR4SX0dqi01Ofyz18GyY=; b=W33V5CrRCUMkC90h/r035j/Y5gcrgea7vWDbHvFsthUhoRfTCs3SbTXOzmH8juJJOKlbvv AnBui29AYJw6XCuNDfk753GHT2Hxw/+DbyzBId8VuRsF8AOs5T3TsyNa3zcu4sVQe37fC+ zb83GkwlYjsFDDYqmsUPiuGREad1Zq4= Received: from mail-il1-f200.google.com (mail-il1-f200.google.com [209.85.166.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-306-4stPox7kOOO6ZoAr9oF0Fw-1; Mon, 24 Mar 2025 00:18:04 -0400 X-MC-Unique: 4stPox7kOOO6ZoAr9oF0Fw-1 X-Mimecast-MFC-AGG-ID: 4stPox7kOOO6ZoAr9oF0Fw_1742789883 Received: by mail-il1-f200.google.com with SMTP id e9e14a558f8ab-3d5b3819ff6so152795ab.2 for ; Sun, 23 Mar 2025 21:18:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742789883; x=1743394683; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tauycDhLSHK8+Z4SEw1ULV8RR4SX0dqi01Ofyz18GyY=; b=rratEjq5VVZqI8D5vxXdq7EgiudOFK4OfgH/4+BOxZF0As1pUwcNzB9sHTMbwCf8xP hhJMs53/HE1EJAhc4EvpbapUwUHoOkuARVv1Ga4VrAGZUNNdAZKc0L6lRSs+/wpTenC4 A4spsTiV44KJU12+LE4K83s47rfZuKYAxwkKV9h8RlswTmGVNiKeK4QzYBEN9O8K6IW5 LXAHnRxNnx9QgnFthD7SUccti0wt9tJUl/XvkD+kH/DOtCndjlr/1RWIE6VKqbZVDDzk EIRZLHCQpKZwfmXm6nWRACGm2iC0zybin5R4xfnrblcLx5operI6dlpJUI9bjSmui3jo YuVw== X-Forwarded-Encrypted: i=1; AJvYcCUOyIHfxGl5sGjjt56HN1CFaJd4l0UqblSzg/Qvy3RNN90YH6R7jaH8VrApZ8sBsGyKa10zW7ARgA==@kvack.org X-Gm-Message-State: AOJu0YykEfkQM1stoNULm+a4i6+sliAQVIGVX5Pp38GR704pHFGiG1lL tsZ0sgnBhdhSopHqdeieRtKGt7ly26dx7jMLubjFA2cuuW8a9dlDn0CL3ZHgMn0IYo4uMDh9asQ pRa0hviGeDLyVnYraSnMKwjTdEj8kxkdPvmOE98vl6v+tGtO0NDVI8SCFUG9vLwKAF/Jle+AbwI RZ5omrEnLRVSe1Ij4TLxwx6yI= X-Gm-Gg: ASbGnctiNIKZdMMr/1jT3HLiB78QA6YiwgjM04ALo8SF3HZWpjpqn0qC3nV2LqLd8bx Ta7LuDw+pIWT52SDUKgxwEcUasermrAnPVrQnSU0GkCwCZ2WVzYXfc/KYp0t34q7FOsbnT1Va0A == X-Received: by 2002:a05:6e02:3e03:b0:3d4:3cd7:d29c with SMTP id e9e14a558f8ab-3d5961087a4mr114773345ab.11.1742789883499; Sun, 23 Mar 2025 21:18:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFKTYUkEhLDCfmTqCzwmW7lTzNOrlm9PhUUN5r+ilaum3pQSmAXsd7VnN9OVuQyn+lnI6uMUA4yOPPaWTzR6xc= X-Received: by 2002:a05:6e02:3e03:b0:3d4:3cd7:d29c with SMTP id e9e14a558f8ab-3d5961087a4mr114772865ab.11.1742789883003; Sun, 23 Mar 2025 21:18:03 -0700 (PDT) MIME-Version: 1.0 References: <20250320015551.2157511-1-changyuanl@google.com> <20250320015551.2157511-12-changyuanl@google.com> In-Reply-To: <20250320015551.2157511-12-changyuanl@google.com> From: Dave Young Date: Mon, 24 Mar 2025 12:18:24 +0800 X-Gm-Features: AQ5f1Jo8cgDtoQHR7bje9Ajd-fT5hflpJGHeRbJSkzX-LSsy1GnvBgRPYu2INeE Message-ID: Subject: Re: [PATCH v5 11/16] kexec: add config option for KHO To: Changyuan Lyu Cc: linux-kernel@vger.kernel.org, graf@amazon.com, akpm@linux-foundation.org, luto@kernel.org, anthony.yznaga@oracle.com, arnd@arndb.de, ashish.kalra@amd.com, benh@kernel.crashing.org, bp@alien8.de, catalin.marinas@arm.com, dave.hansen@linux.intel.com, dwmw2@infradead.org, ebiederm@xmission.com, mingo@redhat.com, jgowans@amazon.com, corbet@lwn.net, krzk@kernel.org, rppt@kernel.org, mark.rutland@arm.com, pbonzini@redhat.com, pasha.tatashin@soleen.com, hpa@zytor.com, peterz@infradead.org, ptyadav@amazon.de, robh+dt@kernel.org, robh@kernel.org, saravanak@google.com, skinsburskii@linux.microsoft.com, rostedt@goodmis.org, tglx@linutronix.de, thomas.lendacky@amd.com, usama.arif@bytedance.com, will@kernel.org, devicetree@vger.kernel.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zf9WJb8xqeEm9YpKsmSzgfBMVn4PTaYWjizRliIBYOQ_1742789883 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 885EE20011 X-Stat-Signature: h7367d56h83du846eh64npz4j8mznmj3 X-HE-Tag: 1742789886-804818 X-HE-Meta: U2FsdGVkX1+ZjlPQSGUQRpTKLeWFXqnRF6adT0GFuffAkC2xcD7HxrtCwxNDyJ8+HzqW4I6Ya+wQ0QcMkeWVcXLpPTMeDYNgmFLgjA+DIYi6zT9TNbMSrKHU0o+pM98qQdK+aLp7JomnAdhsn+t1aptPzxJCpN7Y8bjAj882XxhdSzAGSJ3asH2QAsH78CLSnHdRvkuRtwgObLRPOcd4NcWBdVBfaKmI0kWrYXNUNoTAlbdf8dF5n2E6Bgke8+2lnuRnxnq3/Hd9dr3YckPo97Dq7FYCLkK2GjR+N6sJkvyvsNrfe7iEUXC98ZpEodMk4unHCrlcac2juB2Iwm/uBDEdveh2117SNhNRvQd1VvGzkf5rFaz5B2lNPfOjauT/bzjRrRxWETdv4TQn9Bvbw003VInQZOdJ+biuyMne4Ip0+omRv+FijFkn3eHkoXelPCic1+GpeoJU6ZiOP87jbfS26vjhStdEYUPGIR512GDAHsOJd7PXvAjMTrneIXkmkOHfUNwaxXZOuxNY4PBh//PZnH68eRKuZS6etnXWDbqkZ0mzp6Ze6vWzm7DTQ3ipoxmCKSVsJGzgkCL5Qdve06OGzy7Ai4VQDv7l4nHiwTiujp8QW5IgJi/wiwAnY62TLwwDbMGMPJPh8TE56ExlOPbtaHv9SrYq8I+fhCMwIiIMjunTEE3YGoKLgpmrRNrz/0QB7N/NHj/bsjyN/17jmS9CaS78mMeb+PPzGRnwlKHMWtGSW8r/ZiVoNE6IgRh5G4UPSPdQgSlZN+1QQS4EjdnAYgPgHLW2aqJw1xv+nLOHxrHMhGMBYW0H/nQbMe6ke+XEpIg4Z4oyM9dJaqRJ4FwRN87eOdffQd3YYpc7LrgauqDBXIKIaromVNfSepk07ewXQ1xKB+FUwkV00XrbOHYVAZogbcik8QBy7KPtXPKrg2H4iLFSvNER4D0CZxew+N+wp8jB55sZhcu1hXT RfpRZF7A I8GUmOGKgcBMvbo4Xo5WRuFW6+VcicjGjIrag21IKP+OV9NsekcFzEHejIG6GqAiBj9pP3AaBujAwGiWVvJTKWQFIM5PYv5hyMVNIrpvPuVyEYZJWkh6z0W+ipfJHMkNgeniSDVqmsrWgZHkV0gfjNO7tLBHKbJ7rLI4RJlHdQZEA/LaKLv1PioP+jrZzEvFFZhg54bhUQ9c+dgZtH8wrwUOdR2AvP4IsXOejHrZQLpuDvwOWugDS5JVo5pTDVmFnY074RlX7GXKZgA6Ri401lXBHUhjGKJI4NvTICXcWtYz6gaAdk0dWaRdi6c6rRPOuFTHGBFPFeOb1pWBPp/fjl7mTLUkTDwoAge4wLnPu/u80z0hxxOYCZ9U0ldq/McfUNSRWvGVxuGBBTojGah1FcQntWG75/H9bCXuNn8tOh+132JZMgnSYLFN/4l8lI5pfoX5U/TrOBdzYdPG82BY8ileLy3Gm3ut8KpTGhqPbAh3451x1nDA98WLKcsZLHGfjvmbpgBRKIZr9hlYNuD2XF47bdT88AIEH2hs2JXhabcdFpkfV1lCZPLd2D2qx2qsxPXUu2ShTuwp8eyRfmQkbNe3+rksPGdch6In8V3JtBlspfslwf9BDiFexZw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 20 Mar 2025 at 23:05, Changyuan Lyu wrote: > > From: Alexander Graf > > We have all generic code in place now to support Kexec with KHO. This > patch adds a config option that depends on architecture support to > enable KHO support. > > Signed-off-by: Alexander Graf > Co-developed-by: Mike Rapoport (Microsoft) > Signed-off-by: Mike Rapoport (Microsoft) > Co-developed-by: Changyuan Lyu > Signed-off-by: Changyuan Lyu > --- > kernel/Kconfig.kexec | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/kernel/Kconfig.kexec b/kernel/Kconfig.kexec > index 4d111f871951..57db99e758a8 100644 > --- a/kernel/Kconfig.kexec > +++ b/kernel/Kconfig.kexec > @@ -95,6 +95,21 @@ config KEXEC_JUMP > Jump between original kernel and kexeced kernel and invoke > code in physical address mode via KEXEC > > +config KEXEC_HANDOVER > + bool "kexec handover" > + depends on ARCH_SUPPORTS_KEXEC_HANDOVER && ARCH_SUPPORTS_KEXEC_FILE > + select MEMBLOCK_KHO_SCRATCH > + select KEXEC_FILE > + select DEBUG_FS > + select LIBFDT > + select CMA > + select XXHASH > + help > + Allow kexec to hand over state across kernels by generating and > + passing additional metadata to the target kernel. This is useful > + to keep data or state alive across the kexec. For this to work, > + both source and target kernels need to have this option enabled. > + Have you tested kdump? In my mind there are two issues, one is with CMA enabled, it could cause kdump crashkernel memory reservation failures more often due to the fragmented low memory. Secondly, in kdump kernel dump the crazy scratch memory in vmcore is not very meaningful. Otherwise I suspect this is not tested under kdump. If so please disable this option for kdump. > config CRASH_DUMP > bool "kernel crash dumps" > default ARCH_DEFAULT_CRASH_DUMP > -- > 2.48.1.711.g2feabab25a-goog > >