From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5161EC433F5 for ; Wed, 3 Nov 2021 12:43:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D2CB66115B for ; Wed, 3 Nov 2021 12:43:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D2CB66115B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 38F446B006C; Wed, 3 Nov 2021 08:43:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 33E7B940007; Wed, 3 Nov 2021 08:43:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DEA46B0072; Wed, 3 Nov 2021 08:43:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0106.hostedemail.com [216.40.44.106]) by kanga.kvack.org (Postfix) with ESMTP id 0F2C66B006C for ; Wed, 3 Nov 2021 08:43:27 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A8BAA184875DC for ; Wed, 3 Nov 2021 12:43:26 +0000 (UTC) X-FDA: 78767584812.22.1CD2EC6 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by imf03.hostedemail.com (Postfix) with ESMTP id E3210300399E for ; Wed, 3 Nov 2021 12:43:12 +0000 (UTC) Received: by mail-qt1-f180.google.com with SMTP id u7so660933qtc.1 for ; Wed, 03 Nov 2021 05:43:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=h1EQ8/OoCimMk2uVdS1XOAIkCZFUdiGETi3n8rbbdd8=; b=HxBT7BfV7sPl4eZzdbRxLPIOUZq1y4YVtHplM0DkTAaGKeUyrNeGIn9ZDqiu811dpf fl5OG0g4Mx6BfnQIqYjaesoM0MPs6g31tUsIcZOWos9NGUyO998gyaJfu/FYUwe0HroU EB8bL7gXQPIGYJ/5NnSnZJzEIPrE+Fn7D50Pl+IpN0VYP5Wm3hgQyAGWO2PTHqbLeqJU CPhad7Z9ylJavMDmk/0ISbTdbXYgB6Kxk0g3CnTW599VGXp/DWGJ3OoECRmn3S8uHh3Z BKaWE0nFh4oOq4sQVjhn6CafvnjT892MqNkqX4XuRP/XbknD0hKAOpJCxu9lrkeuHgC4 jdBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h1EQ8/OoCimMk2uVdS1XOAIkCZFUdiGETi3n8rbbdd8=; b=oxfoWh8LJNMnWQQDVkgANfJYN5M8xksXlTEUMmBEoq4CMLBvnGVy18BAkeggE//nBY Q+/883NgQlu3ZHTy6pnHllTswjCsmFDSgK6vcROivp2G/Us8X9V3AJLe/wY0ZLT7KxC8 ViATZ4+nclXDGmGNySVBnWdHuOjfBGq647QUeWY09tVTXfZCGCl1tqV/XgvtqyIxyeUu uQA2PnoWYCaPSRDZq0dnguUKVNPPJK+Zglq5jGL3gHovoXvKMwopeuUP3TnEd0zo4CRg voZ4LP6QumHxyM3aIcIFY2JreCO5UCPwPDmUGUfijtPcGhUjTIKPV1bFw1LnM0VkWYy6 WGXA== X-Gm-Message-State: AOAM533/AMHHLFm13U0GnwAPJQ4u2ZV7Jr3k6FnxUygXKkLN2inuV4ef m3CUBG5rhq4D5f/2SjwdmqTaaQEucpaBo+e9tzs= X-Google-Smtp-Source: ABdhPJzqDw9tBDFAlIQd2o12IUhHpKsomDUgFYOVJQPi8fXIbanYXOm6ISItuxRWYHg8F6yd+vbwK5adPbrotru7ekY= X-Received: by 2002:ac8:5a48:: with SMTP id o8mr12416853qta.212.1635943398427; Wed, 03 Nov 2021 05:43:18 -0700 (PDT) MIME-Version: 1.0 References: <20211101101719.22538-1-kushalkothari285@gmail.com> In-Reply-To: From: kushal kothari Date: Wed, 3 Nov 2021 18:12:57 +0530 Message-ID: Subject: Re: [PATCH] staging: mm: Fix ERROR:do not initialise statics to 0 or NULL in memblock.c To: Matthew Wilcox Cc: rppt@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mike Rapoport , kushalkothari2850@gmail.com Content-Type: multipart/alternative; boundary="00000000000022d0c005cfe1c1d3" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E3210300399E X-Stat-Signature: k6keuugxdg748h4jceg7y3igsta7bmh3 Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=HxBT7BfV; spf=pass (imf03.hostedemail.com: domain of kushalkothari285@gmail.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=kushalkothari285@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1635943392-884915 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --00000000000022d0c005cfe1c1d3 Content-Type: text/plain; charset="UTF-8" >Why does the subject line say "staging"? What tool reports this as an >"ERROR"? Sorry. I made a mistake there while writing the subject line and adding . I am fixing it in v2. I ran the checkpatch.pl script which reported this error. On Mon, Nov 1, 2021 at 8:10 PM Matthew Wilcox wrote: > On Mon, Nov 01, 2021 at 03:47:19PM +0530, Kushal Kothari wrote: > > The default value of static variable is zero and bool is false so > > not need to set it here. > > This patch fixes this ERROR in memblock.c > > Why does the subject line say "staging"? What tool reports this as an > "ERROR"? > > > Signed-off-by: Kushal Kothari > > --- > > mm/memblock.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/mm/memblock.c b/mm/memblock.c > > index 5c3503c98b2f..57b9153b2278 100644 > > --- a/mm/memblock.c > > +++ b/mm/memblock.c > > @@ -16,7 +16,7 @@ > > #include > > #include > > #include > > - > > +#include > > Why are you including stdbool here? Why do you not justify it in the > changelog? > > --00000000000022d0c005cfe1c1d3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
>Why does the subject line say "staging"?=C2= =A0 What tool reports this as an
>"ERROR"?

Sorry. I m= ade a mistake there while writing the subject line and adding <stdbool.h= >.
I am fixing it in v2.
I ran the checkpatch.pl script which reported this error.

On Mon, Nov 1,= 2021 at 8:10 PM Matthew Wilcox <willy@infradead.org> wrote:
On Mon, Nov 01, 2021 at 03:47:19PM +05= 30, Kushal Kothari wrote:
> The default value of static variable is zero and bool is false so
> not need to set it here.
> This patch fixes this ERROR in memblock.c

Why does the subject line say "staging"?=C2=A0 What tool reports = this as an
"ERROR"?

> Signed-off-by: Kushal Kothari <kushalkothari285@gmail.com>
> ---
>=C2=A0 mm/memblock.c | 8 ++++----
>=C2=A0 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/mm/memblock.c b/mm/memblock.c
> index 5c3503c98b2f..57b9153b2278 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -16,7 +16,7 @@
>=C2=A0 #include <linux/kmemleak.h>
>=C2=A0 #include <linux/seq_file.h>
>=C2=A0 #include <linux/memblock.h>
> -
> +#include<stdbool.h>

Why are you including stdbool here?=C2=A0 Why do you not justify it in the<= br> changelog?

--00000000000022d0c005cfe1c1d3--