From: Leon Romanovsky <leon@leon.nu>
To: Joe Perches <joe@perches.com>
Cc: dhowells <dhowells@redhat.com>, Linux-MM <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-cachefs <linux-cachefs@redhat.com>,
linux-afs <linux-afs@lists.infradead.org>
Subject: Re: [RFC] Refactor kenter/kleave/kdebug macros
Date: Sat, 16 May 2015 21:56:52 +0300 [thread overview]
Message-ID: <CALq1K=+X-Gk8xEaMVT0VWujz1pc45+6DsugWiaCPeF-zObozLg@mail.gmail.com> (raw)
In-Reply-To: <1431796166.15709.81.camel@perches.com>
On Sat, May 16, 2015 at 8:09 PM, Joe Perches <joe@perches.com> wrote:
> On Sat, 2015-05-16 at 20:01 +0300, Leon Romanovsky wrote:
[]
>> My question is how we should handle such duplicated debug print code?
>> As possible solutions, I see five options:
>> 1. Leave it as is.
>> 2. Move it to general include file (for example linux/printk.h) and
>> commonize the output to be consistent between different kdebug users.
>> 3. Add CONFIG_*_DEBUG definition for every kdebug user.
>> 4. Move everything to "#if 0" construction.
>> 5. Move everything to "#if defined(__KDEBUG)" construction.
>
> 6: delete the macros and uses
Thank you, It is indeed possible option, since in last six years there
were no attempts to "open" this code.
--
Leon Romanovsky | Independent Linux Consultant
www.leon.nu | leon@leon.nu
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-05-16 18:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-16 17:01 Leon Romanovsky
2015-05-16 17:09 ` Joe Perches
2015-05-16 18:56 ` Leon Romanovsky [this message]
2015-05-18 10:31 ` David Howells
2015-05-18 13:23 ` Leon Romanovsky
2015-05-18 13:27 ` Leon Romanovsky
2015-05-18 13:29 ` David Howells
2015-05-18 13:52 ` Leon Romanovsky
2015-05-18 15:20 ` David Howells
2015-05-18 18:35 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALq1K=+X-Gk8xEaMVT0VWujz1pc45+6DsugWiaCPeF-zObozLg@mail.gmail.com' \
--to=leon@leon.nu \
--cc=dhowells@redhat.com \
--cc=joe@perches.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cachefs@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox