From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 293AFE77173 for ; Fri, 6 Dec 2024 19:37:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B10C26B02D5; Fri, 6 Dec 2024 14:37:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AC0886B02D6; Fri, 6 Dec 2024 14:37:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 988636B02D7; Fri, 6 Dec 2024 14:37:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7ADD96B02D5 for ; Fri, 6 Dec 2024 14:37:58 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 401F7120161 for ; Fri, 6 Dec 2024 19:37:58 +0000 (UTC) X-FDA: 82865544090.10.F410944 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by imf13.hostedemail.com (Postfix) with ESMTP id 6F74120008 for ; Fri, 6 Dec 2024 19:37:38 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=n3ZVcg9o; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of jeffxu@google.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=jeffxu@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733513868; a=rsa-sha256; cv=none; b=8pSJBjGPibnyml4S4bDL9+vf8mkupoe4XGYWhMHMbaWLCWTevTaub5oudAXw1vtDjHhKrU sYpeT+QxYiIJSPdUD6pr0Q5u+7CWDFibScjFzxxQbtWKQ98q0G3gZAVNDW2F8ufOUOkawq BtFl3MllJHC8DSVdHJ9qE/XoeVi0+qY= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=n3ZVcg9o; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of jeffxu@google.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=jeffxu@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733513868; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DH8wn9taPLs7rRmOJfCxq+RP2lrhMFvIr63QFRJWhdw=; b=RGUDneASzmAFlcPa+NH2br2AqtrH202UpEra6lr2whvINAgnIdDPpsXzJbdczgtdB50gWC jGTf0GENhInkO0bzmFQlbutVybMs9KCq8ecL1SacxSOye6AKPG4jMCiDGilec3MDnxSRo2 RlGUi8b4OJ61zK0T3+Nr65LX/ztIS0Y= Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-434e5e71a08so5535e9.1 for ; Fri, 06 Dec 2024 11:37:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1733513875; x=1734118675; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DH8wn9taPLs7rRmOJfCxq+RP2lrhMFvIr63QFRJWhdw=; b=n3ZVcg9oxJF+p748Bb9F3z/J/AUy64UFHoO/TNWscKSFYAsspA3HQGSeTgzA+K3gWP 63J33+HawI6MY+Wr7G77FU+qqcgMe1cWOsT9eAey7QMpGL8q+VQyJSQD80KGHSYpFfwa FzZU9a4dmFXw39kfhJqd+psXwlTSslmExjc3/Obk3Fao/AJ8BrzjOxX90vc4ZdzYoPgA qo+SQ52dQB2Fx6nL/GZy64br8FGeTOmutApFg8o/Rs42MdUzMt5X7uTBwfZiQraq0Js3 4GDef2eVond+Kmye92CWJT0DKyq4qJ05LjakMBJbHsXrUzP7xWUpZpVsBDgWUf/kv0DH vpKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733513875; x=1734118675; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DH8wn9taPLs7rRmOJfCxq+RP2lrhMFvIr63QFRJWhdw=; b=RpVUMHi4do0xqbEjI9ahVlHHZT8cJt+b7AOrfPUyLZZ+a10hModODmF477+7tBZV+Y sbsRG7Ac/d5aDZ76t/HjuUQqkX8Bx0qEyyX+Nk/Z+wmrrDCMRtxKkeeK6oI9HhGzITPw i0uox5/cKxbpb2ptEH+uyUOmSYtOz3NWHOvdyjgcetLzzOS54ek/J0UxUNt5BKeCfa9y ygOs6WRCvStK0uQA6uHJwmTuAODsmZVITz3fFBBMbXe5e8LGv9D73cBD4Ma8whxAGddE Bpq1OHALC5yYG3i4RH0RsyeGOVvBmPgswHrOrHg4eTwnlw0+U+v7Sl0XGhR31Fk3c7Zc XO6Q== X-Forwarded-Encrypted: i=1; AJvYcCUY7lDft4qxNVrOUvLUDgLUS6jhTZlg0WLBAsKLwkLW9L8ogKcNp7rf2F/mWZZBFucbIuT4y7kieQ==@kvack.org X-Gm-Message-State: AOJu0YwVV8NKoRx5W7wTgzhabDY5fGVTB1jQZgx4rzAl18t/7CuW1aOH I3AaT8RmrsWEBuWwivso25Q+K1ufHF8QFsuyZF4B0FMeH4tjg+qS+JXG1Z5EeY/8q17HeoaoP3N 1Xzst+anq5mXLeZwhpMUi9m8yUTjciuLv+kYY X-Gm-Gg: ASbGnctd8kKWmSEmVJBeBXuBJKUx2/aG3r0pt1al+qaNLXdGywUnk7O0uYHTQ1aYGnR lWXJHt+8p2HP6AX+lYVBr76WxK5NCGC5I+uTBYpYL3WVm9whveZgZDgGehLA= X-Google-Smtp-Source: AGHT+IF4T66lh7GZU9E+Oi4ceU8qAQeWcho1lP5iOHEzxMAEhEl+DpomU/fk2punlPnClW4iuixSXLw0OQcyvxyvOFo= X-Received: by 2002:a05:600c:2d87:b0:434:9e01:cac1 with SMTP id 5b1f17b1804b1-434e845e7eemr74255e9.7.1733513874878; Fri, 06 Dec 2024 11:37:54 -0800 (PST) MIME-Version: 1.0 References: <20241206193309.3026213-1-jeffxu@google.com> In-Reply-To: <20241206193309.3026213-1-jeffxu@google.com> From: Jeff Xu Date: Fri, 6 Dec 2024 11:37:18 -0800 X-Gm-Features: AZHOrDka1ANcuB7R0eqXjcFIqGR7_M87OqMPqTDOo3IfONht43psde5_cgPiaD0 Message-ID: Subject: Re: [PATCH] mseal: remove can_do_mseal To: jeffxu@chromium.org Cc: akpm@linux-foundation.org, vbabka@suse.cz, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, jorgelo@chromium.org, keescook@chromium.org, pedro.falcato@gmail.com, rdunlap@infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 6F74120008 X-Stat-Signature: gwmpms3e57eip3fbhkkg3s5thaqatdf7 X-HE-Tag: 1733513858-782971 X-HE-Meta: U2FsdGVkX1/1l99CFmzqzmoSaYUIEnknnKr5wxvOgnfudOc/+Q5yDY/D3EXvlKsH78LrSLWedehdQSW40TIzbiuoqKWODtvuW49Y/hGdrPYcPRBQ9tGsNdAOUBC70j+T8hoZ9G/3Y3nxZ/fnUqPtNVy1rk4ghDydLFykxiAd66pmxI1O4RJ0WPZTZoA0j7nf4oWoXdC/pb2/jShCyt4/R/haEAhDPT6jmDqq+sEijZa9y73vUw0dd3VF2lJ5SqLvotDyW36DU+c4ObyohDNkj0kmsIHFp4NtwJAJ7pQge4LID+R3vV+XgSkDmmeaNDQG6o6Jzg1NKvhpiGDp8CpnDMWrqtIhoxGqwKGv260Fkx9A8GV0pBEuvdmTlfCYhePKqxR78Qk8cLL4qco5S8rsIzY/gI4FCefwHnbsTDqY0lG99R6MepPYPrM25PJldwJC31p683djKu7dl++yMVOcP4wgrJklqmHrUYb+YK7vglb0LfVUQIr+1jjohvE3ZmdHUSvuHWlskVKAYCcGnHyeGq4uvSPVg/y24J49T5B2ueNgtc8CfZRAvTutxpl81AlCISE+g0+8E4eGmVdrTLVVdRemHhDdfnaWdbelw8uF+zIKJcsz1aWPCUmm5lfdwiL8yVdI55FLjj53cP8yWH4JR+BU51AVIB5qkBPx8GSmvRY879BDbETHC+GfljYp0/ozy/ZzbmA8qXtgt2io35KmCnJmPPj7s0hb1YFXscCRm4oz3qu3LjZorJOg7berQkmwtUTzD3vMkUzZNzABE3228QHVVESt7hzRt6bx+Ta/svKN2yNE7t/PcJhYDVkmG5oXNWN5EK3Bd/o8Z/SvBKUyC6bK6wtWh+dQyPGjMdHwLJbjiVBbCMbkOGrNDyAWjBzJyzEa1/nLdEvLc/DiyehCa3s558hdmuZwBIbsqXGfXgpqXpBo/9BkP/6n8IbfmTmR2YAV2xHQu+whrlagv9o RQ+L06PP MLOVDP8OsiwfpWRUmNBY/1hXRBjdYRbXJNneZ/Fe0VK/R/jhpgxfkAbiXMGoD49iNI2Li0RoDztZApzq6o5N1syzBksY+su+f7lFDOgTgqS0Xw7RNZQGCd4/vhMa2hTneiHjc529pWZiDpHtHuZp8CamkJTNosbrsKKIlmRipZIie6r9lUIxdLH+8eMB51/nodrLp/jxqxMCTxAXl+d7Gr+aBU0/OvityrnLWnqJr4DO891LasZCWeHW60Yh91doK71W/aJNm4lmTC+wbNRUH4O008ozn9vruLxh9MGVoq1kjNl4uZ0LmLCnUtU/tlbsjqGnTx4Hy11LlHAkn17rKHd97EhL1oficGRiYBrtYBRylH1U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000673, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 6, 2024 at 11:33=E2=80=AFAM wrote: > > From: Jeff Xu > > Hi Andrew, > > Is that possible to squash this change on top of > "mseal: move can_do_mseal to mseal.c" on the mm-unstable ? > > This is the first time I m doing this, because I saw dev did this before, > and saying this is the prefered approach. > > I could also send v2 which is what I usually do. > Actually, please ignore this, I will send a V2 instead. (this didn't remove the code, sorry about that) > Thanks > -Jeff > > Signed-off-by: Jeff Xu > --- > mm/mseal.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/mseal.c b/mm/mseal.c > index e167220a0bf0..08e6f328d9c7 100644 > --- a/mm/mseal.c > +++ b/mm/mseal.c > @@ -225,9 +225,9 @@ int do_mseal(unsigned long start, size_t len_in, unsi= gned long flags) > unsigned long end; > struct mm_struct *mm =3D current->mm; > > - ret =3D can_do_mseal(flags); > - if (ret) > - return ret; > + /* Verify flags not set. */ > + if (flags) > + return -EINVAL; > > start =3D untagged_addr(start); > if (!PAGE_ALIGNED(start)) > -- > 2.47.0.338.g60cca15819-goog >