From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66A56C77B75 for ; Wed, 17 May 2023 00:09:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E1CEE900004; Tue, 16 May 2023 20:09:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCC11900003; Tue, 16 May 2023 20:09:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C950B900004; Tue, 16 May 2023 20:09:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B5757900003 for ; Tue, 16 May 2023 20:09:22 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 894C8160400 for ; Wed, 17 May 2023 00:09:22 +0000 (UTC) X-FDA: 80797812564.03.80D55BB Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by imf01.hostedemail.com (Postfix) with ESMTP id BAAB740002 for ; Wed, 17 May 2023 00:09:20 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=4OwqK3P6; spf=pass (imf01.hostedemail.com: domain of jeffxu@google.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=jeffxu@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684282160; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R6+sA3glVwNYujyPfaMc+ARRP8ltGy3qBe8Uw1+V7f8=; b=osTwXhCRtpcLrayMSVgtERlwMKZDsp/auWHjM4KEwRn30xgszIhWDDMNF8Du+BP1nl3B6w s5ZBstYVVHEZYDT68nrkaC37wVKdX/91lqzEvUYXAcef4PBhl4ovBJY6vVN55oeecUcMkC ad6V5sE58wh9G1Uaz1swGYXJkwnP6/M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684282160; a=rsa-sha256; cv=none; b=O2CT8XB96+VNJ8ezzOMTS+ygBJlm11Qvpkg/T7zK8fVsurEeC0ASUbkws+3ReCu6vSlFbs 6DsOnTVgNKHmt1I7Tnu+9gO8cBhtYbpSSAzO/YA0VvZuigMZrp6ZqRFX4P7/NvUzfVGdeg Ni8VljPUqIWfZ6T/z4IJWAnTsEp9MD0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=4OwqK3P6; spf=pass (imf01.hostedemail.com: domain of jeffxu@google.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=jeffxu@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-50bf7bb76d0so2133a12.0 for ; Tue, 16 May 2023 17:09:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1684282159; x=1686874159; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=R6+sA3glVwNYujyPfaMc+ARRP8ltGy3qBe8Uw1+V7f8=; b=4OwqK3P6d+8uCpUBN5+GlnVRSZ7+N/8GtPEUqUxg5irzupRwHMPWOqLLOfgTT9pFA9 Wt9NzaziMW34EUwoTL/wY0W/Ygyz8wvLhrm1UmwKh8DOdzmQvPgQAnkA3XG1ld8NQK6m fZgIY6aIsnJu+nbYz/SX0ltNPasXQ2AvPzoJqZo2ifwS17FyZVaBXc7H5kgu89stkYoa wpqd30vHKgTtnT4+9WiNVVcx0zB+E0BPTli2KLUQx6wFVAcAbLlGAPooPty0YaxMubdp wJoJi/qTz+yj5C7VkuI7WWNcIB+TmDK407oQNiHSC/tCMwhwMhuZBfPomeOptbRQfMEu L4vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684282159; x=1686874159; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R6+sA3glVwNYujyPfaMc+ARRP8ltGy3qBe8Uw1+V7f8=; b=ZivNYYVjOBnCD1HXTwH3vHB91rwheAKcOVZdxQGIOyt6guU6/Lt1olPhaTxH1Yr5Pl Ihs58TfNRldk1l18/ssJGDxQI1hYIHMmCglqql3drl9ld58mmL0xUXK0qRaOvy786FSc BSpCPrE/ghVMMJCFVfgXqIPc6SgrnSDF3TPvXHAYFmMvK9dA/V16D+3TFA2xYGPIYib+ dbUbUY1gta2SR49AYjZjHGKktBZnqTvlzfmhYQ1GJphv2Uerwn8n0CzjT23OzWeiqidg s/hD4ETWA5IXKhcScIETxlxQbjsmUByPTMRtwv6zq1B8xKd57AG01M27YzGxyfb7HEDZ pTFA== X-Gm-Message-State: AC+VfDz8KN5Nd2Bag/joTTnCDMHI5vqOuQ39t8MO7Y1MYklgSOmtGCZ2 KSWp6Z47NVZuY3GvTzBAowJ096Om0JBip7wggKNdlQ== X-Google-Smtp-Source: ACHHUZ6DHEWoXAcS3gqSXdcAPxwYIzsFqlA3U40BHQD/hc3Ovr6xApDyft45NrvMujC4HgN2sonyY3noO8ubH+NBctc= X-Received: by 2002:a50:d4d5:0:b0:50b:c48c:8a25 with SMTP id e21-20020a50d4d5000000b0050bc48c8a25mr54691edj.6.1684282159196; Tue, 16 May 2023 17:09:19 -0700 (PDT) MIME-Version: 1.0 References: <20230515130553.2311248-1-jeffxu@chromium.org> <20230515130553.2311248-6-jeffxu@chromium.org> <4f14a645-3569-2e3b-f55c-3b17b567845a@intel.com> In-Reply-To: <4f14a645-3569-2e3b-f55c-3b17b567845a@intel.com> From: Jeff Xu Date: Tue, 16 May 2023 17:08:42 -0700 Message-ID: Subject: Re: [PATCH 5/6] KEY: Apply PKEY_ENFORCE_API to munmap To: Dave Hansen Cc: jeffxu@chromium.org, luto@kernel.org, jorgelo@chromium.org, keescook@chromium.org, groeck@chromium.org, jannh@google.com, sroettger@google.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: BAAB740002 X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: oftyfpdh73a4xxofctkumnz9eon77uii X-HE-Tag: 1684282160-828479 X-HE-Meta: U2FsdGVkX1+iJG6G+YVnQrlkCban1KE297zBHPDf79ioc+RecgDjjuRqAXe8EIXF4Zk08c7/rUrjr55FLoPpePnDRGBesUhU7kB5O2i1Wf8qQEHxTyv6Fk7/gTq9fpJzFwxUlOhYNk0GEp/gpYDO2PSXWLWZsLJbgRMkPdVT8CIEKGaAyXOBPh2iF2pmOhEySrbZmsz1TZpdIJnhoMaGjTXe2laZlrJx9mGoyLSprNuoW3azHHsgcpGe3EWP6+uKNk+gZNGjnxTm2bXJvC6i3hk6wZYdCzNvu6GcLQFfdhSVJip62fCoWUYDPCTPpuEjfhil2QE1nS02RtXkrujZp7iHdO0AlzXiKZX/dKE3FfnvSbNGc2F+bVrVQ70L3xcxKtEYz/AtYt2KEbzUtuq896rKji8DdLGPA2+kbJ9l4ZRH7UK/dyA0yqicLyoe+gp0Dd/C6OBak740neXHCPnxRCTwMjxEnD5aEMJTq/w+UQsa1S1MqLZjyE46/XuFSaTStxzL4f/P/intxwAQ2srwoJTYopmragDAbHQ981a7qrH7KAMCByyRw4MCpL5z/mSumNdyXUoxuGXx2z01w3zsJFMIyGopM4ySbyqJuUFY4jOzSzKi3CmJ/4WacB6drlVd0wStuqXbznXzFIGND9iRLiFxR8hfZmDwk/N++i5MKPkRM3AxSNm1pobYssO8hLQcSxxyAuZLAr7eJG8PZGP6CLQSWsRQRdDhiRmf0Rrtbee92gVGfh5a9peMtfai84mSFaZ8NvZ2cfGWsdCm4QwuDwA1UbTD47DjySZ0bTjvVvguknNFYEZNQrDdxg/4Xt8SA5VTUfKShl5qeLprWTi+L2QkW3JG8fysVHF+BzdcZJ58QF6h3b6oR2cjBBx+DY4ErOBBPhz6tiZK0TV5qWVA5RnwAKVLrQV6iFKTxuKlx2i6fmKxmDbnMY82ZgYrps1cFFuXkH39L7VTBctd76X Ne8E8CU3 i1sLpyJV51IUaqgPho5kVt6sjzUBnITdF0mP+1uIgQ0eEKOfTsh9mW+UcFTSsXYXHOLa+6QcxH+uTXOLpeo1U16W+dLqf38Wn+u6W4G1zdeLkYJz1gDXVhk788+0PvE18RyvCfJyuB7er07vCwOQube1rRaKn9gV7egWPFr3WRqF0UqBbWtCxjEncWFV227awh/BY9Z7I8+UXujrmTEsecXsgOd50fN+rhEJSs9dYnYkTzvLt6ajTYvOSPY0VdmVlc3pqB1T1MmwrYcjCjl+xT1B7oIb4oHxv4d/L8mJCrHnGSfJy+jxq914yJrQe5PfOPx18Lm9Eltrl4VFwrXYzU6wvYLaFFWkvDQLXG0Avx+IAI24fIsNnrkpE7Xd5rNlHyIk1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 16, 2023 at 4:24=E2=80=AFPM Dave Hansen = wrote: > > On 5/15/23 06:05, jeffxu@chromium.org wrote: > > From: Jeff Xu > > > > This patch enables PKEY_ENFORCE_API for the munmap > > syscall. > > The basic problem here is how we know when the set of syscalls that are > patched here is good enough and how we catch future functionality that > might need to be captured as well. > > This mechanism really needs to be able to defend against *any* changes > to the address space. I assume that folks are using syscall filtering > to prevent new syscalls from causing havoc, but is there anything that > can be done for, say, things like madvise()? I bet it was harmless for > a long time until MADV_DONTNEED showed up and made it able to > effectively zero memory. Not any change, just a limited set of syscall from user space. I think it is reasonable to hope that any kind of syscall ABI change that affects VMA will get reviewed thoroughly from now on. Also, if we continue to add mseal() to the kernel, we will have to pay more attention to syscalls related to VMA. Thanks -Jeff Xu