From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E930CC3A5A7 for ; Tue, 6 Dec 2022 16:27:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CB148E0003; Tue, 6 Dec 2022 11:27:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 754388E0001; Tue, 6 Dec 2022 11:27:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61CC88E0003; Tue, 6 Dec 2022 11:27:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5225D8E0001 for ; Tue, 6 Dec 2022 11:27:40 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1CFED1C62BE for ; Tue, 6 Dec 2022 16:27:40 +0000 (UTC) X-FDA: 80212412280.26.AAD045A Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf01.hostedemail.com (Postfix) with ESMTP id 43A9340021 for ; Tue, 6 Dec 2022 16:27:38 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=kX76ACCq; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of jeffxu@google.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=jeffxu@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670344058; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JgcwRFCL6hgvtdlBwWhPhxTax1zzqSSsoj4r1eWsJf8=; b=x2bvkj3m4GIUY/O7x+ZnH4sObD+mI6ueH5FZnXpu5D3JoJRYBcsWUbfZKMZRuGyOZNMjxN IwKPVgE0RUFLiMVaQjJFbXy8OPq4z+5ZLLAOlNM3mh05cFOWFpsUmEYOX+nznNhkOSmzqL 11PPXx9XQqLfZu0DW5C9hByLMCJbMpQ= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=kX76ACCq; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of jeffxu@google.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=jeffxu@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670344058; a=rsa-sha256; cv=none; b=Q8rUiT8yE8iyd7kaO+zixNHsYfMSZ93Mm32mPQVhxbAqPf8HivElbTxsduD934wdeED/s5 2L7MqgYWMBn/MjzZWDBTM5jOB9DY59cTJAqe282GQJkU9DmJH8Qrs8riG58JOe6z00+h89 fo0WbSqhGXp6XXWZA8Yg5FGEF02EjuU= Received: by mail-pl1-f171.google.com with SMTP id y17so14437467plp.3 for ; Tue, 06 Dec 2022 08:27:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=JgcwRFCL6hgvtdlBwWhPhxTax1zzqSSsoj4r1eWsJf8=; b=kX76ACCqquYYKdhd1CIgHnXMEB2+Uj5oj5pOCkG3xpDvEjeGvYakYAHNTo4wWv1Van orDE+qDfaC0K8lfHIRXqpbTTSJsqAwKTpg+INljBF1UtTncqnct1mbu2+iludo6zKmuu /8T7g0T9RN+U5tahdeL4X8SR6sJ15P44WttkcoX+reAZm1lQ0+KFBuys2PB9G6kKdPyz uScMqulZdXKQVT1rGNWJk6ZImu+IhtQto2OHZWinW3bNNeVOaYX3a47I3EivU73HYpCg 66o2MTbUlicj+QFikjOsTay/QFP8D1ExET45mn7CByRgZkObBnQy5L04v6XncpO5XC3K l5Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JgcwRFCL6hgvtdlBwWhPhxTax1zzqSSsoj4r1eWsJf8=; b=tav4y+u5MPMr898srWzQ3Ugeh1axBwHpqOYx1lgvKB8IeEBI0N2mPqijtblbSxL3gM afuIW8KwT5DKoogR79mOPrHB/9JYu8J7ajoM8uNYxecuv6PCUXILYhb/z1oZFGztoiy8 7psuSn+ODRGmcWCg/dpNozcLEZ2AMgAAGxSnikpmKLv6BRrVOiKp4DXmICy3XIubq7eD sG1i3iCpTlDZ1d8aJ/GSaq9siFkQRULXZHoTievOCgP+84MLrR6+MN9kMeKGyI+KDEdh jNBSRD0rgEXD2iyjpfs/4d7AXH8U6r316CX82JnaiHWugyXQl4lrOKu0Fwghxd3fYucP gZ+g== X-Gm-Message-State: ANoB5pmMNUrWJzFGLSnKEDpgqf9acBgEYnPLQ95NTNxcmhvsFlmgg6IE d0xtzKoKDyYjA1YZ1qLZer6Y0xopPk6EGJ1FvRpiCA== X-Google-Smtp-Source: AA0mqf7ZtYDDJ2IFAE867kBTqxlzwB1uI1VqK/hqmWarvEfAn0P7kQ6WgWlvXfzxt+quHS3mJfT+oyRZ304eC8tCcx4= X-Received: by 2002:a17:90a:5295:b0:219:a43b:1006 with SMTP id w21-20020a17090a529500b00219a43b1006mr17831027pjh.195.1670344026725; Tue, 06 Dec 2022 08:27:06 -0800 (PST) MIME-Version: 1.0 References: <20221206152358.1966099-1-jeffxu@google.com> <20221206152358.1966099-4-jeffxu@google.com> In-Reply-To: From: Jeff Xu Date: Tue, 6 Dec 2022 08:26:30 -0800 Message-ID: Subject: Re: [PATCH v5 3/6] mm/memfd: add MFD_NOEXEC_SEAL and MFD_EXEC To: Greg KH Cc: jeffxu@chromium.org, skhan@linuxfoundation.org, keescook@chromium.org, akpm@linux-foundation.org, dmitry.torokhov@gmail.com, dverkamp@chromium.org, hughd@google.com, jorgelo@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, jannh@google.com, linux-hardening@vger.kernel.org, kernel test robot Content-Type: text/plain; charset="UTF-8" X-Spamd-Result: default: False [5.37 / 9.00]; SORBS_IRL_BL(3.00)[209.85.214.171:from]; SUSPICIOUS_RECIPS(1.50)[]; SUBJECT_HAS_UNDERSCORES(1.00)[]; BAYES_HAM(-0.23)[66.54%]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; R_DKIM_ALLOW(0.00)[google.com:s=20210112]; RCVD_COUNT_TWO(0.00)[2]; TAGGED_RCPT(0.00)[]; RCPT_COUNT_TWELVE(0.00)[15]; DKIM_TRACE(0.00)[google.com:+]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; DMARC_POLICY_ALLOW(0.00)[google.com,reject]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[] X-Rspamd-Queue-Id: 43A9340021 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: jtxdhtdm14m8x9ohmnthd3byrxskzodq X-HE-Tag: 1670344058-619970 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 6, 2022 at 8:04 AM Greg KH wrote: > > On Tue, Dec 06, 2022 at 03:23:55PM +0000, jeffxu@chromium.org wrote: > > --- a/kernel/pid_namespace.c > > +++ b/kernel/pid_namespace.c > > @@ -110,6 +110,11 @@ static struct pid_namespace *create_pid_namespace(struct user_namespace *user_ns > > ns->ucounts = ucounts; > > ns->pid_allocated = PIDNS_ADDING; > > > > +#if defined(CONFIG_SYSCTL) && defined(CONFIG_MEMFD_CREATE) > > + ns->memfd_noexec_scope = > > + task_active_pid_ns(current)->memfd_noexec_scope; > > +#endif > > .c files should never have #if in them. Can't you put this in a .h file > properly so that this does not get really messy over time? > > Thanks for reviewing. It seems to me that checking for CONFIG_XXX is common in c code in kernel/ path. Do you have a sample code pattern (link/function) that I can follow? Thanks Jeff > > > + > > return ns; > > > > out_free_idr: > > @@ -255,6 +260,45 @@ void zap_pid_ns_processes(struct pid_namespace *pid_ns) > > return; > > } > > > > +#if defined(CONFIG_SYSCTL) && defined(CONFIG_MEMFD_CREATE) > > Same here. > > thanks, > > greg k-h