From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A406C4332F for ; Fri, 16 Dec 2022 18:41:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E10638E0002; Fri, 16 Dec 2022 13:41:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DC02F8E0001; Fri, 16 Dec 2022 13:41:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C88128E0002; Fri, 16 Dec 2022 13:41:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B88408E0001 for ; Fri, 16 Dec 2022 13:41:41 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7D1471210BE for ; Fri, 16 Dec 2022 18:41:41 +0000 (UTC) X-FDA: 80249038002.23.CDF02AB Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf26.hostedemail.com (Postfix) with ESMTP id E242D140006 for ; Fri, 16 Dec 2022 18:41:39 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=QS46Q4nW; spf=pass (imf26.hostedemail.com: domain of jeffxu@google.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=jeffxu@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671216099; a=rsa-sha256; cv=none; b=XzlGE55ydk5KJGLjH9z4sWzfch8ShYtNPBRvjomVX3i5YzXH3m/YgPJUVwjAnmhFEpDFu/ yV8Qw06YqDseHsH9Kv8trZNzUXTI+bXhklwadczhtEFPde8ETbsKMoA9Jwc6GAc8dwPAQn 7ZggnwvT/JJcFN313jl7debV3u/we2M= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=QS46Q4nW; spf=pass (imf26.hostedemail.com: domain of jeffxu@google.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=jeffxu@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671216099; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mcxFFXjYmc19fdjNo/0QqKOWh/kWtyWkgqLog48dCd0=; b=4UOtK81IZnjkkv/cYwj6b56xMY+WsNQAM4QYWozGYZP4/S8INNH/4d/7qEDWhzouH51eYA bdVG31+O2DU5McN7r6/kNpQyZK2f9+4pqVuEXfkLahkjKDcUjd744WSLV8+sINqVb8T07b 0rJKLKX9y3hbBsR6ahzeUV/WKTFMqoo= Received: by mail-pf1-f178.google.com with SMTP id 65so2354826pfx.9 for ; Fri, 16 Dec 2022 10:41:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mcxFFXjYmc19fdjNo/0QqKOWh/kWtyWkgqLog48dCd0=; b=QS46Q4nWvZck9C84DqObwPr5Kwxg5TYWK1RqnkXeN726RiQhvGtBlMIZbANJIgA2/C u1uCOfOEYxoUx6sPy51ijdUIjwnm2LA8SVrhuQiryr4ms0U703onwaxyNt9ThFW3T37G Y6kQ9HnHXtVqaxnnN/VYVEaUzv7fOc2aK8FkAjX4a/xPsuBaWEI490yhD3whDbHlqKMP gixKU/JiYNaEHMhIHq29N3mggOTUZOxR/8Vz4Cyv+tKkk7BoI9HNAV7qcXyfM/DE10PZ iSJAB6WixpCcxGLoSMs7srhndSEil5t4UGZHoAFgn8k69bjOarnUau41/xCsXwb8SxBB LEqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mcxFFXjYmc19fdjNo/0QqKOWh/kWtyWkgqLog48dCd0=; b=GQ6EjRZDTJPxuKQ9xM/p39koSZNnCpJft4V3A2JP73U4FqJJkDL+jaPF96jJEqmK7y pH+M0jb9MdoWsx1G/yC1Q508CvLsOHhy3BOlWUOmdo6FuC9Ra7123prdW2Q7H02vT0YK 7tiN5srfWbUGps3TwkrsknVJOW8eSQ5V6CNJDqToTgiOqwLBiZ65RRGaXtLkddIdZNcg Xycze+yiSAGa67fCUbfsviUtWmdXJwNbVEtdqVk6fqSl2tVY6nrdfuyw2sOOv2RxhWqb MwZoIRcUFO07Fh39vk9NIbUwXhjgQm8e6Lw0WKv3Gm8oeVUFq9O4jhXW+x2O71emVPjf dBvA== X-Gm-Message-State: ANoB5pmrva0f2aYn+zzWFqnjmcLn0JaQYZYOJjSk1dUfAtd+GFbzXO16 N0WAKpMQseMg6ZXqlbNsQ8iO175+BJv9IViEkwPmmQ== X-Google-Smtp-Source: AA0mqf6k26/qeEiRU73qRpdDBw9Uo3IlwT0RttEXqvwaG39D9C+DGBBwR8pRMoVRXfT4KGPjaQ+aJPOgtr6MYcxqSmY= X-Received: by 2002:a63:5823:0:b0:479:3a88:5e0 with SMTP id m35-20020a635823000000b004793a8805e0mr1076864pgb.466.1671216098286; Fri, 16 Dec 2022 10:41:38 -0800 (PST) MIME-Version: 1.0 References: <20221216183314.169707-1-sj@kernel.org> In-Reply-To: <20221216183314.169707-1-sj@kernel.org> From: Jeff Xu Date: Fri, 16 Dec 2022 10:41:00 -0800 Message-ID: Subject: Re: [PATCH mm-unstable] kernel/pid_sysctl.h: Add missing definitions for specific config To: SeongJae Park Cc: akpm@linux-foundation.org, dverkamp@chromium.org, keescook@chromium.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: E242D140006 X-Rspamd-Server: rspam01 X-Stat-Signature: i5izzdgrkxgks7987tq9g4psaq4iiot1 X-HE-Tag: 1671216099-61289 X-HE-Meta: U2FsdGVkX1/nZlS4nv6y7XrzhOMzZ/aCmfVA2E3XqMb2x5VsXQ9wGxbPSnCUueVEH+JShbh7SiCuLqplwkYqAYV1JQWlfYSWpBVPNUaKh3wW/lIMQYf7M9HtdWU7ok6zyberrpArpzBAM5hY2x4AkWLNQVMFV2/nlfxC7qfOGfmKSnZNxAjx53J4wI/7S3zZ+Ypp1RERNZ/nytePorxlaWIvqCKN2Yo+LSnVmYGtzBbebgz7ZnS9z94pd3KanIZVZpw3DepBr/2oSDGrSvVyYe4b1Xrgpy/eOpWrabbzT2R6L/kZviNKN65zKZM0VFpI4iCNXae7SWplYIJIk89BJSaqhYDgMFIILaaJ/VhuYJ6cI8gzLnr2Gh4OYYeETUKhlkElRS/q26UvjdKo42bt9ZpWU5mAXYc6j6E2cUtrsZ8vWhXmWekEt/jIC4qtvYmNBFU21PvqNrav8S0caJnBARDN2DyxV/ExwcuT6vAKPTll+5BBOFKpaAe2zWuD5lsm6P1C5ZyvFVuc8o6dVmaO0lG1qowHTSGfV0u0C0gepFUPz2YI0Y15Ne7gODnxi68YVjufIzt8CLJ4s+bfsgLaokv13yDbhEyfR9CW6HlJ1UkEVMjtmXLe+Oxsuq3VYXbZ5WjVrUx/fONohSdRdlQCgVzLwLrJ+pc8O34PelCcTvzS8f8whKBsMH1msDqEeGaDDGPZ+w1oKeEiQ4nH41CZBU1JGTdhMjJOnskgA5/IKeaiIES9egrnQjS1GYx5S5zB9ulHmf2Iw/khMDE+qrAYeqZeHN3o8uKBXQrwuXVzaCs99sSn+9RIK27LRPW28qpbsKYzt6d7ulA79CRIs9/a07S4H2xjTM9u4dfayt+KG/s4wjqSiC2CYN8jLf00XH39/Oi90/3oIMXQO11UxZrNJM3xQw8m3OTyLgjk4N54+lV+PhwjZj+K+ieDmTJx8ZRG8Wd8bzR2MajrTsnj9WW u2Eg1FuT 9AyyMCnYDkdw6SdfR97aiWjq56EvCFfaFBioRQfL+c7/5yO6fRHCYOCnWlA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi SeongJae Thank you for fixing this. Do I need to send v9 of the original patch ? On Fri, Dec 16, 2022 at 10:33 AM SeongJae Park wrote: > > Commit bdb6231e88a3 ("mm/memfd: add MFD_NOEXEC_SEAL and MFD_EXEC") on > mm-unstable when CONFIG_SYSCTL or CONFIG_MEMFD_CRETE not defined, as > below, because initialize_memfd_noexec_scope() and > register_pid_ns_sysctl_table_vm(), which defined by the commit, is not > defined for the config case. > > ERROR:root:/kernel/pid_namespace.c: In function =E2=80=98create_pid_n= amespace=E2=80=99: > /kernel/pid_namespace.c:114:2: error: implicit declaration of functio= n =E2=80=98initialize_memfd_noexec_scope=E2=80=99; did you mean =E2=80=98se= t_memfd_noexec_scope=E2=80=99? [-Werror=3Dimplicit-function-declaration] > 114 | initialize_memfd_noexec_scope(ns); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | set_memfd_noexec_scope > /kernel/pid_namespace.c: In function =E2=80=98pid_namespaces_init=E2= =80=99: > /kernel/pid_namespace.c:462:2: error: implicit declaration of functio= n =E2=80=98register_pid_ns_sysctl_table_vm=E2=80=99; did you mean =E2=80=98= register_pid_ns_ctl_table_vm=E2=80=99? [-Werror=3Dimplicit-function-declara= tion] > 462 | register_pid_ns_sysctl_table_vm(); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | register_pid_ns_ctl_table_vm > cc1: some warnings being treated as errors > make[3]: *** [/scripts/Makefile.build:250: kernel/pid_namespace.o] Er= ror 1 > > Fix the commit by defining the functions for the configuration. > > Fixes: bdb6231e88a3 ("mm/memfd: add MFD_NOEXEC_SEAL and MFD_EXEC") on mm-= unstable > Signed-off-by: SeongJae Park > --- > kernel/pid_sysctl.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/kernel/pid_sysctl.h b/kernel/pid_sysctl.h > index 90a93161a122..770c060a0d33 100644 > --- a/kernel/pid_sysctl.h > +++ b/kernel/pid_sysctl.h > @@ -52,8 +52,10 @@ static inline void register_pid_ns_sysctl_table_vm(voi= d) > register_sysctl_paths(vm_path, pid_ns_ctl_table_vm); > } > #else > +static inline void initialize_memfd_noexec_scope(struct pid_namespace *n= s) {} > static inline void set_memfd_noexec_scope(struct pid_namespace *ns) {} > static inline void register_pid_ns_ctl_table_vm(void) {} register_pid_ns_ctl_table_vm can be removed. Thanks Jeff +static inline void register_pid_ns_sysctl_table_vm(void) {} > #endif > > #endif /* LINUX_PID_SYSCTL_H */ > -- > 2.25.1 >