From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AAAAC4332F for ; Fri, 16 Dec 2022 23:40:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D0448E0002; Fri, 16 Dec 2022 18:40:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 780568E0001; Fri, 16 Dec 2022 18:40:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 647A18E0002; Fri, 16 Dec 2022 18:40:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 567EF8E0001 for ; Fri, 16 Dec 2022 18:40:43 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2310AA12B4 for ; Fri, 16 Dec 2022 23:40:43 +0000 (UTC) X-FDA: 80249791566.11.5683B50 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf06.hostedemail.com (Postfix) with ESMTP id 0ED42180012 for ; Fri, 16 Dec 2022 23:40:39 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=QHKlHgQ1; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of jeffxu@google.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=jeffxu@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671234040; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qP9LUFiQr+YzMaH2ADs5X+hQzeakrlDwPsVjntwjyKc=; b=yJPOx5+DpuIGcWmw2i2gSB9cUFpL5qplCkMS1pOHJWipgggZc0zNd8FZcIzWsiBTVgHX// UbHRxaphrdQFAKZuy9ZdK4v3AtWs9Yldfd3KZmG8/as79gFrUm0hP+spVzPq5B9rGK0pVU pP3Ibzj1g5Hcf4/yqEuAKorB7SXju/k= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=QHKlHgQ1; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of jeffxu@google.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=jeffxu@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671234040; a=rsa-sha256; cv=none; b=cEC8A9NPWMQf1oCSi1ryQbaHX+42BP/K/TbnEbaQ6m4zlgrJzNolvRqMl4nwTHVF9RuarC dgRAE2dz4f8Cn2htP1wHHPkWndtzPqH2KUFCpHwyFQLOv4RbR44e3IIqS/aCy42biRcua4 7YvxZJEtktFbX/tZnD/Xk/a6kzowXjA= Received: by mail-pl1-f180.google.com with SMTP id g10so3758916plo.11 for ; Fri, 16 Dec 2022 15:40:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qP9LUFiQr+YzMaH2ADs5X+hQzeakrlDwPsVjntwjyKc=; b=QHKlHgQ1SzOIzUJocmAx5UWtJH/8UTsiopsrrQZvH1zE7NKYBI7QA1k69C3WspE3EB cAqpZjDgJFTiNFWtE6zxGdaN+tOzQzzwkdgWMVbn1bEL9HKTH/s4j497z/nwE/CcRcLB +Q2wumAjgS0yMxfGDA2LGAm12Y1hqhdwlnmZEC+VanIJeCME5xkm6+FK7stiHSX/9FnK AL9shkX2H3c0Kt1HCPn3P32sufLL8+IsdFCeHNp3aqlRk+FsDlnTD9CnVcqy5StZXAO4 O+scEOSYPiSRG7sxcIfrwfwBKnz7YVYfAEzeB06iw9tNKiFkNqraNV3hUkX0Ed9kiNgr fRzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qP9LUFiQr+YzMaH2ADs5X+hQzeakrlDwPsVjntwjyKc=; b=qb2H6FOai5rUSzv3zK0wjNMs8E5REtubYneE+U7Vz+0CWIjK2QltslRhUnvahgL/u7 7eKkfCDc0/QMTk4fQlA61/AEnfqipcsC7rkSnr7aN5gGx7Pe1kY/i/MIRmYCz1YrWdl/ vHcRufqgzy4oWgEu60c0k3pjQ86mjvgOWaiJtCgNI3p9DYMtxXXb/6CEZtscsbMzNsJa HGmvsouN1z98wiYVKskGHJUVnykvYheELLYrhMi4oW32sHNUWq7+60FfLsJxu7WXmOgS EcUWpgpNuu+DkIecXPgHikSvUrfR1kUUZY9BwvK91LYNRy2H/vPQXKgrKrHRnQfFxr4a F+Kw== X-Gm-Message-State: AFqh2kqg71+BgndukUMONIh0VrnhiqfjikAb4bZKnnEZoC6YckPasjEA RpMyz6GCGiSRzbcMtar1DBEeD84E8+8ZAbVGfnDibA== X-Google-Smtp-Source: AMrXdXtnXsl2q7hOtIge/2/gsR8kvTNLB45QiArxl/ifC+j9uYnyXPKDu+v21IXOSAosloDINV72J/F8O6tmKW34wwM= X-Received: by 2002:a17:90a:4612:b0:219:a43b:1006 with SMTP id w18-20020a17090a461200b00219a43b1006mr1290642pjg.195.1671234038717; Fri, 16 Dec 2022 15:40:38 -0800 (PST) MIME-Version: 1.0 References: <20221207154939.2532830-1-jeffxu@google.com> <20221207154939.2532830-4-jeffxu@google.com> <202212080821.5AE7EE99@keescook> <20221216094259.bec91e4abd6cf54a05ce2813@linux-foundation.org> <202212161233.85C9783FB@keescook> <20221216140641.bf6e47b7c4f5a53f34c8cf9a@linux-foundation.org> In-Reply-To: <20221216140641.bf6e47b7c4f5a53f34c8cf9a@linux-foundation.org> From: Jeff Xu Date: Fri, 16 Dec 2022 15:40:00 -0800 Message-ID: Subject: Re: [PATCH v6 3/6] mm/memfd: add MFD_NOEXEC_SEAL and MFD_EXEC To: Andrew Morton Cc: Kees Cook , Peter Xu , jeffxu@chromium.org, skhan@linuxfoundation.org, dmitry.torokhov@gmail.com, dverkamp@chromium.org, hughd@google.com, jorgelo@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, jannh@google.com, linux-hardening@vger.kernel.org, kernel test robot Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0ED42180012 X-Stat-Signature: kojrquafhhnjo4xute6jf57hhqiregpx X-HE-Tag: 1671234039-260254 X-HE-Meta: U2FsdGVkX180sRCV3fyGRRBCpZpNoNtpT6mNentUqNL0bl7w2NGieA5531nu7A+aam042bdf6S1Lz7NcW/M8OzTuDA56Kl7X9TDwV5R5cgn4JBjB3berL/xtFZBARbHVP/4CFJJJyYS8GrL7s9G7YX4XE8YgN8kS9DuXYgd7I+hLWKJ7wvdlY6ptBl0VBNoYlzZMux3SYGcRGgu5F5Ppb7FWH9zVVXRjKhOpZBrW2/vOcw/qYZTK4t4DN8l1a2vzF7nSPHKzzMdNxHOus8ECWjINArcfmz1fvpxqvy9igPLPiibPUXnSmHurZejfkbX4Nvf0JvRiZfp+yAFkeG2lzbm9vzlDCtH1gj71gocpphoHWwxb0JWFd7uVhgYfT3+jViIDAtyFZctCBMdlN7CO6jLRoXYbH6Bp6ktCUwweUCFDMmHDDeau+WUIDpHCvK2a46SBXsIso2vEMosyJy7mjRrLWAChi8C7b2B/tMBI62QI30yIJ8NACHWxXtYAZlqmpCtzBKoFoVoGfW22GA2bBEXv7AUCNVi38QUSZkp6xnJB6iNbgkbrAIrMZ1X0D5IXZF+KveIVlAvIz4VNonWYiZ1sqaYkobHo/erjz+WoFt/yB7CjybuKBIM9/LNmxhTZFYASBL8+8n3utBf1CwIUPc9hN4MG5VPowBpqpeYKlbSAbNB/lrfYKEHSRycIfJILAoMfd8ylKpFJxSaBi+6ttaZBtgiwf/GeVUviPkvN4KL6swC8JlsuoWT9FCS9knWpg+J7x2Bd2ZYTLHE9TDcDxAB1wjOUnEczolGsAmsin7cSWnduEH7FoEPq4byAaVwRx5If3udw/kk7kpSMKjCk8DI3F1qFy9ptBI2m3jkqpqyJL4/3slnFB/8mjeN1SMPRIjuR4VTUAAEYYgqrJPW8f74r/7k1Ic/naupmI6HlLFiRcs+svJuvxp59D56WLd9+hb2PpK44O9WqefrchHT rADi5YhR H7EOJ2kYdeK4nlMGecX5Ih/+YJKzvdw4eNU71iwC/RTWzTRvODt8ztiwSNTQn74BNHg4/duVdhwW//yX4aq2EVqCauLkrEizkEbPrTIuD3kxsPXBCjxR7TvODhN+uG4ad98WC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 16, 2022 at 2:06 PM Andrew Morton wrote: > > On Fri, 16 Dec 2022 13:46:58 -0800 Jeff Xu wrote: > > > On Fri, Dec 16, 2022 at 12:35 PM Kees Cook wrote: > > > > > > On Fri, Dec 16, 2022 at 10:11:44AM -0800, Jeff Xu wrote: > > > > Once per boot seems too little, it would be nice if we can list all processes. > > > > I agree ratelimited might be too much. > > > > There is a feature gap here for logging. > > > > > > > > Kees, what do you think ? > > > > > > I agree once per boot is kind of frustrating "I fixed the one warning, > > > oh, now it's coming from a different process". But ratelimit is, in > > > retrospect, still too often. > > > > > > Let's go with per boot -- this should be noisy "enough" to get the > > > changes in API into the callers without being too much of a hassle. > > > > > Agreed. Let's go with per boot. > > > > Hi Andrew, what is your preference ? I can send a patch or you > > directly fix it in mm-unstable ? > > Like this? > Yes. Thanks! > --- a/mm/memfd.c~mm-memfd-add-mfd_noexec_seal-and-mfd_exec-fix-3 > +++ a/mm/memfd.c > @@ -308,7 +308,7 @@ SYSCALL_DEFINE2(memfd_create, > flags |= MFD_NOEXEC_SEAL; > break; > default: > - pr_warn_ratelimited( > + pr_warn_once( > "memfd_create(): MFD_NOEXEC_SEAL is enforced, pid=%d '%s'\n", > task_pid_nr(current), get_task_comm(comm, current)); > return -EINVAL; > @@ -316,7 +316,7 @@ SYSCALL_DEFINE2(memfd_create, > #else > flags |= MFD_EXEC; > #endif > - pr_warn_ratelimited( > + pr_warn_once( > "memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL, pid=%d '%s'\n", > task_pid_nr(current), get_task_comm(comm, current)); > } > _ >