From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CBC2C77B7A for ; Tue, 16 May 2023 22:24:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B201900005; Tue, 16 May 2023 18:24:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 761C9900002; Tue, 16 May 2023 18:24:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6298E900005; Tue, 16 May 2023 18:24:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 501A2900002 for ; Tue, 16 May 2023 18:24:25 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1FD351C71FF for ; Tue, 16 May 2023 22:24:25 +0000 (UTC) X-FDA: 80797548090.07.3D63EC1 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf27.hostedemail.com (Postfix) with ESMTP id 444F34000E for ; Tue, 16 May 2023 22:24:22 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=I+12tB8k; spf=pass (imf27.hostedemail.com: domain of jeffxu@google.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=jeffxu@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684275863; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AU+G8+xjWKVQ5QpMo/ZQtkQQPbKk/ob+AkurzetYB3A=; b=JgKGWOd1Z03qSNOGuHfcjbEmLldLESo0B2erI+IhzkTmN5p6DJaEkQh6G5MJc9OAE3lWra 7A0ct8EMeHnDB5Tt1wLHa/S4KodBqGDtNY6Q1T3xt8bO1yzqSoBqRuNMq5Lj05skTVXQO1 uVwUBruEmMzDiEePCIBE4GbcNvOtd40= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=I+12tB8k; spf=pass (imf27.hostedemail.com: domain of jeffxu@google.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=jeffxu@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684275863; a=rsa-sha256; cv=none; b=RpjMEtVPSmPYU1fohn210VEuTIiM9JENFbDuxGwO4uIXCmRh4GvPoFZTstxm48xBW0Kd0V 4aq8UpiBKVSrT2ZEsyn6RnBVhUttKWa1rwOE8g20A459gaA6xQ//n126jUdsVyH9fw8Tae lPqaq9Lxm8u+LFDirftmcQK0yopAcNE= Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-4d9b2045e1cso183a12.1 for ; Tue, 16 May 2023 15:24:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1684275861; x=1686867861; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=AU+G8+xjWKVQ5QpMo/ZQtkQQPbKk/ob+AkurzetYB3A=; b=I+12tB8k6cmWXNu4K8IeyT6yX//Q7Lt11e1U3ivqkeeNZeBZsEkMyNEb257HXDCD/2 PIc8KE7K+G3HfXqeTtrQkxcylFnF/5nD16KKO7uUQseU9uhkiM3IOhP6SCc+F1aiSGF1 It+znTfuWuEtYPBXDJOi6/4iyA12Ty+0Puwk6l9QPMWjarCK5iqt0Fu+nr2+yFa1KLIJ z4LiEzTYlGNUBPhjuD6IMeJApIbg/QQMMOEGIRtIEJPAx3GLRnyGc+ZBOWrMAZblt0gX kfIk249OUMEGX3hdhtiR6QOY4uHtIbwdJ2mm+8Dqb109gAESymSqAXrAvsrF4sSSRZSf Od+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684275861; x=1686867861; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AU+G8+xjWKVQ5QpMo/ZQtkQQPbKk/ob+AkurzetYB3A=; b=E516pc0pVFtGTu9EcEqc87tyMsVdaWNH1drUyrSdqR/tAEJJ6DhB+kfsLfbnm8pBW5 5tNuS+m1rmt/SalcGTia/CPKhBsayOR+KdgnDJatbYHQBUpQKC2g0LujwoPsH052HAxS 0i9YIUzOAqMhIG/GJPiV8BfZ+XAvX96toe2REQfVM3TySCF+0nY2JZfjDxYO9mJP1ZmA yM/LDdDnyHgU+nZghy9f7trQfcgCRTc4EKPince0hTEP5bgRdkt11I92wyeSclf9+Gt3 woDume1SQynwu8lnStayEs+ehlVwaTPeFjS8yZRAbYU/YuJOUt/3p3qduLX5sE4NU3cL W8sQ== X-Gm-Message-State: AC+VfDwp1pbCmNz2C1zPUwne4x8Ct9zIc8ERyjshuWyQE2Hk2o3eQbPb F1MRigEOezPBbn58uKN2Utn4cyjRPmzCWvzBjXi4oA== X-Google-Smtp-Source: ACHHUZ6I9F6ZxW6AR0PAmznGKdrruOuCBaUN+XoRqAFbHSGQ20hvl27t0+Ehm201A6rGO8XrNf3S3AD1GrFz6zCTvtE= X-Received: by 2002:a50:99d3:0:b0:505:863:d85f with SMTP id n19-20020a5099d3000000b005050863d85fmr43123edb.4.1684275861049; Tue, 16 May 2023 15:24:21 -0700 (PDT) MIME-Version: 1.0 References: <20230515130553.2311248-1-jeffxu@chromium.org> <20230515130553.2311248-4-jeffxu@chromium.org> <202305161307.77B29D261@keescook> In-Reply-To: <202305161307.77B29D261@keescook> From: Jeff Xu Date: Tue, 16 May 2023 15:23:44 -0700 Message-ID: Subject: Re: [PATCH 3/6] PKEY: Apply PKEY_ENFORCE_API to mprotect To: Kees Cook Cc: jeffxu@chromium.org, dave.hansen@intel.com, luto@kernel.org, jorgelo@chromium.org, groeck@chromium.org, jannh@google.com, sroettger@google.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 444F34000E X-Stat-Signature: oe6nc4k3497uou8fi4f5jgh697orf57f X-HE-Tag: 1684275862-232681 X-HE-Meta: U2FsdGVkX180LKxDG2nlgRCGILD9ITJQne8EU3pVM9O8tmlpF41i7cEdz84AR6TUpdUf6imgnE72nc1xXeMBBdITLISpvC9zUWbMOuPxtyVf5qAUt4fTLrFPreCz1dwPRXJY10Y87ZQZgnJXk6s6bOkbmvUmfDQTnvj86c8C3cMORzNrn/yBeOw0iKxGQrVbwkpmUmWYXtNQd0ujcleE7O/JOWZTyrTNnPpvy5hnrG3RkccKwSzeHBwJ3NbqRf638+6jEHiuhgkTzzgb4xRYHmWwOGbq3Yv41UNDT6EC7a4JD4O56i7c7TvyPTnsdbCP0o/X4qRzn5+No+QnmviJepSTIEFeX4Z4Y+KS/a8GOsEkeNpcYJGl+JPFtL9I8vtnh320svZhr+1A0Eb4133HWq0MHqPKnXBn2ryFoZuS3y9kNN8VprZ24VvP/ANq9AP79ZwF4KJ4ks9gDQFKWorQ+JJ6TdXSZKxHtsCHKA1wcHox5LDWSWehZMMF717LLWVPir5jVnrN/hp9Y5NBjMnl+w1qW+awY56S3aG3t8FbB859JX++uNyud8CF4MkkUrkCl+qJSyDsPhbi88dybt+GxuEfpSOEywoMVFsLr3GkAgluTxwjPFd3mKcKnpY3uPMPkXqmiiRJkli7OUS8CbPFtjF+Hs0Ar9HqHudRPlluXwre/FNTglVJEWf9RomZI5pG04eLzo96wNMxo0HtwbbmryrMLfrklkm72KYjNKtVPKhTFelk29POGtYcM23j1BZgr1fk3CP+7IQDLkG00ke8yIZBeYJG04CLF6kDMLIOAjoUdkHdu/wuXBdGSIl5ZoHvTO/X45IZeZO/IMYp9YUHFr4XiktAFMxjT8Vbuoecf34UXtX753iCupHH4r7Ver0EtMCKbbEEr+0h339ZXvdkuXZlN0Y7zwQWDtt9ilEh+1RCK7UiB0jrBlCAx8ANBZe938GgIIhEnF7viwDN5Z6 VqrgHyI1 oI2oIBKynUWLPmgsuiGprosFS3Fw6i1qSnoGr4DsEWvq5jZdokcFVttgaTJL3fttwH9e8ycBeQALx6vqNR5qp2myHQqj/yyjPT+ZM8yXBIJnoXV0B8vhJO4N8niEeiE8ggvFHTD6de91gVXusJlTJsKJJkRQA7AKwGc7NYRuymBExtZzXpGJiumU6DSJ7q1eI+PNGH7f/FeKRV4GERtprZIyZhGsNbxRGRgfWhQmHNI8RzNwe0VnEFWsM4NFMzJgfW3T42x8Aa8KgSCPLKMsKYKXzAQLrtzBGk0yljJaFR9ZRv7NaAztTv6WdKYQNoAXSlHHxvIZksNaT8A6Pdnl5m/0pIjErWiS1by5p X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 16, 2023 at 1:07=E2=80=AFPM Kees Cook w= rote: > > On Mon, May 15, 2023 at 01:05:49PM +0000, jeffxu@chromium.org wrote: > > From: Jeff Xu > > > > This patch enables PKEY_ENFORCE_API for the mprotect and > > mprotect_pkey syscalls. > > All callers are from userspace -- this change looks like a no-op? > Yes. All callers are from user space now. I am thinking about the future when someone adds a caller in kernel code and may miss the check. This is also consistent with munmap and other syscalls I plan to change. There are comments on do_mprotect_pkey() to describe how this flag is used. > -Kees > > -- > Kees Cook