From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D89EC4332F for ; Fri, 16 Dec 2022 21:47:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE23E8E0002; Fri, 16 Dec 2022 16:47:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C6B7E8E0001; Fri, 16 Dec 2022 16:47:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0C498E0002; Fri, 16 Dec 2022 16:47:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9D8A08E0001 for ; Fri, 16 Dec 2022 16:47:38 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 78292C02F5 for ; Fri, 16 Dec 2022 21:47:38 +0000 (UTC) X-FDA: 80249506596.16.E525C2C Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf08.hostedemail.com (Postfix) with ESMTP id D71DD160002 for ; Fri, 16 Dec 2022 21:47:36 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=imch457w; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of jeffxu@google.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=jeffxu@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671227256; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6nVEs5xFKdjJrb7rw+tJ+EGskEE/XSoBaU5tE1Of2UM=; b=PkLCccEZTtxcT6nfle59ZPTeoDL0iHErGMl5q+SbNGNoMThpYPrXVFcR5R3NSdAOvVyfS8 FsRrurBu1kFE1bfpuz/PdSjSl/a8VIzoajrXnJMIsO2pbHUxA/9+Qa5RjHkLGTR2zRsF+q 1sCufR7aQtXoUqbo7hRMTzqaA04udVI= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=imch457w; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of jeffxu@google.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=jeffxu@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671227256; a=rsa-sha256; cv=none; b=y+hNNpI7jGiQIL4WwTZ0YQIJ+eLXdDZKYVoMrgwRwx1T8vU9W7YwhR4k0a7xuiAZFPJh10 h5pSEctM6qu2URhMfTk0Kd2HXexincO8eql0PpJr+FYSjT4ibizs1o3gwVKfzi/Fv4V3aR boO4QafSvDl7iiQJN1RHqxfeQbggj+U= Received: by mail-pj1-f42.google.com with SMTP id e7-20020a17090a77c700b00216928a3917so7392911pjs.4 for ; Fri, 16 Dec 2022 13:47:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=6nVEs5xFKdjJrb7rw+tJ+EGskEE/XSoBaU5tE1Of2UM=; b=imch457wLU85EdPzcALjROdhazTLRL8lGUTPNwvtmi9e/Zx5tvC5qObvSwlPANkyp7 IbI5E4saBVEEk8pKdB8uc9IxGwWPBvM9xjE8D9Opdg1/orL++y/vOMdMKASdhvX0/1mt cQ8ks02Vdm62J08IecNC24yv+sglbd382CWEybZDHpvlzWPAcR7m8k8CaYYL+7bY/Fsd U+wIMsGKUpqvjcTyRzT8D1vT+Yx/q0ViD/qBaWXyVKjK69WcKqRySzzK4a4iOaX60vWU tw1r1xQAEiAzoK/2AARS4tOiF/Uwf6la+eYVZNPyuaTrycHB9PtkJ9brVbyAreybaBbo Wi4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6nVEs5xFKdjJrb7rw+tJ+EGskEE/XSoBaU5tE1Of2UM=; b=bfCoFFhBadaw4jPC4oSa0sIfTfbA2L5z3yqHnjO98Q74X5I9c9ipaEkVzUY4Ygkwg2 GvBaDxfxglA80F7EBxrybXiQnKzD2++mWlgIAhvPm3wR20NJQzBDMTabt1fVmjhOTI8p VfUhy1kc9itFMvN4KUT0ubCEIJfbAUl9/kfO2qxDhPt5wIGEfdyeUjIso1fKxVtcVgKD 5+G4AHD6Q643xJx/TD2f+Wy5rV4w3L5oo5mG0eTRYxppjiu2wDB12Ni61f52KHEv2kSE PRBD6XcNpUp2V8xQC0ceOfaFE8m9k9GrZL1soW6XJJctp1T1EctvzeZrzCkD+S50DLqP s0Gg== X-Gm-Message-State: AFqh2kpfJWiexDMsJNfgAcY/rZSwoRh5o5E2E+iDOEoc7ARhoBRX/aSL v/1gULXTGMGjSnxAvRHp5YYLLk0cdBs8uXDouTNTsw== X-Google-Smtp-Source: AMrXdXujucDbis+jisu/8phFW07nKafYIDiwu/+Zr6WdeALYIoQUEtnKDq4oRFNwWnebww/zp5jU4JPy+wNaMFqJTKM= X-Received: by 2002:a17:90a:4612:b0:219:a43b:1006 with SMTP id w18-20020a17090a461200b00219a43b1006mr1266289pjg.195.1671227255426; Fri, 16 Dec 2022 13:47:35 -0800 (PST) MIME-Version: 1.0 References: <20221207154939.2532830-1-jeffxu@google.com> <20221207154939.2532830-4-jeffxu@google.com> <202212080821.5AE7EE99@keescook> <20221216094259.bec91e4abd6cf54a05ce2813@linux-foundation.org> <202212161233.85C9783FB@keescook> In-Reply-To: <202212161233.85C9783FB@keescook> From: Jeff Xu Date: Fri, 16 Dec 2022 13:46:58 -0800 Message-ID: Subject: Re: [PATCH v6 3/6] mm/memfd: add MFD_NOEXEC_SEAL and MFD_EXEC To: Kees Cook Cc: Andrew Morton , Peter Xu , jeffxu@chromium.org, skhan@linuxfoundation.org, dmitry.torokhov@gmail.com, dverkamp@chromium.org, hughd@google.com, jorgelo@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, jannh@google.com, linux-hardening@vger.kernel.org, kernel test robot Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: D71DD160002 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: nbbqr7eomjcbhgo5qdhy36ch9y8u8b4s X-HE-Tag: 1671227256-648401 X-HE-Meta: U2FsdGVkX1/VMBwq+6IsnqIwP2TtP/71PRr5JzQJMMmurFXK3B7NrkqTUBaJray9zJBqGuXt5auyXchxavy5sTEp2bl8YqzRBHw4CkgKITLMk4xnLfkxtTMtL3tk+BfG9ARzOzHVUlkqagrNkrYJwAEZLIah0VsnaPXmU6g9eTUn5WEscqnRBEG1PK0I9gc3kmDoYOiDLWFJFNH/Av5C+uXkLA8X2PXlIckleYEXVuGRqm0PDzPVe8oG+pQINSroo8DL+L2ClzcPYsSYBRMzglePqYmsPR/G/QS+pXvrh7vOnA/MTVWsrj0Wz1aqXVurFhAF1x3IWuvpjG1WE+fsr9O/6WehIBR5YFkNU1pwcv7ES0SE6tKSHViTTucte8gogmGT9n76ivuRuBh8USzHU/srDf0rLTYgztlxNXWyUBuuuV1wXybzGur1snzn3GYmvOeENbHLtnt3mImgKxDIEeJdbLaT4/zRbYl3ZrBuzjl3zmXrFQVpXNULWyC293uSVGtlkVrfe4Ckn7DpE+nppdttqbAb/sU/rv/oYnJzKaX/DpQqlJ5bXP65g1hHmRkzXeaNOfTzDGEawD8Iv15dEAcD1LSWdYdOQIYBxhzH3WnMpu92w+L5gpKbRmV75BtmDuZUtxowHa1se49EOKbJrjr+uo4VEh5g0RFj5qSGih3mz/HK8nHFGW56BsoUVOsqEsQfCLCpIQEi6S4FWSKXBfJBNUcNSSaVpdsnW75EZm5sPN/gtdVF9idocRg6qwXU9m26Yb3LD71EAZDJ2QAUZgvLJde0XK8a58Efz7ciswpBkQQnDlC2LTbC78pgjs7zVPT2IUIKv8fYw7zN5B+CDjZn94yY6v5DlgnOGmduHzqbpda+Mubcj9aknCmiMb/BcglwlcyrrUAsu9qdPFIPOYyrSozyXgOAjsh34cLZ/T91BT6Ldja5bqolxzqVm8VBXu8ZzJVAx2fav0Mzxve Q4hm75ot 9YYGN94hAMkZb/NOMQtC/95TyjH9RNq1PEiXOJCEcDpgy3FUK12ib+iRbmh+6ajhI0lZ/p+q+ykV84qKiblllzH7cr81EzL3vPxAn4DKCmliJjEjZpy/xJSktCQ0+/c/EdTH3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 16, 2022 at 12:35 PM Kees Cook wrote: > > On Fri, Dec 16, 2022 at 10:11:44AM -0800, Jeff Xu wrote: > > Once per boot seems too little, it would be nice if we can list all processes. > > I agree ratelimited might be too much. > > There is a feature gap here for logging. > > > > Kees, what do you think ? > > I agree once per boot is kind of frustrating "I fixed the one warning, > oh, now it's coming from a different process". But ratelimit is, in > retrospect, still too often. > > Let's go with per boot -- this should be noisy "enough" to get the > changes in API into the callers without being too much of a hassle. > Agreed. Let's go with per boot. Hi Andrew, what is your preference ? I can send a patch or you directly fix it in mm-unstable ? Thanks -Jeff > -- > Kees Cook