From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86074C001DE for ; Wed, 19 Jul 2023 23:39:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CCEF7280054; Wed, 19 Jul 2023 19:39:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C7ECC28004C; Wed, 19 Jul 2023 19:39:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B46B9280054; Wed, 19 Jul 2023 19:39:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A4C2328004C for ; Wed, 19 Jul 2023 19:39:14 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 62E1314026A for ; Wed, 19 Jul 2023 23:39:14 +0000 (UTC) X-FDA: 81029979828.08.424D79F Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf13.hostedemail.com (Postfix) with ESMTP id 997E420012 for ; Wed, 19 Jul 2023 23:39:12 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=0WKLPir2; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of jeffxu@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=jeffxu@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689809952; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HmrEfOt69YUXnEdwJv4OzNXNHr6DjdUI8qa/nWwMStA=; b=2lMI4oCmwE5f8hTh77487M/aLIghPmtMK+h7K3bEyeHAzpNVI3GOXRnwW680vCSylUg9Zx x5ONoPQV+zvmfDA7Ma0vXBjYLwKJ170QfPDk+Qg3L6T38aMC0942xKxLRxnrDvh1c3OSXw iwzuLCoYJ0ptmEd+oMAA6DUmngRhRz0= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=0WKLPir2; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of jeffxu@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=jeffxu@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689809952; a=rsa-sha256; cv=none; b=iYFwXLYmzpWDo0nBBjfQBIRVfc1Mdurt/WpMir8t6w0C7ldBCU6LxVTTUVPjDHRp6QW1IQ j4nbdXXDLhegDUxIFfXryufuBHYb5e7rdAuTHisHYsfvabViV17kuOreIMkqPFVq0GwSvR cPqS7tyO62Z0EIP0PlewgeY5PiAtGaw= Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-40540a8a3bbso75691cf.1 for ; Wed, 19 Jul 2023 16:39:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689809951; x=1690414751; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HmrEfOt69YUXnEdwJv4OzNXNHr6DjdUI8qa/nWwMStA=; b=0WKLPir2pa9/CRXGovk0E4uvoZZE9YWDMnWHWVTl4C/JUTXTiLxiL5w8EC6AjUb5M8 sKmhU5dQlMz/mXX9sXo4+sgGdW1LAUVTetns3CHFEdIhmt4sTzWfYSt0Gp14qZBVjm1G P1/d5VzxifD7nw/azv2wTdoDjah8GA/4Mh0cEtO0NhGcegpI7Q674tm7S+8Z4WN+9cO8 r5kf089kSAfX7HN3FZEmF/GQmbpswdQxGm50dJb4qdN/kKDjLh/dtyCbcF1jB9aOU6Ui joEZ797Scb48278WXsqbpIqHqA9xpNdCX+t3yDLxhkXXtkW4tvf00wj5g/mj08QXX4KE 9MyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689809951; x=1690414751; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HmrEfOt69YUXnEdwJv4OzNXNHr6DjdUI8qa/nWwMStA=; b=VPFqUhke0CdTphBbN4DFUpCY9Yd5wUNar8pBBNM93o/yGT6oAuDHyAHUGXxrhe4I1Q ImFqMiCy4q2loQHS1plnEyAjkwPkBjMnnx3AJUEuplmhDLe+dKgcozOe7KPxpquurPg1 5QpIs075JKfk1ljAv9W2gC1lzoDTx8rN2mkZnXCEJrczSVF0CrvC3e3Oebqy5ki8EC9l VAHHrnD0D7YydqZVtwXvb+z3ky/lzWw20BWwcVUK3EOKBCuyONPVT7aRiCZzAKZACpoP CF5ibD4lOCurVJWL1HIGiBROIMS3rhVPtbcBeI6+CPIaaXTvzTNRQEa3u+dxl0mPOrlS HBow== X-Gm-Message-State: ABy/qLa4Cfb1VQaHlIhNLftcO1p4KREdnmrEiqetKJietLJHP7iWt+yW mKLMlj+e3bDv9rxqcqwx7BOoMXyljQNSankBrQnDqg== X-Google-Smtp-Source: APBJJlENRHebbDBgH0cBdZkRZDSVow7n9gxI/Za8tVG/FbVfhGnh/QwaqwDQdWnjN/0mBfMUalijnoI3davazs14tWY= X-Received: by 2002:ac8:5acc:0:b0:3de:1aaa:42f5 with SMTP id d12-20020ac85acc000000b003de1aaa42f5mr61671qtd.15.1689809951571; Wed, 19 Jul 2023 16:39:11 -0700 (PDT) MIME-Version: 1.0 References: <20230713143406.14342-1-cyphar@cyphar.com> <20230713143406.14342-4-cyphar@cyphar.com> In-Reply-To: <20230713143406.14342-4-cyphar@cyphar.com> From: Jeff Xu Date: Wed, 19 Jul 2023 16:38:35 -0700 Message-ID: Subject: Re: [RFC PATCH 3/3] selftests: memfd: error out test process when child test fails To: Aleksa Sarai Cc: Shuah Khan , Andrew Morton , Daniel Verkamp , Kees Cook , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 997E420012 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: y6d7qbo6kyx1px478kuwney73gz6z9td X-HE-Tag: 1689809952-768981 X-HE-Meta: U2FsdGVkX1/NNIdMmYLaINa/DCeqtvr2HBlt4WZRoiz4lpekKc17OZgFseEbFARWUzlzO0bcm7WE9ppmMyQNllz2b4d1SIlLHmeWlQCDoW1JBD+QI/6tIAP7sM/B+zHdXyL8Jahx362NltLk3mokHtB4fcsocQ9STH+ILZEgwHYfa+PYcYcqbtJYneYj+BMitYFJ3pP2a9PJf6AP5E3Sbfdo5QqAlTab4ej3o4itExcZD5RIZO3OXvb/qxuux8dfST3/nYc3BbvvD/Y+n7s0hDXhn8znNQKCizgNF24RZnQhart0a/XTO2gee5/mHJ9hcOPI2tJZtSrh68Cef10BEhZWCa6GW6OhRCSNyzg38pEzhNVyCTeV8VKdE9TXfWgBO4CxnNNGUWHqfKZbgKFhVGnbC5jdvJb1avsc0nD94EK+ceqKflUWJDNbeGFnGEjBsp4FIpZCgpZRu21Xkz4bjdxjoplRfHcbTWFJLGnaraZVYfIgtJ3bRJJ4nWt5iztHpomBN6hVWfLPWuTcGynRwXxVf+vmHl1x9G5NnwdOqGCmIVTRMi3/dSL13J7xhIYRvwr9fIOhGV5L7UI7o576GJVw1CNH0799XPrHucmUk+pM3vNt6eKAxeYNI5kBf3yeDgHh9MzaeZeqrO+f1MO37Ii5pEOpFPQITwDtjdoluK2izqS5wDidmBvOBQBGXEE8OCKRZxdwoxE9y3VgmLXDJ0mo0jMp+UhpGmzOwpmSUjjGC7koyi/me8WRdH5JrsVomyvxoudj9X/zVpk+YuXBd74kZZeOCQCuzHIJdHSkYSL22EVc1iL7XizKJRQfpFKlt7wv7fUhLL3ghiYZTTPx/L9AM72sMWNxCsUyt4j/kjLUv2JeIQH6t9j4cztOXAPiz4oEQMJD7YuZ3RZRhj/jYHOsUV6iQ9sIr9O0qWua0OWfapYgaH+R/GgNUvVVZ+uRk5GWb7DIHo59MRLz2RB w4Lba3Kf YdHfcRmAaulKJntGjZzyi72N+8/ya1usXcmvw4IXqhVKF5z1L74jXrW+1SOeRLOi27/ywkVC/cisz2TR2TtD5x8sCJoCfgk6CR7Xk0YxhKiebqnZHDzx5J5Mka2+8dWqfcotsaIOCpmTyDXRJlZXpJATPzAl+x6OyrK1enuKfuD2+Pc+IkCuXbe1k+XRL/minq4nSigzmw/7lrm0YyAi3hDRIch03o1/Sf6x8ZUBnLj/4bOtYbciYrAKtVeQIcEiS6LZiPKRr3rrCfwzwD9HOi3R0q2SUIKofxsU2OtKgrCGfzSPKcl5HAJeTCA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 13, 2023 at 7:34=E2=80=AFAM Aleksa Sarai wr= ote: > > Before this change, a test runner using this self test would see a > return code of 0 when the tests using a child process (namely the > MFD_NOEXEC_SEAL and MFD_EXEC tests) failed, masking test failures. > > Fixes: 11f75a01448f ("selftests/memfd: add tests for MFD_NOEXEC_SEAL MFD_= EXEC") > Signed-off-by: Aleksa Sarai > --- > tools/testing/selftests/memfd/memfd_test.c | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing/s= elftests/memfd/memfd_test.c > index d8342989c547..8b7390ad81d1 100644 > --- a/tools/testing/selftests/memfd/memfd_test.c > +++ b/tools/testing/selftests/memfd/memfd_test.c > @@ -1219,7 +1219,24 @@ static pid_t spawn_newpid_thread(unsigned int flag= s, int (*fn)(void *)) > > static void join_newpid_thread(pid_t pid) > { > - waitpid(pid, NULL, 0); > + int wstatus; > + > + if (waitpid(pid, &wstatus, 0) < 0) { > + printf("newpid thread: waitpid() failed: %m\n"); > + abort(); > + } > + > + if (WIFEXITED(wstatus) && WEXITSTATUS(wstatus) !=3D 0) { > + printf("newpid thread: exited with non-zero error code %d= \n", > + WEXITSTATUS(wstatus)); > + abort(); > + } > + > + if (WIFSIGNALED(wstatus)) { > + printf("newpid thread: killed by signal %d\n", > + WTERMSIG(wstatus)); > + abort(); > + } > } > Signed-off-by: Jeff Xu -Jeff Xu > /* > -- > 2.41.0 >