From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9348CCDB482 for ; Wed, 18 Oct 2023 19:07:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0AA78001B; Wed, 18 Oct 2023 15:07:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B93318D0016; Wed, 18 Oct 2023 15:07:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0C768001B; Wed, 18 Oct 2023 15:07:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8E43F8D0016 for ; Wed, 18 Oct 2023 15:07:49 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4CCEFC0291 for ; Wed, 18 Oct 2023 19:07:49 +0000 (UTC) X-FDA: 81359516658.08.ED415F7 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by imf23.hostedemail.com (Postfix) with ESMTP id 8CEFF140027 for ; Wed, 18 Oct 2023 19:07:47 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=WFeH3e6s; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of jeffxu@google.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=jeffxu@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697656067; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7jLh+LVsADEpQn0tXrIhHZOOTufYjaEXj860xp7E8aI=; b=yil2hqHqcqjIHc6GdwoTATMWPDEDdlASR+s8mgknzoHkcDM0hyS8KYrpexw0jVlMW1lXw3 L+FfnaWgiusjfKSYN67BD+azTSNam74W7fN60eqbNuxljK/OYHdcmR7dXhP5cMGBamaHjY 6Ig0KWGnFnLfqg333Sfs6zjuQtkTsVE= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=WFeH3e6s; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of jeffxu@google.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=jeffxu@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697656067; a=rsa-sha256; cv=none; b=xZ8/b/Sph7hXYfFqcAhV+1Qf92x/iIJ5GV4VSnAMoLhMDhb+uYDBwUYDV+1eHwb1XAN4Fm TUzk9L7JAhUsDNLw2rxYDyw3kI73PnZ8VtJsjXOOFmpc0PpapAmyMXZJou5oYW+MF15gs7 VffVocaLvRVOiJVZJ9iabVKE3FfeDhE= Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-419b53acc11so57841cf.0 for ; Wed, 18 Oct 2023 12:07:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697656066; x=1698260866; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7jLh+LVsADEpQn0tXrIhHZOOTufYjaEXj860xp7E8aI=; b=WFeH3e6sFi944ZRWY2TD6PnTidyPD5SfL0V+KkvOoXgY0kLTa7FjqxhHdqHkB+dLMa juMZ++04mc4Bz2MgZctiF1SnjarFffLdp7I6b8fSb+5tqUsSBEv/nmP4R4mNbR9lTTjx cB30rwYk6ZwrhWXAR/BSyWAwgodSdxdf6PWnCc9rt8f4tuAqAw8f/jtDy9rlCVLhL5yN W00GWYbxzxZUSZrK07TW+gDomkm59kkDslf8gWH/JXxuHgsQSrP6wQE4ME/wWRacPxZD Zd4pARxM2WBFxtURSQZxAirwh9JoCmYSEaW2evRUz5N207coT34lkVNfSBpXLZHqVSd6 gkxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697656066; x=1698260866; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7jLh+LVsADEpQn0tXrIhHZOOTufYjaEXj860xp7E8aI=; b=CwRWBNfmH4EDDpHVKD2AgLqtAcTSKqZI9ytbLwfBQqMtt2xpbckaoxUvMRe09Zghdu 2keAD6k9mZ+P58GpSiXlv49aP3Dh0nWz2Hsy+SnZRagPjnVlKmunjjSgc0g4SuznD6nx tDwVP814lOg5BIUBoiGHAxSUTET4rx4cvz97toxIHu/2RpM/yipmSecgiJ3Id0YQ8sKE vaINcx4LqTUCB8bwQc9RYtGJ7PmJqY02U+Vqd6kpF+VCPvAmjTZp6uuz2YDqZ/BgB1WS mEGo63/LR9WnxotIbxiw97onnvZTlC99lXRFZpB7WLgd4GX+FzNA7/Yb0Jp7PWodoQX7 b02A== X-Gm-Message-State: AOJu0YytJZQd6OxiWuOK2Rrx/JA0iPYrH9smKpug4xmMEPH0WhYFJvL7 8B9gA6kpaP3peoWNRJ39iK3OMNoprkfjA0/bUkzowQ== X-Google-Smtp-Source: AGHT+IEfpqH+NCZtb7mB+SU291n5YTFgfJ3T5+Hg/iP5B84SoIbdRXNJIdwzGfDI551ZVJup3pkbx5z6Q9EAvjVvxG8= X-Received: by 2002:ac8:4d5d:0:b0:41c:b700:fb84 with SMTP id x29-20020ac84d5d000000b0041cb700fb84mr57193qtv.2.1697656066547; Wed, 18 Oct 2023 12:07:46 -0700 (PDT) MIME-Version: 1.0 References: <20231017090815.1067790-1-jeffxu@chromium.org> <20231017090815.1067790-6-jeffxu@chromium.org> In-Reply-To: From: Jeff Xu Date: Wed, 18 Oct 2023 12:07:10 -0700 Message-ID: Subject: Re: [RFC PATCH v2 5/8] mseal: Check seal flag for munmap(2) To: Linus Torvalds Cc: jeffxu@chromium.org, akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, sroettger@google.com, willy@infradead.org, gregkh@linuxfoundation.org, jorgelo@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, surenb@google.com, alex.sierra@amd.com, apopple@nvidia.com, aneesh.kumar@linux.ibm.com, axelrasmussen@google.com, ben@decadent.org.uk, catalin.marinas@arm.com, david@redhat.com, dwmw@amazon.co.uk, ying.huang@intel.com, hughd@google.com, joey.gouly@arm.com, corbet@lwn.net, wangkefeng.wang@huawei.com, Liam.Howlett@oracle.com, lstoakes@gmail.com, mawupeng1@huawei.com, linmiaohe@huawei.com, namit@vmware.com, peterx@redhat.com, peterz@infradead.org, ryan.roberts@arm.com, shr@devkernel.io, vbabka@suse.cz, xiujianfeng@huawei.com, yu.ma@intel.com, zhangpeng362@huawei.com, dave.hansen@intel.com, luto@kernel.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 8CEFF140027 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: ui3t1xbig65efygfzs9ap5jw9ufdj19e X-HE-Tag: 1697656067-912519 X-HE-Meta: U2FsdGVkX1/1DvHHOPHZoDes8yK5sTLlAXVq3fnwJpE69UKeIlN97S1GvuvI9B7snj2HQv6ryXu1KVotm9p6FQ48Yet4+tNmD48Y6ldlzSTvVWldTKaj9XR4f3VRY6Gscd5gaHIotmr1Zz2vVIef0v3g7iZQKtqbB5vK7Cir2BDAv9k4F6YwbIDDMYflAZGMzJDv/eLcYcJt3RocxnQWgpuY1oeKMQnXhd0PmeF36eIFxCb76L3UgJfTi6AoFovEkTzh2znNvHRfq14gxsWs9D6FjsEzout/O86fq/u6UfaemMciWVatuQu0M2V3feO0gle0RnA5iNSQg1QlG0fiIdPISFXFgnG8/SEoWmTInUvIx1mtMcF3bw/D8skvgjBQXWYpuSGKUFFHFGfe9OqgWOYpATmWf/ZZOqOWKaw3yc4fMe8lPysOiwwwk8YO3zZAoNJPHewrdfo8rXDco9KOl2RhkZTXLYdzRDmfUFY/gcJYRLnfH//70fmm8fKUtjtRES4AdJlBhc2bqWYHq8hlE4nNK8+DriREGleAw2MqHUb19Rh3bJTl3mdirZ7DEcqZdKjvY0AC3LR3chlKgLXCRsTo8FwBIuYuRGRMx8e9zNRplCbGuLjgIwNRpjaP40yBBYKZP0LP8Cb/Z0aM6JC2ID0MXYGiOQOv8At8x2P3ibqDAAziRft+C5a++OskQ57jHiZbT3kMAqbTE2SUgQuYd9MUrUlD6eFBv2Vdpwk7e8fK5VGVFxpVtxtdLcrfkV/R4tK/uDGY9y1f7PLYrzCE7jkI2ysv2cMI0QXFd3I0meF10vq4e8SG3uhq53Tm97OJBm3o9MFw1cJ0w44VhPEEV5LxJVeikQUruzbeyGc792IoeHqkZ8brgLyqTvWjPjBJQI2sDd5wgeluc9J1L9eLtniQrGcDjRByYCB3WgpUExvB+ifNunW3CnmOQUgi5/K6OKUubAx1l8NaJIgs6mG 0fHl+pee CVubS9nwXDWvInlvGHAKZygJwHZnBtd/0VpgeqaOVV17N+khHVfM/8QC9LthhqTXU97wJndFhwHkehHUnp8U7anxaVwXK4AuXK4wgH56APHFkdkMX71aMllUM5qbSxHq18cDbvXRJv9vzplF7HPwG7QbxJQNxJ4pG7JoCjk7CSVgg2OLHyPB8XSYlMnYEVgXrxOGy36cEhyuktiqZs0NSThOhRaKSnXTj0ANmZokAg/eFgJ/LHV8wVDJ1cAE6Ma4MzqxUzbgcYNtT4uQAkUQvpXZrL/QcvUB9yct3sBFnQbiNrcWHKzkCRBsiIw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 18, 2023 at 11:27=E2=80=AFAM Linus Torvalds wrote: > > On Wed, 18 Oct 2023 at 10:14, Jeff Xu wrote: > This is simply not up for discussion. Any flag for "ignore sealing" is wr= ong. > > We do have one special "unmap" case, namely "unmap_vmas()' called at > last mmput() -> __mmput() -> exit_mmap(). > > And yes, that is called at munmap() time too, but that's after the > point of no return after we've already removed the vma's from the VM > lists. So it's long after any error cases have been checked. > Ah. I see. I didn't know there was no legit case, which is what I worried about before= . this flag can be removed.