From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CC0ACDB474 for ; Tue, 17 Oct 2023 06:51:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73B128002D; Tue, 17 Oct 2023 02:51:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EA6880007; Tue, 17 Oct 2023 02:51:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B2178002D; Tue, 17 Oct 2023 02:51:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 465CA80007 for ; Tue, 17 Oct 2023 02:51:32 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 12CA8120F11 for ; Tue, 17 Oct 2023 06:51:32 +0000 (UTC) X-FDA: 81354032424.07.137BF88 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by imf21.hostedemail.com (Postfix) with ESMTP id 6A9BB1C0005 for ; Tue, 17 Oct 2023 06:51:30 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=y9z7TuA9; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of jeffxu@google.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=jeffxu@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697525490; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oHCjcIwAgD8r2ZfWSRWE2jRRIUmP7obRVpW9zzIvXZY=; b=1QMmk6mufRiNSGs3gb5+zj6W66y4iihCMqU62Fas9agqG88j3x7J5c4i60KCY4qMShpif+ KC1BtI6jc4+a3vsY4LqgaPMIhGyiBs4AykUf3IKs3fakf1fMTa+npU5Fc1pN5HwElPHZ+G cgJqr8HQQVhtTRn8psbjfwYCYFCbLpQ= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=y9z7TuA9; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of jeffxu@google.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=jeffxu@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697525490; a=rsa-sha256; cv=none; b=j50ALFWqrUfHKGPGW0/hBPiWy0jPmq3uy/nEF+m6zgNYVPgMxMh/ohSagW3QDv5Y+e1bVT 3Pt8ZUrZIYuw0o4Df/5X2xdCEDmBOmIeN19YBmnH5clzr4pF80/n2jiv8owC9Uq4dfvMlZ Ql0ezsLv+qb3uzsLdu5dAJ2rBYlCBbU= Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-4195fe5cf73so156141cf.1 for ; Mon, 16 Oct 2023 23:51:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697525489; x=1698130289; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oHCjcIwAgD8r2ZfWSRWE2jRRIUmP7obRVpW9zzIvXZY=; b=y9z7TuA9pHUcp0nOvd2dFaIKqC+tUt9jNalzWRd50IKHOmSYnqn6ZgQIDAkqmRczaA d4Urvewk5jt1g/YY2L7137jFpxfp1PNRrg7OeLsEk7xamOB+5nyGSTYm9iFbm09VRX+o fARvT3y09r7NmrMu3/1HxKya/VU6DPFpFxRgrN2oWapkakdmxMYxHXid4Ij9FyZgx5ZG 6vo5Z/rZ+cId8NhKpQeWJ0mHWvQw5iWZH4pxnYZPTSmW3TNj2mjFCsNZEVvQSncWqH8m 0JjowNxFDOTAd6DUnwUsGs3DG1bvkfY579jwFMdoFMdHsL0yC2LJxhWikPqNPaXnyaAp VfSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697525489; x=1698130289; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oHCjcIwAgD8r2ZfWSRWE2jRRIUmP7obRVpW9zzIvXZY=; b=BkIIJdHPj3/PPprwUfiZp179iBmJrb5GpEr0Q9uYnl+4NbvIK2XSLR+2xR0nDtMFYH Y/5WY7bxUJ9PI2dw9NpLTMMVAvWzkZMvevyPW4QEHAGRDQC7KqvMqZ5fJ7KD1nTun8Bi +/+hJjJq/REoHMwVJsh6P55yDA4J/g9dPZTO+lnVCABIoBgXgB4SqVnJsWZYMQTkDQCt tRnPb+0yDyPinVgVVsspHxbCMRmTWYJM0qWVAd30OuOYhjYipA/7Fp7iuAQmn8lyPvVE ymSGpDByaU/UkkHwncnKBdS9Ka+UQy9D4Hv5kE3unNc5cc9Aplhnr+swX0XpajMXdPsM zS7w== X-Gm-Message-State: AOJu0YySrBrSNNZbykw4U8One8GfUtGe2IaXGgfewnTVuYd4uNz06ZFK KmejP+UqawVURKlxI1uQGjb4MjIEmBPpyhLyrxtW+g== X-Google-Smtp-Source: AGHT+IHrmXZFq+mqMHdy8UJpV06hwPvok6+26xdf07c69sqojlknFnXbe8Z30UoZafYhf/PHhODqV8N5XpLKhiJclqs= X-Received: by 2002:a05:622a:8119:b0:417:cd34:2a7b with SMTP id jx25-20020a05622a811900b00417cd342a7bmr111897qtb.3.1697525489453; Mon, 16 Oct 2023 23:51:29 -0700 (PDT) MIME-Version: 1.0 References: <20231016143828.647848-1-jeffxu@chromium.org> <20231016143828.647848-2-jeffxu@chromium.org> <2023101614-scarce-discount-d7ff@gregkh> In-Reply-To: <2023101614-scarce-discount-d7ff@gregkh> From: Jeff Xu Date: Mon, 16 Oct 2023 23:50:00 -0700 Message-ID: Subject: Re: [RFC PATCH v1 1/8] Add mseal syscall To: Greg KH Cc: jeffxu@chromium.org, akpm@linux-foundation.org, keescook@chromium.org, sroettger@google.com, jorgelo@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, jannh@google.com, surenb@google.com, alex.sierra@amd.com, apopple@nvidia.com, aneesh.kumar@linux.ibm.com, axelrasmussen@google.com, ben@decadent.org.uk, catalin.marinas@arm.com, david@redhat.com, dwmw@amazon.co.uk, ying.huang@intel.com, hughd@google.com, joey.gouly@arm.com, corbet@lwn.net, wangkefeng.wang@huawei.com, Liam.Howlett@oracle.com, torvalds@linux-foundation.org, lstoakes@gmail.com, willy@infradead.org, mawupeng1@huawei.com, linmiaohe@huawei.com, namit@vmware.com, peterx@redhat.com, peterz@infradead.org, ryan.roberts@arm.com, shr@devkernel.io, vbabka@suse.cz, xiujianfeng@huawei.com, yu.ma@intel.com, zhangpeng362@huawei.com, dave.hansen@intel.com, luto@kernel.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 6A9BB1C0005 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: t19ohmqch5aetoeycnx6ui5cxiejexnj X-HE-Tag: 1697525490-161954 X-HE-Meta: U2FsdGVkX18Hcd/xNiM97Kx645f5cNFY5mRMgJ20BIxCcAIuyjdU2WhTBUe3vN3qSKZwXIWXysjiUjzlfu1skajRLrSGTGmgE22Oo3r3La6+y8d7rwkJ3NU/gZBDsymP3HBhNCYFE4XI3GlELypWnM2xHdKNVlKo9x0nwvIAO92BFA4QEaUZ1WojIulUBIHGn99PQcnbpaa86jVu99dUg9EFzAFi5DXQI5aCLxO4xiShMdZ1nI3GV/OdXvWk7RyCSQutzMYT4OcBKShGHrUsKSpntDUxaVmK0qB7gXUFcgW+MbabQu8jvjsnhfGQSsbpFDL5M/lXYWB9htiEA33nPh5GQrMXhLNBes9pfD2cdNod6X90P10kDi7nnq+EYzDJfFg4/rQ05MnGyhqshlgd9/9J0YvsTeRZ0vYdb2IttQSzTnM7XyUqToxpc9YdCV4DpC1rZaFoZRbUYQ2i6nEV3aLiyOf8GR+dh8LUIw1+kURIHBIIBrVYotw7EBButGX2IYNA+GQP/vOsiwIkJCF8qOXSt4nhJf2rDWRsPXN5iraDLPaiyR99dPtgzA1MLXXy1JCFouWiFgtiripc1NZ0PqbB0qqjFa6IZNqbPemw6tUjyd4XmN0VsSasW7WXy5+7C186KJdfp/qWxBxB2AJ88nPC460jHJ8QAwO3JcQcncyOlIYQY1vu7rulmK9cIX5MZF28ft/Q/I+nmzMW28bCV/OhvIfRik/Kkpizfi4/mtooQQXzlOAcsJJTfXZ8zb7VfNQAdCsnsT+9uHuUM91t5s/bAYLJsGOFv0U0jua5i8Ps5fYCjUlHI0TTEdKGOR/mrSxwB4uaapSBsbRPZvE+obMg24DQGSJw5vSeobXGSQ9RSDPVI5qYDW3YIBYzWgBVMGPBtn3I+ORYZoShe0tk8tHoZAfocx1xxX3C/KllRUKEZGN28rjEHrSYR02vk68rcRjMVTIqW00XHAe9pZm 7BsRxSrQ 3euikRKx9MbUWdBUWNs0brAEUWxh5IzfChyvnI3wWtzgrRrad0HyDejOA3/fkh+oK5oireWNl0F7kQkld/cruqfjkSBgW3xMQQsF+ZYLkhEjvWx1VIaUKaXuxrpxAT4saN9fSCrzADAYxabFxZ/SNWIQZY+NIrbacoUbYwa81OQyAUvvbKNmb9Q47O1OYGGUji2xxuLbjGPMoAaQisQc/wd9u0AogCJHmPpZcqS72XDUBMBGLKGW/Ebrh9SkMQaVA/o1T5EEMN1vEhcqXQaF7G3/tT5u/Z4+3xw6YFdKMXDdoJQkcgGsllrymM0rRSjdNqRiPu8BJZLnTrAu0pEHNeb5Mog== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 16, 2023 at 8:07=E2=80=AFAM Greg KH wrote: > > On Mon, Oct 16, 2023 at 02:38:20PM +0000, jeffxu@chromium.org wrote: > > +#ifdef CONFIG_MSEAL > > + /* > > + * bit masks for seal. > > + * need this since vm_flags is full. > > + */ > > + unsigned long vm_seals; /* seal flags, see mm.h. */ > > "unsigned long" and yet: > > > diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h > > index c0cb22cd607d..f574c7dbee76 100644 > > --- a/include/linux/syscalls.h > > +++ b/include/linux/syscalls.h > > @@ -802,6 +802,8 @@ asmlinkage long sys_process_mrelease(int pidfd, uns= igned int flags); > > asmlinkage long sys_remap_file_pages(unsigned long start, unsigned lon= g size, > > unsigned long prot, unsigned long pgoff, > > unsigned long flags); > > +asmlinkage long sys_mseal(unsigned long start, size_t len, unsigned in= t types, > > + unsigned int flags); > > "unsigned int"? > > Why the mis-match? > Thanks. Fixed in V2. > > --- a/include/uapi/linux/mman.h > > +++ b/include/uapi/linux/mman.h > > @@ -55,4 +55,10 @@ struct cachestat { > > __u64 nr_recently_evicted; > > }; > > > > +#define MM_SEAL_MSEAL 0x1 > > +#define MM_SEAL_MPROTECT 0x2 > > +#define MM_SEAL_MUNMAP 0x4 > > +#define MM_SEAL_MMAP 0x8 > > +#define MM_SEAL_MREMAP 0x10 > > I think we can use the BIT() macro in uapi .h files now, it is _BITUL(). > Might want to use it here too to make it obvious what is happening. > Sure. Will update in V2. > thanks, > > greg k-h