From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 390B9C41513 for ; Thu, 3 Aug 2023 02:55:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 53C72280209; Wed, 2 Aug 2023 22:55:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4EC032801EB; Wed, 2 Aug 2023 22:55:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DA78280209; Wed, 2 Aug 2023 22:55:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 30C252801EB for ; Wed, 2 Aug 2023 22:55:58 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DD9911CA09B for ; Thu, 3 Aug 2023 02:55:57 +0000 (UTC) X-FDA: 81081278754.17.99C3A63 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by imf09.hostedemail.com (Postfix) with ESMTP id 23137140009 for ; Thu, 3 Aug 2023 02:55:54 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=LHuFwi6P; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of jeffxu@google.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=jeffxu@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691031355; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M31TVCZOo8aoSS85FtlkHAzcBWuXDtd8o0N06bFn5DM=; b=6/K2i9s7zmClGIoS56f01Mr+X1b1N5JYFY12+yMYKBFwKUbjBjUWfaI1pZOqLJWuG/Z1c8 NJepMmagy9F+CE+U2n+NI2D2R3AI4pRQBdL5AX38wQNINm4NZro/EmvgH7MLy07IG/0Q1r i+eMONFS243zSvB35TxrbpIKPzBBaKs= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=LHuFwi6P; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of jeffxu@google.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=jeffxu@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691031355; a=rsa-sha256; cv=none; b=5dBfs8Bx8sZI/ZXQ2jLKB9OYjKkQ0b2Ev0EFLzqN8tO58s/B8mfobMEPQpSArHZgxsLu6q t2rl5sqyZ318KAzmt0pYi7XS+dM1aNYK5P3pgwIp9nhHPuhIdh1HgdRdLuaf714lMwTRtK hyBO6UbrVejGvFVGu64sKQ6pIgvFl6A= Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-407db3e9669so95071cf.1 for ; Wed, 02 Aug 2023 19:55:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691031354; x=1691636154; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=M31TVCZOo8aoSS85FtlkHAzcBWuXDtd8o0N06bFn5DM=; b=LHuFwi6Pl0tqGmEPZsDQ1WC65AmISRKLv2O1hD7+29C6o1j2vf3ffYQ8roiyhSns3C VM/bQEGSRB2lsQu5ehFiYLTLtdQaYtwcIE5i6feO4XiWeQ6+xNkb8ZzRE1BqfwjBfN9d UlYnVi5r18K2v3B1aUMjVfI+ohF5Uso6P1oxC8yg4W6R2wJo8h0Gl9V4OkIU4N7aHp/u xRyxhl+6vnhFDsK2LRVmGVEert0btyaCxbjgvgmufW7p2zbZOo69gwsVx+hpmoMFh7Qk KOPE4bBLRgtwouhGH6t7CnT3phYoMfT7oajwWhiyOOvzX7W37b85Fjv0QoNjwvq4wKsn pJQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691031354; x=1691636154; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M31TVCZOo8aoSS85FtlkHAzcBWuXDtd8o0N06bFn5DM=; b=Mgj1kVMKJs5OQCM7pKz/payWeE8jJ5B00/6DrpQunRL9b+Mr9988bzJE0ZaufByzG9 FWtvmHUNTPezJsco0cr1qDiDS4lW+Ug7Z6yKEvTMbvKwavaHe0vuh5x1FJyV0Ngv/xrq bjF0aIsoNFaPenyt9lCi9jA77rqAiIFBec83GJAQ9XliUiTRJLPbR32+VTAo6zTdJqzI /HGPrJy9VFA+woQ+ckYV693IQA3ZPQCl+5COi9WKZQhiFwC0e8wf+NqTZP86ry7fx2pU NET+DL0qfqTJWg7TQxIqGrHh3mHe3K7eGRfjrN8+p14/zBz529B0MtQZi6ojeW55gE5I Qjkw== X-Gm-Message-State: ABy/qLb795/N7nmoA6DrG7y47uaNO6orBeTIgV3dfYZUjQ7ijCMJhFD/ s7+ze5PX786IeIQkJYZI8Xdq6vOSnfx+yz9otrSOrQ== X-Google-Smtp-Source: APBJJlF73+NS9Vpfcs/5wuufXMrWVC1pQV7T+HkRcsUyoLeIVFkRmDt+EQONQ8F1YR9KTuBCGcpdacstPqNWblXrEo0= X-Received: by 2002:ac8:5c05:0:b0:3f8:e0a:3e66 with SMTP id i5-20020ac85c05000000b003f80e0a3e66mr1528975qti.3.1691031354105; Wed, 02 Aug 2023 19:55:54 -0700 (PDT) MIME-Version: 1.0 References: <20230713143406.14342-1-cyphar@cyphar.com> <20230713143406.14342-4-cyphar@cyphar.com> <20230803.022458-mundane.voyage.tricky.kinship-yaSxczr9O6cB@cyphar.com> In-Reply-To: <20230803.022458-mundane.voyage.tricky.kinship-yaSxczr9O6cB@cyphar.com> From: Jeff Xu Date: Wed, 2 Aug 2023 19:55:16 -0700 Message-ID: Subject: Re: [RFC PATCH 3/3] selftests: memfd: error out test process when child test fails To: Aleksa Sarai Cc: Shuah Khan , Andrew Morton , Daniel Verkamp , Kees Cook , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 23137140009 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: w91ig3kxfc1yd5enm93hgtu4mr4sra75 X-HE-Tag: 1691031354-610055 X-HE-Meta: U2FsdGVkX1/U6CPTmCCc+5GbzCCFjcQFjzinWieP8QWRHXJFppCn3xnv+yPNjA3fkJln1XAaZr0LK+WoN/s4EAo0bn0/kTZuZa+CKBL9GbWhepZ4xAQYww1YdXOmwu06ZevHqxSkDTm5r1I1RpjjEDbcentCkVAEKvbDRfm8S6KA/GfvqtPsccn1RctpYSGIaGA13UDkFUYwJkfB+TmRUrRVugrZtHAls/LmJm2ThJeAA+uH8vIRiaow4fhjps6zcLnCU7v2XiGq4Ek/OM2Ilu7ZtCD+CokD2Psn6WZ9kg/+37/zsSAfuuZ/OXaqXntScJp41hgOnQ/WMEwFINFDKqFkQ6VyJNgjXIhX6KMGAofF7P8fX5N91rWIopDZ7gPx0FJb71dnl1NPSuLOLDfIlQIytQc9oelKmZyThe7q3WaiXOTtevDyjdRtRf5x16NrYdbRvT/piZ2sxf50ktBLACumxd4b9lN/qcmWrZjHqoOI6zYIbGaiq5gJ3tF1lNfbDDbIb418PtahSX83BVT8TIPTKTikA0NEmZ7z6I/hUVjZ+xMlGasg83vxo2h0OJeVvIkguNbOrkvK/qYlw5HP9//8+SgNjZHU2r96R1gTdDUUCwEkpFyxY55sBw2CTWHmY/mmki6n+2YrHcS3KXqfJ8as/5CRW55Uau0o7Vzdkuu5AZQh5Fi5UWwG2uOVDG+O9Ywu9pIoKf4PnD1rdc7rvcqU8RkYJAxJK2csTydPZgWWHu3ruiWbzAW190F9qm5OOpStnaka+rK06wPOSEbDbhRMEtHLKtSS3jg55w++wNvfX3B+3PME+FsD1ppmFazigJ1AgZVa7FqGu8CV7K20mHW/n266fOinDeDUP5OYnfbSh/JoSc+Aan3mFyZlK331XEZbC/2cvEpHq6TuteXrRT/+tbVUQYepGZO6ybFW4T2+kk6OPfuMDpVQ2YNhh8Pd5/iozQ5YduDTe8Lx9Ot e1OTn/3c Yopr/iD/1IUA60wJl6m3jupcZVcspfuEuoXzlpAMT4AU0OO3yTZQeGIsyPxLuypUVO4mfMXZmQnoC4LN0oPSCA+kr4OAfXgUA+LbT/l2Jw8q3wslTX6dqhDlotUBc23YH8bq4mHuTX66EjishYTsbYnIVKnpkmib3dJUO15Qa3cnJh+sK7ITA/hvZliDgkbnpDDMAGGM/JtXtYFNW+dlHj+Z2dwpzsN6UNhsTjv4ktFleIL7dFnOiLuw5YSz3jsDQz6pjduk7C+c5YG6s3ti+aqp1ylQsOYtAb8t9T28BDaPgEm3z5U+v31i3Pw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 2, 2023 at 7:25=E2=80=AFPM Aleksa Sarai wro= te: > > On 2023-07-19, Jeff Xu wrote: > > On Thu, Jul 13, 2023 at 7:34=E2=80=AFAM Aleksa Sarai wrote: > > > > > > Before this change, a test runner using this self test would see a > > > return code of 0 when the tests using a child process (namely the > > > MFD_NOEXEC_SEAL and MFD_EXEC tests) failed, masking test failures. > > > > > > Fixes: 11f75a01448f ("selftests/memfd: add tests for MFD_NOEXEC_SEAL = MFD_EXEC") > > > Signed-off-by: Aleksa Sarai > > > --- > > > tools/testing/selftests/memfd/memfd_test.c | 19 ++++++++++++++++++- > > > 1 file changed, 18 insertions(+), 1 deletion(-) > > > > > > diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testi= ng/selftests/memfd/memfd_test.c > > > index d8342989c547..8b7390ad81d1 100644 > > > --- a/tools/testing/selftests/memfd/memfd_test.c > > > +++ b/tools/testing/selftests/memfd/memfd_test.c > > > @@ -1219,7 +1219,24 @@ static pid_t spawn_newpid_thread(unsigned int = flags, int (*fn)(void *)) > > > > > > static void join_newpid_thread(pid_t pid) > > > { > > > - waitpid(pid, NULL, 0); > > > + int wstatus; > > > + > > > + if (waitpid(pid, &wstatus, 0) < 0) { > > > + printf("newpid thread: waitpid() failed: %m\n"); > > > + abort(); > > > + } > > > + > > > + if (WIFEXITED(wstatus) && WEXITSTATUS(wstatus) !=3D 0) { > > > + printf("newpid thread: exited with non-zero error cod= e %d\n", > > > + WEXITSTATUS(wstatus)); > > > + abort(); > > > + } > > > + > > > + if (WIFSIGNALED(wstatus)) { > > > + printf("newpid thread: killed by signal %d\n", > > > + WTERMSIG(wstatus)); > > > + abort(); > > > + } > > > } > > > > > Signed-off-by: Jeff Xu > > Did you mean for this to a Reviewed-by? > Yes! Thanks for asking. Reviewed-by: Jeff Xu > -- > Aleksa Sarai > Senior Software Engineer (Containers) > SUSE Linux GmbH >