From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD2B8C54F30 for ; Sun, 25 May 2025 19:19:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E3FE6B0083; Sun, 25 May 2025 15:19:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 194D66B0088; Sun, 25 May 2025 15:19:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AB246B0089; Sun, 25 May 2025 15:19:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E0D536B0083 for ; Sun, 25 May 2025 15:19:28 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 82573810A8 for ; Sun, 25 May 2025 19:19:28 +0000 (UTC) X-FDA: 83482394016.09.9829A5B Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf13.hostedemail.com (Postfix) with ESMTP id AEA4320002 for ; Sun, 25 May 2025 19:19:26 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PRzi3VMU; spf=pass (imf13.hostedemail.com: domain of ujwal.kundur@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=ujwal.kundur@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748200766; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uCbl56zTvR5oX3QuUueBzYZCm+S64yobnDZB90prxRQ=; b=ltfC22opfh9w9MiSJE8eUDgh3sO4YHFXUK1RZcDevk7Iwtf/0ST8bD0y9WXvFrvP17X6o+ jJVa7fl7TWhttNx6bLmeW0DZhoaX4Bavc7qggKuPUFTAKriYLy97CCT2Tim2ift84vpjCG sWj2li6snELdlq6Q4g6S3fK41fLHY7o= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PRzi3VMU; spf=pass (imf13.hostedemail.com: domain of ujwal.kundur@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=ujwal.kundur@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748200766; a=rsa-sha256; cv=none; b=NTkKUUnBcqTkwI+TrurHSHLAGZmA1gcM03+0WsE9l+Dcbn8CLQjgC0WmlHk9qwlDfAOHPG Ep4NGBJsrfnXLA2Ilt67W5l90nhkyGjrv5MxwCxYVKLq1pzJrAXWC5fzBIIUU0PNavgapj Bse1tJ9kUSSyZV3bZFdPDdJS1+ivS+M= Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-310f3c7bd87so1112440a91.3 for ; Sun, 25 May 2025 12:19:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748200765; x=1748805565; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=uCbl56zTvR5oX3QuUueBzYZCm+S64yobnDZB90prxRQ=; b=PRzi3VMU5svzTPw8i1PBEQbHLb2+xCHWLP6Uhk1GKWDs5x1p+mHMUQ+zUUoKy7yqbp UuWA6Ub46JNUtWwbo8HVeC8WnP/Aeohb1fSUR68dhtXNbbLkLeTPF2aYb/talTGOdBXm 9iWJVcOvOpxrguvIEPXUD4fJLGYeV5cF0UNJF8mlb74ZkzFyhTwtSCM31dEgOARlzZLg NJcJQvcdl3aP6eXLI7x+rvVMoK199sDLTkgfwDcre3NEu69pW3g1cuuXYj8GI6Foin1P qWWxcec43kysprq3xe29HVByRQoXCSttIjBAJWKZuzQ/GlvLaWV/1a/XooSCKvt31ZBz mKFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748200765; x=1748805565; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uCbl56zTvR5oX3QuUueBzYZCm+S64yobnDZB90prxRQ=; b=T7VONnk8psP9QVqS9AobuR4nyqkfFCV+lMizWeHRQzw9FsbY4xJ6Ug98ab9BkW6i7H J3nALTFoZQYEO/DOLLJ4+GTUKcVe8CmIR0BUY8rW8JfOfVZYi/X2I+AseWevnZ+O5Vnn 9f3oqc0wxUX1zxrjGhIMiuA1J/GT2uulTgMCOFxkbU//EqSxeuX3GBvgw3b6tGvUaFKP Wxqp/A4fby1gom0WrjfPW8SgJcP8jTeDG0rgJlRiZs1GosQJzZBWhfu9FWm/vc6Ew1ge r8P5EzsdTWZLJ+PxEhnFshLEgj/aGADWCOUgGYSdOkU5cVfuEOiDWkHpRNfJxC/gZANp YNnA== X-Forwarded-Encrypted: i=1; AJvYcCXzt3lZvq5HaBaxsdCknzdGStzyEJ9PqLgkv6MUoPsesw/FiWouJnNtVC+v11Sahgk1+Z3sUhrv9g==@kvack.org X-Gm-Message-State: AOJu0YzlyF8e6/ZWt9bx+NXC/29KWvqpZmyYCSSv730zP3Axvhfphhq0 MC69FEmbARLqw4HxoNubvkcWlQRZAMYgX1BnkaYzE2Lmonn9otAAU3scrQDuPGMOL/UhEav1Xfx g+q4itNPX6kkAFo3fn37w5OTTXymWlA== X-Gm-Gg: ASbGncujXYH8AQTmEZ0ZpGxUZMdYGnefqDzHWj7Zhj342Zh4k4dH2AYC+Lf64NCsTxE Y8XXpVvyTob2QU+qAJWV4s7Zh8008MBQbWKjFzvBWkfzMlkuKji9FxjI8BbnwOkRbwcuVzvFa48 /NV/1DYw+mtv8TOAHlriNSp25tVdwBr1xqW36sB2LZI2DEqPrHxCvhAJmRSySE4KNznHFAsRLqJ HnX X-Google-Smtp-Source: AGHT+IE49QtSZD/cKBZ5BP1yA1DXZJqPWlGny04gQQGYYgaEAFtSE3U5Dq1FLXkagjEVnZI5VV/7Hij8OlK/mpvnwpA= X-Received: by 2002:a17:90b:52c6:b0:305:5f25:59a5 with SMTP id 98e67ed59e1d1-311108a4e7fmr9846167a91.35.1748200765413; Sun, 25 May 2025 12:19:25 -0700 (PDT) MIME-Version: 1.0 References: <20250501163827.2598-1-ujwal.kundur@gmail.com> <20250510160335.1898-1-ujwal.kundur@gmail.com> In-Reply-To: From: Ujwal Kundur Date: Mon, 26 May 2025 00:49:12 +0530 X-Gm-Features: AX0GCFuYwumGBCs4IZFi7ChmVZQtrJenzu_p2fgKD9W_iisr7rslKvFgB_F8ufA Message-ID: Subject: Re: [PATCH v3 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct To: Brendan Jackman Cc: akpm@linux-foundation.org, peterx@redhat.com, shuah@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: AEA4320002 X-Rspamd-Server: rspam09 X-Stat-Signature: 4ayxhe4cfpz3qkz45tnyzndafb8o8qhf X-HE-Tag: 1748200766-778230 X-HE-Meta: U2FsdGVkX18GwWQu5VzlbuHiryqKhPrrHxVUJXWFHdWeFuHpiPt8MoL8taykXJZD4MIZTt+v7WxOP+O4E2sE9yt617KPah9PsJKXko1sBQgeEod3JBaMiGOIp/rlYMnOpzOJcTYIEkCAlmSNICyg7f5x6rMKBYoYFHSseBRuk/abTak74MWKdkmuGnXrvgssL4nSKmQis1Xp1rIiOeVgDQU1qDsMuYuoZtLQD/WNcMdER9cMmL4K2V68fVtGRLXMM3IMRnfCubsSk4xFm2SbmjB831RbDMBznxiuIHkPppDlUQDiO7PkhXjkzlBIfWiHCk9K4Nbpwa3K/NiQEtW+7J0YDHrCNUWBeLn/fGyXw+eS+sBty46+IYlwgyzmyq5fly3r20xTbsRbkIPqBRCxiNDyxi8/WucskYBp3wKJ5sV8ryqSwRMC3xnJx+udaCCdbFkyFowJ3aenQcorMwQk7Hs8NQcFV6hGADG901muiJnDyk4reX9W3J2Ohj5kRAb5l3Fv8euGdmqqp/skehK85l9rU9eRZkGzAOfACNvxFy83usF/KTSzYuvV6s/TK/IjtpbeLmiobYU8tCcg18/4mFhwvs7uiYwzb/7/a/UESeelB8P3oFjOuB/59EZ87o3o39bB2BgZ+y0CGl08/UrGFS8CylLZm3UxnqMcDn+mEyEoUgdpH1FzAZZxdOks9V2CsmDc7GDXqjoPMsFun/IjA/+5n5xxeEdRNffWxSUZXOCYZiUxtBy3SpIzGtMEUNjUz5GUe7jyIz6bZDdn5pNk3feC46T8mLJV2K2YVQZjXHIZhvQbyUiRBG5OzcByo0TgjQ1o/liOa7qnVd/Hx0aW/u1n0BiyvveNEkIv3ZN/kzvJw0ACTvuPVFecgmOH+YpkilsfQe4SyAVSJGb/krpnJhpzihc0TfT5upak42w/PfVsF4Y7OVn9znBuzDUuBQfDv4zgacjM7hWvemSeNZD i/Gw51eR +pqfEiiv0dc0Y9mEmpAZ5l/I+iEojVVDbB4+HDX3dKSbUmxib1GDCTayHDfIHrU79UhwoP6UW/cmQ3GVEPwku1OWZ3ft14Aqh5lCJN6Eii/XwpDdqw5W+mxDhmRIaV11rG7ukQ75AjrDzK2tpVogIR3XZ62sb+77+9L+yXhMrrQlQQc9+kWluxFliL3e0Ukt0yj/+J3csGUgrGnvjTDP8LZ6bKY73XCxeTe3nhwtuiS0nLT+TR09lTKt9xQB51pdJ0pLiRQ+SCztbx5fnHWCnwhBMJ7didIRJnzaX0OpHkwbrm9ulBP9FEZKUGuaslRllHD4DXaKPROj/AUlUpJeHlyF8kjbVkM8MpD6g X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > Sounds like that's your issue - for the kernel, tab is supposed to be > as wide as 8 spaces, not 4. That fixed it, thanks! I've gone through the diff and made sure there are no longer any inconsistent indents. > I'm afraid I'm too ignorant of this code to be able to suggest something > good here. But, can we just remove the comment and plumb the gopts > through to uffd_poll_thread()->uffd_handle_page_fault()->__copy_page()? > > This is not pretty but it lets us remove the global vars which is > clearly a step in the right direction. Perhaps Andrew can weigh in? If I understood this correctly, we're trying to assert that retrying a successful UFFDIO_COPY operation always results in EEXIST. This is being done in a somewhat racy fashion where a flag (test_uffdio_copy_eexist) is set every 10 seconds using alarm(2). IMO this is a flaky test, we should either: - remove this variable and associated logic entirely (preferred) - use a probability function to set this a % of the time instead of every 10 seconds - use an async library that can replace the implementation without the use of global vars