From: Ujwal Kundur <ujwal.kundur@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "David Hildenbrand (Red Hat)" <david@kernel.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Carlos Llamas <cmllamas@google.com>,
Peter Xu <peterx@redhat.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Shuah Khan <shuah@kernel.org>,
Brendan Jackman <jackmanb@google.com>,
kernel-team@android.com, linux-kernel@vger.kernel.org,
stable@vger.kernel.org,
"open list:MEMORY MANAGEMENT - USERFAULTFD" <linux-mm@kvack.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH] selftests/mm: fix division-by-zero in uffd-unit-tests
Date: Mon, 17 Nov 2025 23:01:22 +0530 [thread overview]
Message-ID: <CALkFLLJP7J7fUsUuo2TYseeDd+4JeC8pqJN9PwfhKFS3jd-TFQ@mail.gmail.com> (raw)
In-Reply-To: <20251114143909.14ecee31b88f179bc2858e30@linux-foundation.org>
> Commit 4dfd4bba8578 ("selftests/mm/uffd: refactor non-composite global
> vars into struct") moved some of the operations previously implemented
> in uffd_setup_environment() earlier in the main test loop.
> The calculation of nr_pages, which involves a division by page_size, now
> occurs before checking that default_huge_page_size() returns a non-zero
> This leads to a division-by-zero error on systems with !CONFIG_HUGETLB.
> Fix this by relocating the non-zero page_size check before the nr_pages
> calculation, as it was originally implemented.
Thanks for the fix! I never tested with CONFIG_HUGETLB turned off. We
now need tests for tests :)
Reviewed-by: Ujwal Kundur <ujwal.kundur@gmail.com>
next prev parent reply other threads:[~2025-11-17 17:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 3:46 Carlos Llamas
2025-11-13 9:06 ` David Hildenbrand (Red Hat)
2025-11-13 9:54 ` Lorenzo Stoakes
2025-11-13 15:01 ` Carlos Llamas
2025-11-13 15:03 ` Lorenzo Stoakes
2025-11-13 23:32 ` Andrew Morton
2025-11-14 8:11 ` David Hildenbrand (Red Hat)
2025-11-14 22:39 ` Andrew Morton
2025-11-17 17:31 ` Ujwal Kundur [this message]
2025-11-13 11:42 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALkFLLJP7J7fUsUuo2TYseeDd+4JeC8pqJN9PwfhKFS3jd-TFQ@mail.gmail.com \
--to=ujwal.kundur@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=cmllamas@google.com \
--cc=david@kernel.org \
--cc=jackmanb@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox