From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FB5EC7EE39 for ; Mon, 30 Jun 2025 11:25:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1FD226B0088; Mon, 30 Jun 2025 07:25:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1AE2B6B00AC; Mon, 30 Jun 2025 07:25:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C40B6B00AE; Mon, 30 Jun 2025 07:25:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EDF676B0088 for ; Mon, 30 Jun 2025 07:25:48 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A1ECFB9D85 for ; Mon, 30 Jun 2025 11:25:48 +0000 (UTC) X-FDA: 83611837176.11.F7BFF21 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf13.hostedemail.com (Postfix) with ESMTP id B93E120007 for ; Mon, 30 Jun 2025 11:25:46 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FsPwOkrf; spf=pass (imf13.hostedemail.com: domain of ujwal.kundur@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=ujwal.kundur@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751282746; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K9PQIUz1gn61Y7LljRY3kDMGMzsDdkZNp8ZHbQ5TSJ0=; b=lx1J8imDDBY0UDuv5wa6Z1KkC+DyHq+sB701ZnWXLQ8Z5mCwouYoGSSEx/JxWm9SBo6vpN TUiGUJHgIgXSwSGe1sIHUCHCeFMQWYhY0XMHzc09yU2pnm3qbs06aUZojGEIT73mlPOcgD bB9aCKvupB6LESKS8Gun7UDBJSen0Ow= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FsPwOkrf; spf=pass (imf13.hostedemail.com: domain of ujwal.kundur@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=ujwal.kundur@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751282746; a=rsa-sha256; cv=none; b=Yt3UnCy+QvXQqEezDB7QuJ1wOOCrifcYsxCZBp1cjmFvNXUnwQC5tAN5QfIx7aIGvQhmLD EEDV+atbMr3a/+mdovXx0bHuiDNXmm/zfJugidmFYYUWfb4X8os6EYg4G88iGWFicbC9jF /R4RaBXAtRxv5FfCzQxywBY+HEELJrU= Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-ae3a604b43bso5286166b.0 for ; Mon, 30 Jun 2025 04:25:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751282745; x=1751887545; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=K9PQIUz1gn61Y7LljRY3kDMGMzsDdkZNp8ZHbQ5TSJ0=; b=FsPwOkrfo2iOFP1dp0wEaI+ddLXjXbACYcUQeG6/A4XU2nz1c8/Ma1ZKUajafPztm+ 18IFrfO2w9JnUxyyo1R5YKKrKEKkq14W9n94D7ewrasVU3gP6vVsfTEjTOowWjuTZmCl +JePljcZdaBvToFLwJtzdeOqS4ftY+oAee0lKmNAVlDuprC9B14OGmN94tyq6UqV9vy9 zT6fqTqjZtQl+Dnm0V7ZB8RlZMXCFfuDUxp1FqCJr0LKLHqSXXSP9f3r8z3qUzZ+cr9E qsxyIjrQOXE0FFwiMLXys/r225StEYA2tSdNoowryOWJaj9JmUzkSKiVTZQvh2g4odee KmwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751282745; x=1751887545; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=K9PQIUz1gn61Y7LljRY3kDMGMzsDdkZNp8ZHbQ5TSJ0=; b=Wc+hquhBcH/Nk3ApHoNhYv1hz1OKMfzUEot6e/iwvBcOO1+bTmRxq7T4VeQSgFqOPx Cv9cMKGvIjvCQK4Jg5w2c6g3gRt94+ECpS0ENf/VgipqAMLm16ZpFOuO8rDb2Ha7pOaH x/hDQS6PEHkTegZYCKIrDpgAFmoRo9tfXFmwe31RRf0EvNrcC16bN03iPr6RWuf62aGZ XU2x6ydLxofgz36X1hJPjlRkuhgzWhFvr1ej7u2YJkHui+YJuI+cI3WSAbQVpBMR1fH1 3D2YLvWvcZfcmdegEtdJ3OKtbjazfgRyENp6mTjp/cHE0tBuPu1XZIFSLaPG45pDHj4/ TRJA== X-Forwarded-Encrypted: i=1; AJvYcCUg4v5E+Mca56w+aEGSVN3xNTNmaW3lb/VegM68DNZDYruJdy70dqZVFbUmCxaHo53a3TYLtGvq9g==@kvack.org X-Gm-Message-State: AOJu0YwinEVoLAWZRYT5+D8PcGK17z8eEWWeIyPgbHceEDo5eVjaIGwv U0OKBR+B281G3gbrvHvPYlmXyCB+dID8eDmTEMC6r+223qYQKAwb4mev9VIXJ81E4AX/UCTLw7o o1FVksWtXV2jZDAw1waCxBoMqI5Dk6w== X-Gm-Gg: ASbGncvSYOZbxRMyfj1YBUnYwLGmX5xS/oklgN2nxRrCbQlH0aGt3azW/0ZRYseaP2j +yiuoXNRQKgplbk8AuhE2aARmfQC/RdY5Np5zJ+gsj3QFgM23yt+27wFWdh6gVoj5G/qBjWs3aT F+DNR9DJDzKN7QG+TdsgWpDgxNIy3/QzyfpIUZvKr94dA= X-Google-Smtp-Source: AGHT+IFlXd9TXmbgPHTA8gAIX494c7LaBmUhpPKwIlDuYwjBU0pVnyw3tgKc4C0UD+q3aEMZ5y52BjfVcoqCXZMVoHo= X-Received: by 2002:a17:907:9d19:b0:ae3:56af:5a78 with SMTP id a640c23a62f3a-ae356af5c57mr992092566b.41.1751282744846; Mon, 30 Jun 2025 04:25:44 -0700 (PDT) MIME-Version: 1.0 References: <20250501163827.2598-1-ujwal.kundur@gmail.com> <20250616100406.2853-1-ujwal.kundur@gmail.com> <20250616172618.0609127a8b1e406d4c228d24@linux-foundation.org> In-Reply-To: From: Ujwal Kundur Date: Mon, 30 Jun 2025 16:55:32 +0530 X-Gm-Features: Ac12FXyAuAC3GXUH-C2j9o7z64av1Pj-08W1BtLlY7PXo7lq7AVWZO3NYnnnHZg Message-ID: Subject: Re: [PATCH v5 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct To: Peter Xu Cc: Brendan Jackman , Andrew Morton , shuah@kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 4km8ycznibnqycxdra5gkx3fe6ibzs8g X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B93E120007 X-Rspam-User: X-HE-Tag: 1751282746-783647 X-HE-Meta: U2FsdGVkX18twQKNb8LYRgX1bu6XCLtMfSAk1UFPnnh++OK76qIkEdEr56btZzbM27lz6sSg/qtDKjjTHFE4vGX8qTrzZYmFHYS38BCNXRc4WmlK4xERXg0rFGSKhM0M3W9kDSZYHhq79HIHW8BhWKYkKR1XD9/cxZBlzlI8fQT+Ml06YMk99FFUq/y8lWXMBU1x5B1NsFMvcmElc6aIybdSR4ZMxFnndZ9u9E0ikKePGiJHt8GlahH+1RGS/OFTmdh2pT8EaBU/dwaqET2DEvjh6QAgKREme9MYA/h+81KpZIuKrkNwvr+bP/I7fVtwpOTZIHj28Keln7KdWXEeHzXH9eLctaCvDr3z46JibQTHfmLhrU9xNne78bXQed/eYQwiGQ//ITgZppD4iQ1sBUpoXmgOD8dyvDKfN/jjg9Q08FtBO5zThzeAfwkgcf52k5MyopClfmeeGQSrGOnZ7a8Hbbv+WQ/JMQ524Ii0Ya/pNVarQwH0Sq8S1ut2F4cWX+ot03UCEIBu37gNH3vR3W/D6D3FPzsjBvK/p5JmBwx+tMPjbvfExgNUmMtQjmlPZOhru3Ff5I9MocGjyFLzbLhiwDaO08EIpR8QFVZtjadxQ4qv5gnYsx26qg/mWXA9CvlQsEAGx/a0Ga0KbvJdLKLOdr/gzNRQrsQQPLV6eajP3UFdh3wKtX9NK1B6o2yK5SxJ7t8uepz8WksBQrUy+60IY2MMtdYR36pO9YNHMmsC1+DAfb7opXowEOV5Hlm8VWSBd70yIuYvxpx3dmTJnHtU2wqbK6SZFaPbFYIlIYjSQEu6H7UO3TGuNHW/1GwbhFxizSfn9hrmdZmh3noRT8YkgH6ixOPcd1YXKWk4DUh1buweqWrKedRyEjOQ8qoWDzqVkx23QQsBv+W/h2lZS+4McPmkV6mHSAROB410SAYyYvxYdsvPjuMuV+eGBYvseHfi2KhiHcEA+6KfTls r7kEIFzU OA0OLsz27m0fYYzskhDnmA5hR/ikUjM7avT5NgsreahRAGr+ORwXKqk9l8caKF3JAlQwKr8Q11xTYE0/mdPFP6cEl3pYBFvL8kNfuiqRQV0niXgF3fHutHTxVPJeq1q/DznScl0J2Fe64asDxacK1q/oOShGhO3cuuJz8AtDvuIlVvDcrmtTfUaobiN/41PXG+L9tx4TEsu+muqLEToXrDS+KOqenkaIhXP2oP6st2FYCXqgKfSIOKPkMqeweYt7ndBIuJ/vYF+S1l7jwc0lRHjXNI1aXspZhOtgfa16DChJfl5t/JNM8+Fa+KwrDVNLDI560GH0yX3zuukDMgSUYO0NYck+UjyeFXKolSmIPvBt+GwqTYcldd5L1vW3LIxA1CmMKjIVAJ5vYTvnphR6Q0IRHg5JBj3YckbjTIIZTXIuq2iGUnQ6h2hZqkLIrNFEgPibVbyJ6eMecSUnTwi7wQSOc1UfsW4diJWyZyZFKU7ei0jOFyajejnbxtBlSifeAV4DPjlSCVZgTTSkj7By2lWeyzgpXDSU0U8fD1ODk38mD8wRI3WR2gXIE4g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > The script I mentioned in that other mail should help with this: > > https://github.com/bjackman/linux/blob/github-base/.github/scripts/run_local.sh > > That's my hacky attempt at a "hermetic" runner for these tests, it > ought to let you get the exact Kconfig, userspace, and QEMU command > that I used when I hit the issue. > > The GitHub workflow definition shows how to get its dependencies > installed on a Debian-alike: > > https://github.com/bjackman/linux/blob/github-base/.github/workflows/test.yaml Thanks for sharing this, I was able to reproduce and fix the problem. Turns out char *area_src_alias, area_dst_alias, area_remap were left uninitialized in uffd_test_ctx_init while it was working before this refactor because of the global nature of these variables. Using virtme-ng also helps me ensure that the next spin on this patch will work :) > Ideally the test changes > should run the same before/after that series applied. Meanwhile, no > conflict expected between the two, hence no worry on the order to land. Sorry, I meant to link the uffd_poison_test changes [1], I've rebased on top of those changes. Will send a v6 soon. [1] https://lore.kernel.org/all/20250620150058.1729489-1-peterx@redhat.com/ Thanks, Ujwal