From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C375C369C2 for ; Sat, 3 May 2025 18:16:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F0D7F6B0088; Sat, 3 May 2025 14:16:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EBD856B0089; Sat, 3 May 2025 14:16:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D850C6B008A; Sat, 3 May 2025 14:16:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BA0D36B0088 for ; Sat, 3 May 2025 14:16:42 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 07EA11A0816 for ; Sat, 3 May 2025 18:16:43 +0000 (UTC) X-FDA: 83402402286.22.D6F14D1 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by imf17.hostedemail.com (Postfix) with ESMTP id 2EA2C40004 for ; Sat, 3 May 2025 18:16:41 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QmNVb6Bh; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of ujwal.kundur@gmail.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=ujwal.kundur@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746296201; a=rsa-sha256; cv=none; b=fE7LsMt826PF7TIP7pqOF2G49DM4TBzozaNoDoaV5jfPon0zZHY1RzkleEFXIJjzvHoNn+ Vl+HJpYTyLqZx7X7zy6addOP4YiRVG1AM9pXGuuiQwnUqEvo3x4AweLozpFW0k1zgx46Ib GblEAuONfTOtteBr/Fl2Bg8wZmf3zd0= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QmNVb6Bh; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of ujwal.kundur@gmail.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=ujwal.kundur@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746296201; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VtHQlaNPowPrjenRttkbRhF1+Y7CRiRxicklRpQMALM=; b=WYqHsXstE4Fiqvk8NhepcDAZog/emPfEW3y31zP4S+RrtOmg8h+0BxqTG12hf8dkasCWJI eBsweSX14Zx7Fm8Z/fdv+GwA1rvIqY9hF+sGPXzitnvmf6p7bz2ce1aHRdabFq1XscmUWj ANzy9SeY0dKSZ/TvOn8tS7CRqn6Eaf0= Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-2ff64550991so2433262a91.0 for ; Sat, 03 May 2025 11:16:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746296200; x=1746901000; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VtHQlaNPowPrjenRttkbRhF1+Y7CRiRxicklRpQMALM=; b=QmNVb6BhCSedyiziK98aL51mK9kNCNc7yvcFt6PyflmDJJ+SjW2ytBgo0OpPPuzyil u9vLbJvgTt5UOhbIDF7+ZEZys3EfKGpNZX5bRnG/1fvbtpAe2KRzLPH4z51OBuJV39Jx 5SKOJn6Tc/tmfTsds1G+IAlLP2Bi9XbMAn7GpfNe/CVe4rDCPKa3NesROYvQribqEykA nLi9Jy6IV2StETL1MjVbBL+gRaBRxGXyaddI2VilrsoclJ+G2ihkRNs0/xTd42yWOVj0 KWgJFsDZItPPHL6FoEuGNrupdfTJXANg7xHsEaNXTZF4S43cWODHC7cZjE3akfQu4ocF 5p1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746296200; x=1746901000; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VtHQlaNPowPrjenRttkbRhF1+Y7CRiRxicklRpQMALM=; b=lV//6MsiR+RkfU7xp7W96+75YY1F7eu0sTADxk0pg2iY3gh+PC4EKjvQbFRlr1E3j7 HeCj0Xt9cGG9X1af58c1mX+DrPuxJyHgVLkjV8/8MLQp6w+38jUc30jsJKuoWIX+gdED bs/S4Lxnl2m3Uqh0LKfK7ScVOPCffn/8nXmeqBYli2qhrp+7Wi5ermPquqO4nPHUDoE/ hqhIoHxOmuxrWX22oqV9ccs1AFXZDt/OV/9OZsEPdjYC71XajVU2aEBxRNUKcieZ15yE zavZJj+DEDaBr8GZDnrLHi5aKwR/YOcDlUz1nTIF5Q6GasKkGbx8EX+RvZUW3u6QdQxO aZpw== X-Forwarded-Encrypted: i=1; AJvYcCVuzJAM8x7hq8L3FzeuPge+cQQXS7BRWBUNl/+014tJ4qt5HkDY72TxSw3krnQHbF8p/SQ55DPq+w==@kvack.org X-Gm-Message-State: AOJu0YyATTH2MGG8VdK6W8+LzTRm54vBFp2GmD4/z6ZLkXQdRAEz6VyW jKTIKyIjGFNjq0x3+/1o+Yn8nwiauFulRlTD6GmaLk2UYwXfJeGEcdQhBOTbS6uZQRVB7MJMBwB H3+Z7GtD35BtrZITD+K24f5ACkCpQnPQF4d59 X-Gm-Gg: ASbGncvj3gyhnj7i9ZliUAQJozOpuNLFs3lWWp5pDw1t9h/dg6ovpB3SoRSoVvtEgop uTpkD9fAxFogRjte8za1zozU32DQFCm6zQBUaBtNiE521tX6NYPZKW4yYWNMVelM2L3Oh1cwdGf swLcXxUrjS7aOmqFOCBJuBWA== X-Google-Smtp-Source: AGHT+IHKsbCVi7HNnXXdlqdZjUr5DzRbIPrcHgFYMd4daXYxhrfynkAGlvyPIpnO+hHOAELtmlLVU9ygkbTMS+eyNcA= X-Received: by 2002:a17:90b:1f84:b0:2ff:62f8:9a12 with SMTP id 98e67ed59e1d1-30a61a2be01mr1983770a91.23.1746296199869; Sat, 03 May 2025 11:16:39 -0700 (PDT) MIME-Version: 1.0 References: <20250501163827.2598-1-ujwal.kundur@gmail.com> <20250501163827.2598-2-ujwal.kundur@gmail.com> In-Reply-To: From: Ujwal Kundur Date: Sat, 3 May 2025 23:46:26 +0530 X-Gm-Features: ATxdqUEF5U0na-NaAHmxH75iMW2eHSbW97C7umQp2QWaCy32V1BUA1KDKLjKI0w Message-ID: Subject: Re: [PATCH 1/4] selftests/mm/uffd: Refactor non-composite global vars into struct To: Brendan Jackman Cc: akpm@linux-foundation.org, peterx@redhat.com, shuah@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 2EA2C40004 X-Stat-Signature: stheqmkbbby64snqaas3ydtcdi8mss17 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1746296201-704419 X-HE-Meta: U2FsdGVkX18FGBL1xVj9V5rMS/lBfB8YKWti2nT9fx+CNR/H10RNe78AGyS8jX75ifq56SjTTGxGXsdIiaVn+mSsOa2jcCL9f7UhZe1MPjA0QZd9GCgrtFA9MpBuWaHvWAq5AwvF6yxuXZOsQHYvEPZht3BDqFIGMz/jVkev/vsEna0/9I9fmxC7pE6QPi9vs5uY/s2kR6g34hdXZIp9b9K6QrTcAHcov+DHKAsG5afx2KYG2z0MfXPrZUSFzWHYqlrfnL8jPj2rZCHIn0aUon0KURQFitCUeq1I8qaIO5ippsgmzW8Ue6ZXLP1uE2Iv716QvunB+9oGGPzehjpXEwYpr9byYN5XRwY32IGbMWX5PoXtFZJgyoiFuPxQvozTAsub4FPp5AaFhn7iL92oIaYEBILvbRmtn/WXEAWV04IMEy3B9M+oNB+T9JQb4QYdfzf+SO4trtiba31F2GT9PfU/Z4GcZh2UPvyyLL4jy305IrH5C0FlVz7LWq7afqzDf3d4ivQvByptQCnqpnNiwMT0Ljl/C4sElLeyu5oMSaPuB50TOSnuJr/gd8RWBcFeok59X5ZCHT7lDABXoDzD2nPaBB2ObDFTZHhxVHHiwLdYCzAsEZ41szKIfDoCsIyufg3Zm+8L2weL4RBt07ZqC4lHhdVBBQyzohQduV9nUUWFmOGv2WE6YjY5AIxIHFXwLiHMIW8Xlfd5vS77U52y9vBtpU+7RfP1KmXzVRZzW9Y3+1ilyklmx4tS4VakhoQkTDWfPiVV7H3smArY7FNLfJk13HR2mQXHJkjwd3RnTqk4qZYHa/y4wY5ZcHnSEoD+m6swxkMSvibU944zHKyQUKreMFwVZWt0E932+R9HDnAnl7JvkiBxo+EvnBHr7+hFT7ZBLaPm3B6H5J1myicK97tDeUIE1QNWE2wmzpQMFUJlMUwxNJjYeqMoyALsN2ZY+33kTeVJFoiZqU3RLvN MqkzWGxl dcY5WNNvGP72bjOp/3ANmSXArUIAA4ZLKQTgcPVN9lyQ6LCedbgq0qcy+ew+vLCAUQ/JgXlAKZeMa93OPTgdzwKoRpyu+/T+ioB3I5MRIG2+OjYPdS3Ff1qcFdVnkLPtnvijrdfn1GcqZobS260swTyZP6Xg3vXVarTfip1iMZQJgjCoKkHHWja0HkcQ833ROFyyKDMmxvMetGGUQD5YywwRPPKuORh7/zAvTvqwdlaYRlkoekPWMjk2aON7Lv2qWtNlQkhgRRg7dkxwDjOqIxiicNzvFJBp/PLw3j6bSuVKuyYuB/UgCgPLCkKhlfNWXjaQiehoM/Y1vkcG9AaUHlBrlKCAkf0eEYiNN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Thanks for the review and testing! I'll push a V2 with the indentation fixes soon. > this deletes the global vars before it deletes > the references to them. That's gonna be a real pain for bisections, > please can you restructure the series to prevent intervening build > failures? > (i.e. if I apply just 1/4, the selftests don't compile). Could you help me understand this better? The selftests don't compile either way if both 1 and 2/3/4 aren't applied at the same time. --- Ujwal.