From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81456C02182 for ; Thu, 23 Jan 2025 17:11:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A83C6B00A0; Thu, 23 Jan 2025 12:11:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 058276B00A1; Thu, 23 Jan 2025 12:11:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E615B280004; Thu, 23 Jan 2025 12:11:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C78906B00A0 for ; Thu, 23 Jan 2025 12:11:28 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4E9211A0229 for ; Thu, 23 Jan 2025 17:11:28 +0000 (UTC) X-FDA: 83039357856.24.05BF084 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf17.hostedemail.com (Postfix) with ESMTP id 57CCF4001D for ; Thu, 23 Jan 2025 17:11:26 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=3ZJnDPGh; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of vny@google.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=vny@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737652286; a=rsa-sha256; cv=none; b=W+mfaqSeBVUq+esX97TFrIlQ+GCkKZoa7x73NmbprwWkanpxYwtVa/MMd9ppeoVGXyE2j/ eBxQwel9morPPb9oDZjbDdyFJuQzN3+zg2689O1Z3QNtLiH+DiEGpzinSkvpaDWSibfA34 TZupVOIJVSmyG3PBgXl2hAw2HgW2xN8= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=3ZJnDPGh; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of vny@google.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=vny@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737652286; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jlS4DCgmEnpTcNfsOfe4eFvqlG7q/TLka/7MalqeqoU=; b=8cmLnMe/vlGw7zHe6mA6edQD+NHclhVjOCjgThHQ3g0vdTqDODskAEUTbZ6BOMztJzlHkf S0GWCHca/CODedWdtlgSsLaUfDt3Qif4BnZJavHpVXOo5o0qWGt8aV0ZB+GaKCFawf0+TG IWJ36DyyfZYnFoaugK39U4jLoFbdv4g= Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-2eec9b3a1bbso1819888a91.3 for ; Thu, 23 Jan 2025 09:11:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1737652285; x=1738257085; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jlS4DCgmEnpTcNfsOfe4eFvqlG7q/TLka/7MalqeqoU=; b=3ZJnDPGhvhQawNUqVgMAUu3w8OjLggT17DOAz7QHQYsIpOba+ia5gv+6VzulSP+XGe fQHewoz9v62ovfUDznmELUprlc+7jgQ2J1Y0Fow89jcMFpNkmg/CrBCyrQB4mo0y8VYV nuABDu0cXVXkZYf486n2VhbOKFgWdoHlf6SbXjiFRAhxAXYIODvvigHw38SR2i1KUDMe 5xM+LNgzewjOrbJVyEKWDSBwQ4ZIGle4KdcXoIYqo70LiiTd6YNqRNWwR0EJJIXVIY/h vPt7h/fu8KDcQsm7MrSID47I3gCTfZDFLfyJEbSlzkZdm9z437l3romSBsURh1DAioD9 u9dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737652285; x=1738257085; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jlS4DCgmEnpTcNfsOfe4eFvqlG7q/TLka/7MalqeqoU=; b=rT4JNDVeok7gJ3aDQSZF89F+vMtaCriqkbj+Ve8ern11f6CA6GRKE3uZD3O3rmmiUJ 3Kfg04pUlsXprzw1X4javpgWCnrSA5nI4cCi4bQ+Bset+Qfg/WIwHX9GbguoNJQYlKsJ GaYGe5T6q+G8D4eboSYUw5cWyAlbf5eTUlUPFTXEJ1y7GV0QkXaYKw2BQsQ0rrkZAbDh tuO/F8czMwGlcAvcpP86UwGW43+G72irhhxcTNrGkpkPoXaHG0Jmhx0MlNb0BLcduUxr cwnGdAoiQv/mPVchVEUeNAnNQGMve6CH4j9EHJOuhd/eRxDGlzUpkW/T/uelo+NRQgSZ 5K8w== X-Forwarded-Encrypted: i=1; AJvYcCXV8OEIVVN6De2dah5GgxVcbJ5Dhfb13jjYPqrPTnaQR/1MfAmZy5Vvln1v7nSSbY8qcDgHk6JX4w==@kvack.org X-Gm-Message-State: AOJu0YyD43IXQqHHP1CLGKFTABV1Y9PA3TjIFomprm+03aAlJXA1yxDY x3EXp2nJvYx+cPhH0UQW/OJNm6MIeOkPQH2e46ZOVrwHblYYIvfVu3vlx8df706Gy+iDm6ADdvy fgvTsircSxToY42ddCCAToVzg1ubibNib4t6T X-Gm-Gg: ASbGnct3bh8u3FUJzPpDbMjv2ZV8FpAmHjyc7PeU8PZRxaVM2kXO2/Qs4W18lbZRWxr 95hbNPbmiQ1ngkb1Bsy8RDkuU4XRVVYkD/1H5TNOBRUorgwBS4FJoyT9eHA== X-Google-Smtp-Source: AGHT+IGu2zzgvQ4Cr4ovBCd2XzPYyoeVReODbXfTDnHbq4KDUZ0eJ9P/pquPuvuKzcfbwNCkpqbY448Qso1rGukOJA8= X-Received: by 2002:a17:90b:17d0:b0:2ee:e518:c1d8 with SMTP id 98e67ed59e1d1-2f782d972b9mr40503386a91.30.1737652284844; Thu, 23 Jan 2025 09:11:24 -0800 (PST) MIME-Version: 1.0 References: <20250122200545.43513-1-sj@kernel.org> In-Reply-To: <20250122200545.43513-1-sj@kernel.org> From: Vinay Banakar Date: Thu, 23 Jan 2025 11:11:13 -0600 X-Gm-Features: AWEUYZnslK16iLpNRC5BEqCbKspk04SKj5kDOJo4JaCGog9ghvQqfmpK_QoLpik Message-ID: Subject: Re: [PATCH] mm: Optimize TLB flushes during page reclaim To: SeongJae Park Cc: Bharata B Rao , linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, willy@infradead.org, mgorman@suse.de, Wei Xu , Greg Thelen Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: 57CCF4001D X-Rspamd-Server: rspam10 X-Stat-Signature: 3w5smgqxmorqf8mer64c79i17ceadgrz X-HE-Tag: 1737652286-559996 X-HE-Meta: U2FsdGVkX1+JI+bLpaqDFD0kvdzjNuYbi2KC5X84rTVpzsixYC/IaafVQS9DvrUifAgNIXN8BZxA3WwlZW1YbC2WhwAEi90UjeWYVSnd7vYIQvd6P1rxVK1DU/uzw7Un1QegU0A8LkF4S5W6nheZx55sFz5X0v+2sVIxofT6D0OqigH9msgqeuw4eP2N6NJoNSl0nooAklN6OmT7v6yFfFfo3gLv40q7hQLH7wfya0te6rO1oGcr9wISV+rPxGTd4ECydM4cetoLhucRDNuzcq00P6gatqLm5vIHcCkUpVxZ5Vp0dwdJJ2vLucm0RRHAYKOFNWAqgC2BQi9LMT+Xt70OlG4nKN2AbqBpcNEGUbR7iwY7mdOYozyJixSctU/P7Rq/MgUDShRCxxkIKMY0B6I4pGjTh1DjfulHTGDihUQ2hSVPOidtoc08oy3dHAGik9Xt7s/mYLbxPPnvtbelmbYcZMIqhURoPn3Xwib+1WuQ8x4LwThbJ54t2RaDT6u+6ENtym1gOO3e2q1yEp9GGtrHUHfb6GfrsDn9ldadI2XgI32PUKCG/xAQ+qnqkOExKzV3RFQKKiD5dEMw4OKlQspdL/WoZSHavteLGRsDCNWi6E/XZlaYdbrFj6IqGtNps11PLpTKJjoLDW+RyVZAmZMTCaHO1PXUok2eGbOdYZyCBBK5G34iHL8BYdXspcjdi/AesKlL+GKnIgpyX0MyFwCcZBPSCZy6aQFSRq+6YCmG0OGA+SXYbL4/b0WTICtrEVvhOUHO6JXBkLP+vQlLl7/C6ilBqxxGK9jrgT5RuyKHaC14jtgNFSqzd8pvmmoNqRBrlJbSLYH7PodMWwcbFIGlIO31Dljle0hF9+FzuG4XO4t0aJWotXI3BU+HPOfw3GudpKCJs/dRZAjktnExDD409Zdt3fcoWGNrqRxa/kzVsLYAjUAJ4O+v/gu9XqDi2l7BsXE1cePS92FUELm weGzGbbs WqgH7n0MnZWxlF5MR7BRuLNDf7Bbybcg26AtlwCBZg8trAkMNbCDWJNZjYxUHDE2Fobsxc5n2VkQiQT+kzVxj0qsyeFjwJhDdw+qGTcNnJZLT2xyBV+IZqp2oGl924fHXOqwGhrg8hZKLTa3ughaS0HDXqsZ1DVMNZL/fv5ZbzNAapMfu6r5KBDSt5RuzSSwFPvdK7FBFZ5R27qG7V89zWHcvfYJ0XhSHbOFH X-Bogosity: Ham, tests=bogofilter, spamicity=0.028404, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 22, 2025 at 2:05 PM SeongJae Park wrote: > damon_pa_pageout() from mm/damon/paddr.c also calls shrink_folio_list() similar > to madvise.c, but it doesn't aware such batching behavior. Have you checked > that path? Thanks for catching this path. In damon_pa_pageout(), shrink_folio_list() processes all pages from a single NUMA node that were collected (filtered) from a single DAMON region (r->ar.start to r->ar.end). This means it could be processing anywhere from 1 page up to ULONG_MAX pages from a single node at once. With the patch, we'll send a single IPI for TLB flush for the entire region, reducing IPIs by a factor equal to the number of pages being reclaimed by DAMON at once (decided by damon_reclaim_quota). My only concern here would be the overhead of maintaining the temporary pageout_list for batching. However, during BIO submission, the patch checks if the folio was reactivated, so submitting to BIO in bulk should be safe. Another option would be to modify shrink_folio_list() to force batch flushes for up to N pages (512) at a time, rather than relying on callers to do the batching via folio_list. Thanks! Vinay