From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B146C02182 for ; Wed, 22 Jan 2025 13:29:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 020EE280002; Wed, 22 Jan 2025 08:29:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F11EF280001; Wed, 22 Jan 2025 08:29:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E012D280002; Wed, 22 Jan 2025 08:29:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C1B9C280001 for ; Wed, 22 Jan 2025 08:29:11 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6A48E1416DF for ; Wed, 22 Jan 2025 13:29:11 +0000 (UTC) X-FDA: 83035168902.26.87E1B2F Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf06.hostedemail.com (Postfix) with ESMTP id 8079718001E for ; Wed, 22 Jan 2025 13:29:09 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=fKWpYq+O; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of vny@google.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=vny@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737552549; a=rsa-sha256; cv=none; b=GgFEzhozxxmGf922RiLTxrSvo6SS+JfutENM2CGv1XdE8J5nqlbVliVlJAtPJUIDjGmOkX p9o7D74vSI+Vf6EcfArtm/zBqOxRB8+TGnoI63Pr8TBOp0EW2prZCTcyvLp+EWqR19J6V1 cwF8pMJtPxqqYdbxhKHOKyrmi4d/Tno= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=fKWpYq+O; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of vny@google.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=vny@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737552549; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ufoBoBNq4WQ0MJ9gBEQYlxJhuL9Fowga7Dy2J9VLQyo=; b=PaFD7SnFo4PQZKbua1ED5YmS5DI8lefSNTv8jPZ4FHZyMdo3WVcME7PnGP9EW00hdX/vaW j9DPPceVl9gNolU2iiQWUDJ6beEnzLcZOP1lwn2UDX+RdBemqdZsA3Og5d6bRKJFxrwnnZ 4xV7Csy78ePckHtTG2oiNphh1GwvCLU= Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-2efb17478adso11886235a91.1 for ; Wed, 22 Jan 2025 05:29:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1737552548; x=1738157348; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ufoBoBNq4WQ0MJ9gBEQYlxJhuL9Fowga7Dy2J9VLQyo=; b=fKWpYq+O6auXZnPAmt1f64O6wlzZ+q6GaC7Zrtm+oV5Vs2JE+/PXw0sqt0KRICuuCq /3/ID5KvpZbbYbkzQfB354zeV0BlzYFXyDj0Mtcgp1VnxBRxv2JR0TQx4yl4W/L1KSQk hdvOFSL+XQQu08DH6A7HASxzmlbLNkYkgiOQWe27hCzezU2JziAUk7wQ/HuVNurFoFoM jTrE2K6Yi9RtlEzjsuDbPqYOSFxeS/8uzNlaCRlqRlPpIsedDrX6hOnts4MNlhMaVkhk feAisy0mBAtXejxDX4lrLOlufrAM4rW3ow/UFrh9oWnNt2YGGXQADVjml+qxwC/MbnRj Jgcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737552548; x=1738157348; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ufoBoBNq4WQ0MJ9gBEQYlxJhuL9Fowga7Dy2J9VLQyo=; b=WN6w3wbbq3nA8403atZenGHUsCZdObiKTV15VoPMUqP0pzSTJs4SyehD86Gjr8n3+o 5E8KI3dGVMvu0h35UENHp1MvofX6IeV7z8gAmvWdWjbaDXMonBHwSwB5dwCqIsMaa/N/ lSVYUGwcB/6RnqTrwSrFlfOXCtsfaI2h2YzuZx6BWijthtfRh7xO/5Uu2uHP3eak7NuR ioiIvWAnaZmhkbcaV8lFMWJ+V7Th7FUBQRdLXadYMv5a0k77A+trhdRkUFiNdctQDkvb 95kWEYEe7UeFSN38Tji9yd+nBuDoDlR1vDsuov0g5/Nw6uAsNQCAg6HLK5L5tYwnilKD VNHQ== X-Gm-Message-State: AOJu0YzcNIap5YCXBdnSvvqx1VShO6V5E/YWRPNNaszAYS4BU+xX+1yA EuWo6iTLf177ikCtsWn1rpSohtMtS2m4bjJ5kQFEAHjrsN1QJ2I8dOLtQKl2Kq+RPWJxhc/NR2W eaF9RydJQcwKstFs+b0EpmPmb17SwV69lbk9z X-Gm-Gg: ASbGncsI1+0Mj70A0rY2O2sE4DFZ+E36Aqs9Loy9w/Qw+zPuYHwH52/v4L8dQKUkxFC vWjqZWCCNaXpx1ge/cBgSlXI112FOcIHQoOZoh1e8fse7IxFi38w= X-Google-Smtp-Source: AGHT+IElpMDfPcTuMJWuqBnROnA3F+tDpGqY8R/z7WdUAkwFTnjfdp9uqN+44samffJOxz4IMCAOenn9jFfPkNOMQ9k= X-Received: by 2002:a17:90a:d60f:b0:2ef:31a9:95af with SMTP id 98e67ed59e1d1-2f782d32956mr30990554a91.27.1737552548029; Wed, 22 Jan 2025 05:29:08 -0800 (PST) MIME-Version: 1.0 References: <9e0fc33a-2e2b-4366-ae1b-231038dfd2be@amd.com> <96e992ac-2213-46f6-ad82-e84dd07ce892@amd.com> In-Reply-To: <96e992ac-2213-46f6-ad82-e84dd07ce892@amd.com> From: Vinay Banakar Date: Wed, 22 Jan 2025 07:28:56 -0600 X-Gm-Features: AWEUYZkxfbCS3HcjLkJXu45-0zX23nq5j9Rc-qo7f4AH5bRddyjNRUH48poR7Rw Message-ID: Subject: Re: [PATCH] mm: Optimize TLB flushes during page reclaim To: Bharata B Rao Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, willy@infradead.org, mgorman@suse.de, Wei Xu , Greg Thelen Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8079718001E X-Stat-Signature: efjy7147a4b7oi7psy7u8dun4nz5wpok X-Rspam-User: X-HE-Tag: 1737552549-217873 X-HE-Meta: U2FsdGVkX19BZmHOUloc+G1HyrzpnCS3R8w7zMfJN7ol8zm5FcEy3o+pJKOf3c5jN+kmpwAOVXIGnjWuyBZcTh5FdjiTK6JyzU5sevJKwinRhp0Dntr/86Um4rYl55Io4nzyEohP3Q3/512nO1cW4zolrLh2Z6EhFVudw7y0mLkPiMIaxuqOOCQvNn/zk5dlv9NY1eBdQ+zTiw5AVNzmqhuCXd4leciQ8gEHZzMqrKNblc51k/s9bNp+z6cdpHLQvDuyGFzNEVpZWUp2HqopEsAnQhaQkwFJjFmBUzL9iw97pYY5bDdrhETKPkl4AmX2QRnfRqhvABKkDHn83AwRWRK2dYqzEj4+vHTVthokRU2K7xmay6cZZOxEn0OOG9zBphB81x58OcG9wYfreBpjGosaQmXqPC5PBReJ8CU44UK6pX+Z4ShMqZJw78CEf3tpN2nIBZXmYGKi321gzRM5my2hNl8o0EEm2QgIkYZR6s61Ai98hRclgY8oboWowhDkabdy/VRLGOSbs5S9iHG8Y7N0azLOjCq70Wlsp8nRS0GRHLglVIsAvJ+DCF4s1bnwoNiQcMcX2QgLilg48ObzvJj8K8uDWiSwVrVXTN7mcIrPBbni0awBOxQxdutoD9X9wSc9X5WlE8hx/8A8Tap46D0/2FDIUrAmLemJX91t09g/ofKX4cRWhvVypQylM6AOmRw5Y7kdUdcwKf7ODf8EmBFXD2YHoSwtbmC5dFDs/s4gUK2OSBQRTaDOySP4a1IbdIi0lsAyIj1+1epLDEJf2y+HNdspi54hrbWVCAb5xb6UgoN3YtXFX943NpmTJ1wUCFCtDSG0qyWTDw7eZPS4IIMSh3hgRjtjFhnqIGmO6JFb5Svq77xNegDy8ztr/UJ1RtX9GQ9cYMcP0IgrzNqtvcNPDCQB8KPl9m8JnHaeJDK9+S5YLujM8lKVRqS9k+noNY6aqp6wxRIjL58yWXb LzkrwIgc ToT3EkuayRQlNDnWmYMXzFtjGXUw0L4yzuggDd9VairEEFP49qhrAvqwMa+X/ZvdYuLAmPPQccMu2IlZ/YU2OMvKc/2YKl6iFT3vd6hhApfwG5i+UUVwtEXrIdJQbYZS6uEnbCwShxE77F/5+e6u2ECBK1j0mbPhMqgwaT1FtEpgEH1a75jYXd7FC4jl0AuYnfEDzSKA73hG3Q8MGWBAmXg5IptuJEFo/GlsI9wroP8EAQIgorbVtK7wF6Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 22, 2025 at 2:59 AM Bharata B Rao wrote: > While that may be true for MADV_PAGEOUT path, does the same assumption > hold good for other paths from which shrink_folio_list() gets called? shrink_folio_list() is called by three other functions, each with different batching behavior: - reclaim_clean_pages_from_list(): Doesn't do PMD batching but only processes clean pages, so it won't take the path affected by this patch. This is called from the contiguous memory allocator (cma_alloc#alloc_contig_range) - shrink_inactive_list(): Reclaims inactive pages at SWAP_CLUSTER_MAX (default 32) at a time. With this patch, we will reduce IPIs for TLB flushes by a factor of 32 in kswapd - evict_folios(): In the MGLRU case, the number of pages shrink_folio_list() processes can vary between 64 (MIN_LRU_BATCH) and 4096 (MAX_LRU_BATCH). The reduction in IPIs will vary accordingly Thanks! Vinay