From: Su Hua <suhua.tanke@gmail.com>
To: rppt@kernel.org, akpm@linux-foundation.org
Cc: muchun.song@linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, suhua <suhua1@kingsoft.com>
Subject: Re: [PATCH v1] memblock: Initialized the memory of memblock.reserve to the MIGRATE_MOVABL
Date: Fri, 27 Sep 2024 16:28:07 +0800 [thread overview]
Message-ID: <CALe3CaBNEb4Qh-9abTuefPxnuPzwTwR6k8HC+uSPOTKX01hwAw@mail.gmail.com> (raw)
In-Reply-To: <20240925110235.3157-1-suhua1@kingsoft.com>
[-- Attachment #1: Type: text/plain, Size: 4576 bytes --]
The main purpose of this patch is to unify the migration type settings for
memblock.reserve to MIGRATE_MOVABL, both with and without
CONFIG_DEFERRED_STRUCT_PAGE_INIT.
Thanks
suhua
suhua <suhua.tanke@gmail.com> 于2024年9月25日周三 19:02写道:
> After sparse_init function requests memory for struct page in memblock and
> adds it to memblock.reserved, this memory area is present in both
> memblock.memory and memblock.reserved.
>
> When CONFIG_DEFERRED_STRUCT_PAGE_INIT is not set. The memmap_init function
> is called during the initialization of the free area of the zone, this
> function calls for_each_mem_pfn_range to initialize all memblock.memory,
> excluding memory that is also placed in memblock.reserved, such as the
> struct page metadata that describes the page, 1TB memory is about 16GB,
> and generally this part of reserved memory occupies more than 90% of the
> total reserved memory of the system. So all memory in memblock.memory is
> set to MIGRATE_MOVABLE according to the alignment of pageblock_nr_pages.
> For example, if hugetlb_optimize_vmemmap=1, huge pages are allocated, the
> freed pages are placed on buddy's MIGRATE_MOVABL list for use.
>
> When CONFIG_DEFERRED_STRUCT_PAGE_INIT=y, only the first_deferred_pfn range
> is initialized in memmap_init. The subsequent free_low_memory_core_early
> initializes all memblock.reserved memory but not MIGRATE_MOVABL. All
> memblock.memory is set to MIGRATE_MOVABL when it is placed in buddy via
> free_low_memory_core_early and deferred_init_memmap. As a result, when
> hugetlb_optimize_vmemmap=1 and huge pages are allocated, the freed pages
> will be placed on buddy's MIGRATE_UNMOVABL list (For example, on machines
> with 1TB of memory, alloc 2MB huge page size of 1000GB frees up about 15GB
> to MIGRATE_UNMOVABL). Since the huge page alloc requires a MIGRATE_MOVABL
> page, a fallback is performed to alloc memory from MIGRATE_UNMOVABL for
> MIGRATE_MOVABL.
>
> Large amount of UNMOVABL memory is not conducive to defragmentation, so
> the reserved memory is also set to MIGRATE_MOVABLE in the
> free_low_memory_core_early phase following the alignment of
> pageblock_nr_pages.
>
> Eg:
> echo 500000 > /proc/sys/vm/nr_hugepages
> cat /proc/pagetypeinfo
>
> before:
> Free pages count per migrate type at order 0 1 2 3
> 4 5 6 7 8 9 10
> …
> Node 0, zone Normal, type Unmovable 51 2 1 28
> 53 35 35 43 40 69 3852
> Node 0, zone Normal, type Movable 6485 4610 666 202
> 200 185 208 87 54 2 240
> Node 0, zone Normal, type Reclaimable 2 2 1 23
> 13 1 2 1 0 1 0
> Node 0, zone Normal, type HighAtomic 0 0 0 0
> 0 0 0 0 0 0 0
> Node 0, zone Normal, type Isolate 0 0 0 0
> 0 0 0 0 0 0 0
> Unmovable ≈ 15GB
>
> after:
> Free pages count per migrate type at order 0 1 2 3
> 4 5 6 7 8 9 10
> …
> Node 0, zone Normal, type Unmovable 0 1 1 0
> 0 0 0 1 1 1 0
> Node 0, zone Normal, type Movable 1563 4107 1119 189
> 256 368 286 132 109 4 3841
> Node 0, zone Normal, type Reclaimable 2 2 1 23
> 13 1 2 1 0 1 0
> Node 0, zone Normal, type HighAtomic 0 0 0 0
> 0 0 0 0 0 0 0
> Node 0, zone Normal, type Isolate 0 0 0 0
> 0 0 0 0 0 0 0
>
> Signed-off-by: suhua <suhua1@kingsoft.com>
> ---
> mm/mm_init.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index 4ba5607aaf19..e0190e3f8f26 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -722,6 +722,12 @@ static void __meminit init_reserved_page(unsigned
> long pfn, int nid)
> if (zone_spans_pfn(zone, pfn))
> break;
> }
> +
> + if (pageblock_aligned(pfn)) {
> + set_pageblock_migratetype(pfn_to_page(pfn),
> MIGRATE_MOVABLE);
> + cond_resched();
> + }
> +
> __init_single_page(pfn_to_page(pfn), pfn, zid, nid);
> }
> #else
> --
> 2.34.1
>
>
[-- Attachment #2: Type: text/html, Size: 5618 bytes --]
next prev parent reply other threads:[~2024-09-27 8:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 11:02 suhua
2024-09-27 8:28 ` Su Hua [this message]
2024-09-29 9:15 ` Mike Rapoport
2024-10-12 3:55 ` Su Hua
2024-10-16 11:57 ` Mike Rapoport
2024-10-17 2:58 ` Su Hua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALe3CaBNEb4Qh-9abTuefPxnuPzwTwR6k8HC+uSPOTKX01hwAw@mail.gmail.com \
--to=suhua.tanke@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=rppt@kernel.org \
--cc=suhua1@kingsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox