From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C595C77B70 for ; Mon, 17 Apr 2023 13:31:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0AF256B0071; Mon, 17 Apr 2023 09:31:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05EE66B0072; Mon, 17 Apr 2023 09:31:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E908F8E0001; Mon, 17 Apr 2023 09:31:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D47DE6B0071 for ; Mon, 17 Apr 2023 09:31:42 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A341A1405AA for ; Mon, 17 Apr 2023 13:31:42 +0000 (UTC) X-FDA: 80690970444.21.62C43F4 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id 13C4E20033 for ; Mon, 17 Apr 2023 13:31:38 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ApQLt+5h; spf=pass (imf13.hostedemail.com: domain of robh+dt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=robh+dt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681738299; a=rsa-sha256; cv=none; b=KGDSxD7Tr6h7jST7I5sUI2uUbkOyjicKC7IDPJOvn1hk3Hfj/G78ztyTBQg0hqE8OpD1uW bf3XqHHdMIyEkPzXo1N0HAasc6mb06om6DMkVgWWfo3/bfkLXiY18rVHHKYcH1sOK//to+ fLGjmdYt5fmAOSBIyhU5hmHrBzluKXs= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ApQLt+5h; spf=pass (imf13.hostedemail.com: domain of robh+dt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=robh+dt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681738299; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g7lOo4Fnp7pQoYeBdj7OQYoaM2kfEje7lu6QGvwlgbA=; b=UYRggzfB/vayOd644ApLdS6SEh1MW8B/ZCPbn2ZOgOhYSX4BKV/3javw2cDUy7UovikU7v /WbjoYrNRbOS6CgYrjz3lSv0yXiC/bBlphYGoJ8fTwFg922f1cc/vNB1RR9MAoMlN+fxFU a1mZG6cJc6VbgmkvAnNIlQVVnHlE+pU= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 95529624A0 for ; Mon, 17 Apr 2023 13:31:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C21CC433A4 for ; Mon, 17 Apr 2023 13:31:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681738296; bh=Z1E7VRImbk5O8ynjKxbGEPL5/pNRjHf9QbC2IrDjeEw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ApQLt+5hMKVQIvzY5fCsHXN1O9d66Vkqdbnf/xozhB9nuWuwLcZf/MN0ppBlfhFIt HQDUV2nEhzb6hm2lIFc6FOWsKV/xtHSrJDm16DGEKIk7rmSl1kCXD+7UtJki0cUM41 8okXBMRnAHqFb3pXt6yy8HLqPKgBBH01IvciEYmbPaO9iX7on0mQpD89z1YsQnCqhL q322Ce5KqizgqcdNbLPtssnzKOay7XNC41dL/SlQYjEfg4XGzbmnPKW+wXhduIwJN+ v6rbKR36oXKryWyC6KbHqtudzstgkxltXOwyhoC5jg1NY3BT/2BLRzyKhheW+Oby7i 1ToU1aRNddTrw== Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-54f6a796bd0so302439567b3.12 for ; Mon, 17 Apr 2023 06:31:36 -0700 (PDT) X-Gm-Message-State: AAQBX9ewh38B87rPBvPdR/o9m8nlPLLtVWdnws2sT2CdFUXFsV7q81KC 8NZNeQeY4lrl1mOBj+rGxF9R48zzJIhEUzU0+w== X-Google-Smtp-Source: AKy350bviA6nMrYItp2UFoijYxMfOof9zLeZI1Waml/VUI/79m2nqsKw6eSDud+5a83sS7abqkKDxQ68edHzGfQfRRo= X-Received: by 2002:a81:b60c:0:b0:54c:a67:90b with SMTP id u12-20020a81b60c000000b0054c0a67090bmr9245222ywh.5.1681738295535; Mon, 17 Apr 2023 06:31:35 -0700 (PDT) MIME-Version: 1.0 References: <20230412224620.8909-1-tanure@linux.com> <20230412224620.8909-2-tanure@linux.com> In-Reply-To: <20230412224620.8909-2-tanure@linux.com> From: Rob Herring Date: Mon, 17 Apr 2023 08:31:24 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 1/1] of: fdt: Scan /memreserve/ last To: Lucas Tanure , Michael Ellerman , linuxppc-dev Cc: Frank Rowand , Mike Rapoport , Andrew Morton , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, jbrunet@baylibre.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, martin.blumenstingl@googlemail.com, narmstrong@baylibre.com, stefan@agner.ch Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 13C4E20033 X-Rspamd-Server: rspam01 X-Stat-Signature: bf4dg4qwgsqdpac4goz9m8mqj1owp5jj X-HE-Tag: 1681738298-185566 X-HE-Meta: U2FsdGVkX19G67SnGKrSc3ukC/fQY5x+GjqnXRHC0lA3A3tRZUFbA+s+BHRG5lTzOWWhLV+pM81tfXxNA5ZLrGZQNoWr8gaX6d6gdfAqzmlHjqvGSlyG1kjUFIORHxmfeKiWpVjjFwot9zgr4AyTVBfCVsxiJjaGb0UnGiIRfyDMrp6yNOMUJup21HXTvbfMU0KU7CemMwjH/K05Elb2aCkq95Nn46rm0547tNadr1U64wjUocn3n2d9bF92PDzvnJ8S5/CorCqyhj5Yx5PRDg2S3J1zjJWssnt34nM7N3+5NTal6KTiZfFBx0xwEmZ7psV5yxkz23bJwIVMua6jb9CAVK/malM8lPE3/1pAObVu+MzHEH7c4isXNcHzsiqBK7+sxGvsTAg9iID2R23yrmCKIuLuf8pvufv2kchTlt1xs33497pn15QFVL4uvwrzHHlYBgnW+wDox6rvj04u5E4EJVZY1DGV8kAmqNMSFMJO7CgFD2AWlSOvieLfbsIfKfC45g7VjuqJK7hy8z1D7vplJu9T5mYIN2YploP1eCssOX3JtVHpYicZRbuGl2SES3hQGzKA6dJM/BmTVIsX+b3ZrUzBTCvWp4kbp2lAVAcYqyl7QHexoyuV1MO/34sYvIsags3pemIibjXx3acfj36IuNKGfXt+1ZQgjPOwx1Lt9m4s5LzIwcCg8ic7EieM13EfeFx9SNV4tIdFDSyCSrP+/jTMjoZfPUqBYYjrfxusXuBUlTHveQ81bjfQLRvkVHe8kKwZLbZUEPIsW1MFP8VVF6BtNin3ai7gtA5jge9vS2uu5kmZGrm2/6ebZPLhvyDz3DB9eY/bmt/Ui9HPpvUFkYE5UHKiqqizPAbjv4mE+Uil60+HPU8raK44Xeg2JhkcU/FT3HPzSOZ/lIwT/rhF/FX11Bgn0TtbQAAYb6yx5f/xFQgK1m691t0JKTHVYON/o4Hc8FoqVl7naen DxnPDOyR MPVqkJpRkeQdQ+e5vpt+4IH/X5XXFWzmSLXitTkT9t+du3yLuzn/2pzsqjb39ESe4dKNPYH+VtpP5PEvyjAutBzDtz0ZWRfkD/5/VpHyh+eWzaGqLTBsIw0LljXdZ0m1a1azRssdSvoMMuwKYRIEz6HatX2c/C5+eEgKk3Uh4NmBUbvwr7Wf6Jy5otAAX/4UTMkd9uzjsgl5f+IqMHPpjyCXAd9i34WEnYbFlz9EMPXci9Jha5XeCv1RfW+hAZKXv915FijHusJ7GuXvoNSckAkXfUwQArXy3t8OkhUKJQghoElctv5f1Uzimh26JiOnSAAoxN/zYfnbKVfe1q0iS1zEGo/pPhflLZ4BOS040LCdk30+2j5XvNEnHvpEGqyyOh6a44UakAB1v/3UXqM9V5Cqm+2+vEKQMXmv2945SJ7vUwCaFyA8S2Bvp5CmPSX/QbFBEkz/wtXFNEXT10VNSnG8OM6K64B7octkreDMnjfu9F57GLuf6t9w0eQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 12, 2023 at 5:46=E2=80=AFPM Lucas Tanure wro= te: > > Change the order of scanning /memreserve/ and /reserved-memory node. > /reserved-memory node should go first, as it has a more updated > description of the memory regions and it can apply flags, like nomap. > Also, /memreserve/ should avoid reserving regions described in > /reserved-memory node. Please give some background details why we need to make this change. As-is, sounds like some theoretical issue. IOW, incorporate some of the details in the cover letter here. For single patches, you don't need a cover letter anyways. Powerpc folks, please comment and/or test. I worry there could be some subtle differences with this change. > > Signed-off-by: Lucas Tanure > --- > drivers/of/fdt.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c > index d1a68b6d03b3..c28aedd7ae1f 100644 > --- a/drivers/of/fdt.c > +++ b/drivers/of/fdt.c > @@ -635,6 +635,9 @@ void __init early_init_fdt_scan_reserved_mem(void) > if (!initial_boot_params) > return; > > + fdt_scan_reserved_mem(); > + fdt_reserve_elfcorehdr(); > + > /* Process header /memreserve/ fields */ > for (n =3D 0; ; n++) { > fdt_get_mem_rsv(initial_boot_params, n, &base, &size); > @@ -643,8 +646,6 @@ void __init early_init_fdt_scan_reserved_mem(void) > memblock_reserve(base, size); > } > > - fdt_scan_reserved_mem(); > - fdt_reserve_elfcorehdr(); > fdt_init_reserved_mem(); > } > > -- > 2.40.0 >