From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F143AEB64D8 for ; Thu, 15 Jun 2023 01:34:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 461496B0072; Wed, 14 Jun 2023 21:34:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EA136B0074; Wed, 14 Jun 2023 21:34:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28A7F6B0078; Wed, 14 Jun 2023 21:34:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 13E6B6B0072 for ; Wed, 14 Jun 2023 21:34:53 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CB3D51408B0 for ; Thu, 15 Jun 2023 01:34:52 +0000 (UTC) X-FDA: 80903263224.23.C32ED6F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id DDDC42000D for ; Thu, 15 Jun 2023 01:34:50 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bzN8642Y; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of robh@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=robh@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686792891; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h6fvfiZBoLJ9RcfiK3xPIfItgpjhCEFwJEDDYr0CSpI=; b=WphY4XWFZq6s0/x9wpZ+V3tpTGFefvvvC5vHVi+HMIz8faxX6+c3SSy90y3bEJf777vo4N zCz5wHIVqHLOj3f+tz6pFdKmgJ4/YesNldkyRElFkQ1V0th17BScXNh6VqPhiVMTIPlm3T LzUXAJaBJ0OwuG8VkrCPu7yBAtmF7io= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bzN8642Y; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of robh@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=robh@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686792891; a=rsa-sha256; cv=none; b=zn2llsRd2oIU7i+Nd+znFjNmzgI/PoEv6IPGGJNU58bGLmLd5ns3ueNWf10Rgv4w6Ic6Fm GqcB465JV+FsK54Fef7r8oZi0ivW6vZ0ikjGBKSyo7jKzCVFqcilHMeU4XnZqyLjEpEcR+ 8oMZ6yAw/1q/YuSSsWAF1SL3Is/B+ow= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E03316181E for ; Thu, 15 Jun 2023 01:34:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3DE5DC433C9 for ; Thu, 15 Jun 2023 01:34:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686792889; bh=4JDmkFL1ybbw2qryCxHYsAFh65V3q674kF5SYlnA2M8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=bzN8642YPb4iOzlU5j8+fSqzWFtGxh6Y8qjsXxz5c3O1w8w2saWRnq2q0BUyLvuQd HHnBRKQpVhR1yVzwqRRqfntlR6djm6szsuRTZpIkrpcMKuAS9VB58PuBsmnRlS88qO 40GOf80lOBm3geep07tyk8/nzgsTvCokeT6hyluTGWMw5bf4WfwyRiKck+VrLkWqBQ znT/oDdg58bYBteBXXZi6U/geO3JPMpcT3jLGpCaK9F0D077QucSXCoc6qVMtSW3T6 fdVpF76DEgvDbYmVlxc+P08g94Ouz1IyXTI8kYhNDqjIOezEPb8Ev+rB7xjxGULldi ECEZviGuKHYuA== Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2b43a99c887so5410241fa.2 for ; Wed, 14 Jun 2023 18:34:49 -0700 (PDT) X-Gm-Message-State: AC+VfDwaRs8FYGd71SLa4s3k1ohJj11MZEto8wS34bsWo4VLfuxNRGeM lIUUoTlRUUOUsCzwTdC3JbAVrIKTZYZsdryWUg== X-Google-Smtp-Source: ACHHUZ7/zs0IswJu6mIJqdL86fAYQ4yaQbHWfkCkfrf4MRCra28Amsc3x1QkAPlgHJh4c/fIwTL9HjCh7f4SLAP89hE= X-Received: by 2002:a2e:86c4:0:b0:2b1:e8f8:e0ff with SMTP id n4-20020a2e86c4000000b002b1e8f8e0ffmr8324787ljj.10.1686792887272; Wed, 14 Jun 2023 18:34:47 -0700 (PDT) MIME-Version: 1.0 References: <202306141702.ZaO9V2lk-lkp@intel.com> <9be724b6-9b3c-51fd-ca20-634603a9145e@kernel.org> In-Reply-To: <9be724b6-9b3c-51fd-ca20-634603a9145e@kernel.org> From: Rob Herring Date: Wed, 14 Jun 2023 19:34:34 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-next:master 9063/9793] drivers/ata/pata_octeon_cf.c:835:7: error: call to undeclared function 'of_property_read_reg'; ISO C99 and later do not support implicit function declarations To: Damien Le Moal Cc: kernel test robot , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Sergey Shtylyov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: DDDC42000D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 4ug49ykkw8j3y8739jpckapip5ni56et X-HE-Tag: 1686792890-98011 X-HE-Meta: U2FsdGVkX1/ydJU0YVuMf0vGp34VzQwf2dKugPSLSNrPpP4P/wnSzdUrGoeIsUoJ5ZkU/WhYAaFtDpkVags3Ai26rQ0H7eFEnE3aQu4uSKaOHh0DZ0xKhXV+C+dhK5lrxz6lDY8TQb7qXZF7NfT2HBwfSdcqOWosoOpcAo9HbPhRdXQPNMu3cN5DJZ6tZroD5c98ITl8GciSTFdHwUfmxvsunhWrFKNPXi4PeTpaV56FBOqrJmahcSifab4Nrv/Hhg+yPh2HIFhpmYAdh6PE9+Ux1IKcAjaJrMGlyDTT7Ao/YYPfvj1mmKwX2/2AEuZPRyzIGUg+mAEwOki1r8WTLbgX9x/tuzHvEyAKt/8k6z5QLgkLGq2RU9cQ24U7fniaXilPIC6oLYaaGutf9Fvp1TVtE96pv10hscEEep69pIcXL34lpyXMHOnlYf4eg3L74Qs3gh+Cg1Z56ACoizw46S7HDMbShCx9wTVL7ZcszpR0MwakOv13MOWtYnBHs9fqK5MpFUFCVvmE+pH3pqRJ4i2w9kWUMV+Z37u/2T7xqGtO8f8DfdvLbcunUfkaBNtxQDzzvF9rzfCQ8z05UwN1rRTcPK6764YSY5DrgkB9VFocvDYgcgOLr6qPQAHa/9wxpR9QBut85aZbRZuNO8+cqQ1ar4JYNdA2QYyKsmAGVv/PcFpxjchAtbHQBCQMC0AuD8n1NugCJA432o8h5THpP+mu/86R6acyDzVtbIT+acFsQ69+ar3qLCUBvuNhu66cDyx05FKgdElHmCC42FVYsBSIg5cRe2NSgLO58glcNNnjMwhjHwiurVix8/+LfJsFS1ITlUWvens0N5QHDvoaElndDn1h118w/Ro7d/je3L9Bi+yUktZTofMED5PyBSE01BZ2sLfulk9SraexBG+WbrGD94V6jkJU8byG2l7AZpbk2XOaSAWLH4wn0U5T+HWfy3Q4SabdXJsCT+aeMqa mL4K03AX 0uH7ObXRemvjTVFCePJPvLP0Og7PMz8Sk3oai/K62IB7Xn/hS/1PSGU7ppiFbsIgvgTFNNdmFIxWPjP+TwALPZG4mt/WcDVH0vY8/Pc5TZO6fQJyn5cpf9gYEO03aqZSZNbTpaS/a1xyNBNMUmIXLxei3SGXoZtepk3ybatNAymq35F0pIW4WrcdfENUTXg8ki/m5rhWZq+w9yAYv0DIgXu2VzAcgyvne7K+T75v7wZJ8B6cmjjZ/GMjBzzlwW2J/dX5H65df4asB2zHVO1YdRQI4iD7EPt7nSx4NiH2yEj0Mz55djz/3e87g4uPgtaWBmDmJ3pu9tg5ZWGNYL6Qwof5DeOuWnbJNpC0DrofpIg0berKLh8X5MpVAO0Z7sBAnHqbSheCGnC7Mfxg46c2bXsRn5MSY9vCs03tq+Arn4B2R2Ef2MuYje47n+YZte28tWRxp+uTrOJYqDtSf7v7hH6VdOLbLNO2GWmoiZf5rT2K0RFkmc3B8N38t46iyXQ/aqBQ/gZMCeLeUjVtXVOSiuFLzTwBaq1WGSCb1zxZv6se7oNm75z5VIC7phv4FM4N3C39m52BUkE9Q2V3+UVyCNnGzCn4vrQz9wiYrs7fA51Zpg3yzN5bpnq/sb15LKJOFoEzZYQb1DzcOwNVvLtKfAq8koA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 14, 2023 at 6:41=E2=80=AFPM Damien Le Moal = wrote: > > On 6/15/23 00:26, Rob Herring wrote: > > On Wed, Jun 14, 2023 at 3:41=E2=80=AFAM Damien Le Moal wrote: > >> > >> On 6/14/23 18:23, kernel test robot wrote: > >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-ne= xt.git master > >>> head: b16049b21162bb649cdd8519642a35972b7910fe > >>> commit: d0b2461678b12c08d43eaf6740485e2f2c3aeac6 [9063/9793] ata: Use= of_property_read_reg() to parse "reg" > >>> config: mips-randconfig-r016-20230614 (https://download.01.org/0day-c= i/archive/20230614/202306141702.ZaO9V2lk-lkp@intel.com/config) > >>> compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.= git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a) > >>> reproduce (this is a W=3D1 build): > >>> mkdir -p ~/bin > >>> wget https://raw.githubusercontent.com/intel/lkp-tests/master= /sbin/make.cross -O ~/bin/make.cross > >>> chmod +x ~/bin/make.cross > >>> # install mips cross compiling tool for clang build > >>> # apt-get install binutils-mips64-linux-gnuabi64 > >>> # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-= next.git/commit/?id=3Dd0b2461678b12c08d43eaf6740485e2f2c3aeac6 > >>> git remote add linux-next https://git.kernel.org/pub/scm/linu= x/kernel/git/next/linux-next.git > >>> git fetch --no-tags linux-next master > >>> git checkout d0b2461678b12c08d43eaf6740485e2f2c3aeac6 > >>> # save the config file > >>> mkdir build_dir && cp config build_dir/.config > >>> COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dclang ~/bin/mak= e.cross W=3D1 O=3Dbuild_dir ARCH=3Dmips olddefconfig > >>> COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dclang ~/bin/mak= e.cross W=3D1 O=3Dbuild_dir ARCH=3Dmips SHELL=3D/bin/bash drivers/ata/ > >>> > >>> If you fix the issue in a separate patch/commit (i.e. not just a new = version of > >>> the same patch/commit), kindly add following tags > >>> | Reported-by: kernel test robot > >>> | Closes: https://lore.kernel.org/oe-kbuild-all/202306141702.ZaO9V2lk= -lkp@intel.com/ > >>> > >>> All errors (new ones prefixed by >>): > >>> > >>>>> drivers/ata/pata_octeon_cf.c:835:7: error: call to undeclared funct= ion 'of_property_read_reg'; ISO C99 and later do not support implicit funct= ion declarations [-Wimplicit-function-declaration] > >>> 835 | rv =3D of_property_read_reg(node, 0, ®, NULL); > >> > >> Rob, > >> > >> I guess this is missing: > >> > >> diff --git a/drivers/ata/pata_octeon_cf.c b/drivers/ata/pata_octeon_cf= .c > >> index 57b2166a6d5d..ff538b858928 100644 > >> --- a/drivers/ata/pata_octeon_cf.c > >> +++ b/drivers/ata/pata_octeon_cf.c > >> @@ -16,6 +16,7 @@ > >> #include > >> #include > >> #include > >> +#include > >> #include > >> #include > >> #include > >> > >> I can add that if you want. Or you can send a fix and I will queue it, > >> whichever is fine. > > > > If you can fix it up, that would be great. > > Done. > > > I'll look into whether this can be made easier to reproduce. These > > patches had been on a branch and picked up by 0-day. There must be > > some implicit include of of_address.h somewhere. > > I looked into enabling compile test with removing the MIPS dependency to = make > sure this driver also goes through my regular compile tests (I am lazy, I= do > x86_64 only :)). > > Something like this works for ahci_octeon: > > diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig > index 4572f837e504..6b115685a86e 100644 > --- a/drivers/ata/Kconfig > +++ b/drivers/ata/Kconfig > @@ -239,7 +239,7 @@ config AHCI_MVEBU > > config AHCI_OCTEON > tristate "Cavium Octeon Soc Serial ATA" > - depends on SATA_AHCI_PLATFORM && MIPS && (CAVIUM_OCTEON_SOC || CO= MPILE_TEST) > + depends on SATA_AHCI_PLATFORM && ((MIPS && CAVIUM_OCTEON_SOC) || > COMPILE_TEST) > default y > help > This option enables support for Cavium Octeon SoC Serial ATA. > diff --git a/drivers/ata/ahci_octeon.c b/drivers/ata/ahci_octeon.c > index 5021ab3ede49..2e6b28bf43f4 100644 > --- a/drivers/ata/ahci_octeon.c > +++ b/drivers/ata/ahci_octeon.c > @@ -15,8 +15,13 @@ > #include > #include > > +#ifdef CONFIG_MIPS > #include > #include > +#else > +#define cvmx_readq_csr(csr) (0) > +#define cvmx_writeq_csr(csr, cfg) do { } while (0) > +#endif That's kind of ugly... > > #define CVMX_SATA_UCTL_SHIM_CFG 0xE8 > > But it is not that simple for pata_octeon... I copied you on mine[1]. It doesn't build for !MIPS, but at least doesn't depend on a specific config. Should be good enough for 0-day to build somewhat quickly. Rob [1] https://lore.kernel.org/all/20230614173633.2430653-2-robh@kernel.org/