From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A393C38142 for ; Fri, 27 Jan 2023 21:40:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D6D76B0072; Fri, 27 Jan 2023 16:40:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 760696B0073; Fri, 27 Jan 2023 16:40:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6005B6B0074; Fri, 27 Jan 2023 16:40:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 48BAC6B0072 for ; Fri, 27 Jan 2023 16:40:21 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 12445160FAD for ; Fri, 27 Jan 2023 21:40:21 +0000 (UTC) X-FDA: 80401897842.27.FCEB536 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf24.hostedemail.com (Postfix) with ESMTP id 2CC5B18001B for ; Fri, 27 Jan 2023 21:40:18 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=N3qRZC8v; spf=pass (imf24.hostedemail.com: domain of robh+dt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=robh+dt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674855619; a=rsa-sha256; cv=none; b=B1wT4kbig/mcM6R4lLR5fdF6uyo9jfH8J/FRUMHSfjgbtaYx5C26UGiF8oP/0PA9qDU6Ht BCTfnD4919olNXhXvl2V0XAjVtJwOVdXPxk+dCQSldkCxDoXYQW8T3AtnabFpWFe5LI3KC PMkstSmbdhTaCdzAmpmtTHCS+BNheU8= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=N3qRZC8v; spf=pass (imf24.hostedemail.com: domain of robh+dt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=robh+dt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674855619; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=THghJBwospp2SXlIo4aVWCBbm7FTq2zmVK9YUZX1kUg=; b=zaL7cHz3143sI4HekVUsJL/NFVX9IeqY4FqYnOF0LExsKg6fkcM0JzbizGKAiAeBW9npGc KR8xJ14SjI01rws0XEnntc3fH7rMtuVSWOtV+QgUwEomJAxhX1UxFITN+M6tkSOQ/o0o+a TKlhX0YcvBKyE9wLQ/1G8Mm7QxYT+TU= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8779BB821AA for ; Fri, 27 Jan 2023 21:40:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C685C433A0 for ; Fri, 27 Jan 2023 21:40:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674855616; bh=b9uDjU7LT+I/mG+9iGB49kgfPiodbLBnJTjLq2lnm9w=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=N3qRZC8vEwy5COnn34s8YMMpSApDx6S6U9Hg+fU42RD4JGew2wmhznAk/VjOdZkam 9NBxaiAj5+cadTfif/p7cWIYOhLXXMaTIZQZRTu+uFhVLbAznHoNYkWkAciTgCFyZy sqTYII8kp4HDvDDv7k+qe13bqVo0GfIrSbgrj6UDmN71bNqkeecGbTz4v+rpKo68ql aNrcFQ0S5pc6cX35LcQ+p1568wjF4D1lMAIg5dTaQQMtlP4frLcUM30CFpHN5JNotn r/g30uCOFwFNRO6AWkfRTY/pJyl/4oOI78VkaMnSXEeV0ddnmKqSSVhUw/7tZ0oVY7 FBp+cCG3Ml9Qw== Received: by mail-vk1-f179.google.com with SMTP id 22so3091454vkn.2 for ; Fri, 27 Jan 2023 13:40:16 -0800 (PST) X-Gm-Message-State: AFqh2kqaEOBM/PIgnxZsMKzzF7F+wd7xOTgvwd2KgMezjcYYaTHYcU/K hJyapFxG/CfpY1u6rXcdaF+DlnwzGQyovkM4bQ== X-Google-Smtp-Source: AMrXdXulnAkMWnXjcpXL/m412Iyt/Rx5osfcz9TGvRj6nAOp0u1AZt82H8i3SoeHOSB0ncQUU08SxYlZ7jc24m80yTs= X-Received: by 2002:a1f:ad56:0:b0:3bc:8497:27fd with SMTP id w83-20020a1fad56000000b003bc849727fdmr5298244vke.15.1674855615161; Fri, 27 Jan 2023 13:40:15 -0800 (PST) MIME-Version: 1.0 References: <20230124230254.295589-1-isaacmanjarres@google.com> <167485548359.726924.14589412750691974893.robh@kernel.org> In-Reply-To: <167485548359.726924.14589412750691974893.robh@kernel.org> From: Rob Herring Date: Fri, 27 Jan 2023 15:40:03 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1] Revert "mm: kmemleak: alloc gray object for reserved region with direct map" To: "Isaac J. Manjarres" Cc: Frank Rowand , stable@vger.kernel.org, Saravana Kannan , devicetree@vger.kernel.org, Calvin Zhang , Andrew Morton , linux-mm@kvack.org, Catalin Marinas , kernel-team@android.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: 2CC5B18001B X-Rspamd-Server: rspam01 X-Stat-Signature: ynk7xx7634w1xwwwm8jd8f6g88wmfybx X-HE-Tag: 1674855618-44932 X-HE-Meta: U2FsdGVkX1+KEf+qygMkWbqM/+Wbvj5b6h8s0UxqLDzmhb1tXsC6/8/PWqGngsz7aPXo+UH3nXSdanudogtPV7tWGjiQeTMSe7lhLtJ90P0rDOav5ZAsHUOqYo9SU5BOMnSXfkjyrgUJqA7GaK7XToZ8kHe/F9oWxGxycsytQc7GSDe52rXjzXe2vnIC8B232qGzi0RJnWSH9C8AuoG8KiJefhb14nwyu5uMnCbBlNGkI34AxLlQzp53JiKyLGhgo8u6kGJPKIfpz5LckTeym6QWEGredMuywi//XDGm0tQSu1+g3kUzbckC+1a8BObK+mdUPq23C/PSnM/vCPu+hszNqpjTs9JmFxTI7Z5y0mtVD+XMBkwVeufAv6NJyHdaLv4CBHMr8LhE9OnfhDQbB4PngQk2AK2ukxZoI8GLClGYniRINh/Gmxdvymvo9vb1wDegDrB179+EPxpm7Nrmr7wwebNe49/iGK0L7B8yaRaOiF4kHRMQzJqgEJdaKaE/5Ge5IauPD6o/BPgTw/CwCP2VLWquqR3Yi4+S4/+VHlUfI5s5qJ1Tz2Xiy8aZEmIMyQ4K2M9C0E1R9jkYblMOHupd9uPtlnWGl3aV782s4o7kSa5qqL6wCV6GXKtavZGp49iSUZRd5jI3+HfmrO/LCUmA7ZwovT64HiKkDNmo5ROkJi6TKuhNmXcIHr0/50RkL8VoNuk8+vNdTb31My2Ph3zx8H6WbZMQhTCCkPcY2h+tUvL7ycJrSQbS6is3KMhdG+vCv7gOjplC99sub+bPeWWUvKY39z24GP4W7endhL+y8nDumdxPgrg3ymW/QwoRdV2QlX29XacENTMcNunfEAWQoB6GaocjLyZDT5oLBQ/GZ3Rf5Sxnh/MwMuuhFuLjvJf4J0fHKDqo0yUtpmJvCbHW9ZPEmHIacYFYuE0jGQKIXyRMQjinj84Kmq0qfy0nuy6T9pMB18tAgECHoZo 4LyoFa8g lsNyqcVDCQEoicwIhX/L1TSXpmms8eD5igC5+z0LHovbeCzwdb4FD9cuKcV2qRV3nIr8mDlve6LU6CRPCFcEZLsB0Mg8IJum2QCIHxNX+jG+RM41RyoMzX3YdlqhDgp1/cQQUEuobW1d64ob58qJCihH2PpXWRbBbOUInpguF6uFW5ZXKbCncwRdHL1gkCEd5TCacm/PgkhKfB9bctrqtcDwp7rlPGcBIYqH0CQRU29ZggEdN3VoLiP7yoBQjNuZeFTFhtGxhp3oRD3dAzs5e2Kkmj5wyJby41SDJCkI4S3GBuy1vEIk+OjyPKUWFfiMhR+pqUdruxyqCKzIlSF3o8QhCegWOnJpYsoCRtnsgYRMzrtfhWdxSsfjjaSLYij+dzA+j7QlsGfkd7Cv9+r3Dg/+RzWOvdgRblPMBGKjKDSVQ9463wUeqXm7p2w0OFmMUtZbayZ+KQg5qyfWhLwc3W+2Ww+tcInjulSLVoClWyG2XVUn5jiKDrWGSh/9cbFVFxOiqJBg9G7NnOaOoc3U6su+vBeB6XEYY4XhC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 27, 2023 at 3:38 PM Rob Herring wrote: > > > On Tue, 24 Jan 2023 15:02:54 -0800, Isaac J. Manjarres wrote: > > This reverts commit 972fa3a7c17c9d60212e32ecc0205dc585b1e769. > > > > Kmemleak operates by periodically scanning memory regions for pointers > > to allocated memory blocks to determine if they are leaked or not. > > However, reserved memory regions can be used for DMA transactions > > between a device and a CPU, and thus, wouldn't contain pointers to > > allocated memory blocks, making them inappropriate for kmemleak to > > scan. Thus, revert this commit. > > > > Cc: stable@vger.kernel.org # 5.17+ > > Cc: Calvin Zhang > > Signed-off-by: Isaac J. Manjarres > > --- > > drivers/of/fdt.c | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > Applied, thanks! Or not. Andrew already applied it. Rob