From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70936C636CD for ; Wed, 1 Feb 2023 16:13:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CDE166B0072; Wed, 1 Feb 2023 11:13:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C8E2E6B0073; Wed, 1 Feb 2023 11:13:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7CF16B0074; Wed, 1 Feb 2023 11:13:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A8AC26B0072 for ; Wed, 1 Feb 2023 11:13:57 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 77C89AB61C for ; Wed, 1 Feb 2023 16:13:57 +0000 (UTC) X-FDA: 80419219314.30.B32C975 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 94731140003 for ; Wed, 1 Feb 2023 16:13:54 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="nW03YI6/"; spf=pass (imf09.hostedemail.com: domain of robh@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=robh@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675268034; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lQVxHe/Nn1SxtoUK2KJwQgavxzQ/A+Quy9chbSDIutE=; b=buQVC5XaWXO8/YLDRYGVszyVGgopqFAyj1vzXpOUnH8xfoaOG1YPvZiWZYlLAoJxbXNxCL 4CBCDMXH9J8pcSCXhld33xv+Hzd+nmZDYdhmfm3Lpvwq5JBabU+Lp+twwSaXr38qPrK2Ev SEu/xg0kxSTD0ntk8BkZRNdffySGJJA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="nW03YI6/"; spf=pass (imf09.hostedemail.com: domain of robh@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=robh@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675268034; a=rsa-sha256; cv=none; b=Rvf0h9IvIbmvcpFhPTyRLszNH1qaxzM74cD1OOev/Snde/vV6XqknGUlEkPrX4zGQ10xB8 VibUGjDgQ+xn+Zs5LR+5pdAC2SJEw0tl36ZXlevMVFQbWpiC9TApm2266vLxTqqybTJvrV bdTr+BdczoISsHPBfN9oFzGdfoPRq7U= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 98C736185F for ; Wed, 1 Feb 2023 16:13:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E1C2C433D2 for ; Wed, 1 Feb 2023 16:13:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675268033; bh=FrSAk9XNF7TwwCwEkfrezLRAPqP75+aId7RcHMq10Dc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=nW03YI6/AlbrxvIcH2sM76vTH9rMlhrsm1Ne4crBQYwNFUVmV2Ru519x1SOBDwZA8 5/+NGfIsIANN1/C6c1m1yXwUiet+3eclsKDFa5r4LMCDm6slODjWqNhFKN1GAYOBfp 3TOJaQsl1CQmP5wpS+XFABtQygJH0hOs0UN0GFuaVUlQBPd8FOu3Uvg6XU9x2ceI0B POrKHBsPb4sKwzK6ESEjGTQKTArSs/z8edHMuhA3y+Tl0d8uvC80ntietHuU1xGxyz VikKNAN9l0ajw1gp6leQpLnqG2DD0G22KOq7tlG2FrVXba16tgZeJwpRt4hE9r+Zuh mKftMZzoHdaEQ== Received: by mail-vs1-f50.google.com with SMTP id y8so20251007vsq.0 for ; Wed, 01 Feb 2023 08:13:53 -0800 (PST) X-Gm-Message-State: AO0yUKVMXfe0tHamUryjybvoW5HnYUhehp9AgY/lRuaTfXsc7U0fpvTB pThmcpaJBixnKOSSI4gBVkumZ99LIpk+xXfp1A== X-Google-Smtp-Source: AK7set8GcnebnMv86SxiUJrWVXLTzd/uwYVN6/94gb5TdAiTyExvvQ/jRQ/yWh1h7S597V63Q3UVDd1BCc+I23TMET8= X-Received: by 2002:a05:6102:3e0c:b0:3b5:1fe4:f1c2 with SMTP id j12-20020a0561023e0c00b003b51fe4f1c2mr517328vsv.0.1675268031993; Wed, 01 Feb 2023 08:13:51 -0800 (PST) MIME-Version: 1.0 References: <74a7f841-aef7-7748-725a-598ff8e4e5ea@inria.fr> In-Reply-To: <74a7f841-aef7-7748-725a-598ff8e4e5ea@inria.fr> From: Rob Herring Date: Wed, 1 Feb 2023 10:13:40 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-next:master 8679/9815] drivers/of/platform.c:570:2-23: WARNING: Function "for_each_node_by_type" should have of_node_put() before break around line 575. (fwd) To: Julia Lawall Cc: Michal Suchanek , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 94731140003 X-Stat-Signature: pj7uz3nnh9ubkp78ezrao64cnns31yqy X-Rspam-User: X-HE-Tag: 1675268034-6865 X-HE-Meta: U2FsdGVkX19vikTZrE3VIl77KL8BMt4G7takrvLelLJosrM1ak59COXxXbXZSMdHHr9+/6QbugC12HLaacCVvU41QIjS6yfSYbanndzWUsXUMSxgfxCX5vqTK4HPU3Eh+VM3buoM9ubpYb1p7YUGxmoAemNXqab775iF58S1vyiU91c7QLhPGILPF9OpGgOBJ1oSrK0PnbuudkYtY1fsL6kzk9u/43V1K20hMIPNnCh7rVCp5k59ea9cShQBmHOspKZgVwh9gzvN2nfSra/phXTfyd/ifLZEU9/SQuiRH0afS/c43XifXArAXGEP3e5xN/o4kg/ouAqYz082IkOsAPeCLgZ6no2cGkrvV5MoUDfNLrRdvch5+ju2kZiXgYMRfEZ3yHjdn0aeNBVvk4bpou63sDbQ28AhS3PVMUKgHofWcf8tNdtwaP1Q8ST7ExyLockn/N7A4iGGU1m0p9X+yHa7/WImCtam/c/b0/KVxWsalUTrqzao9T7M5ZHg2OmzfEJNDi8d4tweM8TmOf39NJUvXzyjY55l4UrU59PAe2rF6XMbKV1ohMt/S56JUXYcN9Yljr5eXqFgNx6ysseYnFaspBRO5/qctUw7xqwMAsntiNpSP67ARkRvqQJiBIFO/0ueC5Uj6JaZjCt2TQAmgH++5zCk5F88wDzSLpb6XywdBZ6P0nANiQ7Z6pR/c+nV5PQHqbfpTnsSaAEFb0v1gaHWxdyDnDzn/O++Y0+90Sv623uwJg+Lcge+idFGVIjpfREYpjET9NLi8FwJwPHP0vhODYXlVjvQi0B5BfrVzkbPk7/q0FysbEUgPXjQJ9oTUHE63yoCov/DsmfVl8PHca22tow+7get7x2Hb234L1fPfWtpC7RRr6jBMLxzwX6vcSFdEKmPJcQRYvaUkVmLo61eubzxfS/LEIqlZSnz7mKxPDRdfUfI2el/iMOLeeS/iisxnGrf/xoimIQ12/P xgez8zan 7GAcbIiY3com1k3eAnxrLaxmjP7nUO68B3XEiZwjtsI9CEAPZKWiKfqW5V9LJ+VWn2yvcYmeXEWDun+F89sPFtg4JNo4Q444Z0so7b7+XX1pISSe4UmljnQ6o46eNXOOSRNGSe1HNiocJvGsjkRBuFumlEZ9f3TCnPnmdqo9z639JA4z0Rh30edpvNO+g7g9XSYeKBv35Eqhzjt8N6shJqmwlyhMaav6AeQ7Ff+KnfQy4MDz6XN7oa927pqalAs2CAEsmtnxmL6O1wpt4EyHXaFNd+9eT8fXHXJdV/KF52pNsw0y0RsNZpO60wdQMz3OkXvie886icwBsEB0XAZaeU04SnkOqq8WfeyqBDn2wLpjiJosqmQpPWnWBgG+OraqX4Yw++wZWvxg9uZFXQfjKfHxcaxXS+DlPeLnczfWh++JSPSqyh0o7bT06ENsZT8tMWN951nx7xHuRog36pjBrBTLlgJDTDonQRM4+4qJi6QsG3jsKjTkbR7Mt4GgvAjS7yscHx6T8TnpJY2i13YrGqdI+KdAuqNVQiSS/0l6DkivVriRJYC9WCo0Xs6XDk3LEVADtydZFPV6kPPU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 1, 2023 at 9:29 AM Julia Lawall wrote: > > > > ---------- Forwarded message ---------- > Date: Wed, 1 Feb 2023 23:18:21 +0800 > From: kernel test robot > To: oe-kbuild@lists.linux.dev > Cc: lkp@intel.com, Julia Lawall > Subject: [linux-next:master 8679/9815] drivers/of/platform.c:570:2-23: WARNING: > Function "for_each_node_by_type" should have of_node_put() before break > around line 575. > > BCC: lkp@intel.com > CC: oe-kbuild-all@lists.linux.dev > CC: Linux Memory Management List > TO: Michal Suchanek > CC: Rob Herring > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 66eee64b235411d512bed4d672c2d00683239daf > commit: 2b54c9b44c7e7ac4d6b2e67a10db591e227c9c07 [8679/9815] of: Make of framebuffer devices unique > :::::: branch date: 11 hours ago > :::::: commit date: 2 days ago > config: microblaze-randconfig-c043-20230129 (https://download.01.org/0day-ci/archive/20230201/202302012320.Rl6PHBdQ-lkp@intel.com/config) > compiler: microblaze-linux-gcc (GCC) 12.1.0 > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot > | Reported-by: Julia Lawall > > cocci warnings: (new ones prefixed by >>) > drivers/of/platform.c:557:2-23: WARNING: Function "for_each_node_by_type" should have of_node_put() before return around line 563. > drivers/of/platform.c:557:2-23: WARNING: Function "for_each_node_by_type" should have of_node_put() before return around line 566. > >> drivers/of/platform.c:570:2-23: WARNING: Function "for_each_node_by_type" should have of_node_put() before break around line 575. I've reworked the commit to avoid all these. Thanks. Rob