From: Rob Herring <robh@kernel.org>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Michal Suchanek <msuchanek@suse.de>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [linux-next:master 8679/9815] drivers/of/platform.c:570:2-23: WARNING: Function "for_each_node_by_type" should have of_node_put() before break around line 575. (fwd)
Date: Wed, 1 Feb 2023 10:13:40 -0600 [thread overview]
Message-ID: <CAL_JsqKBU7Barg+Ve01=AUZd0SrAkJT0i8QT0_kvKfo3Q3Wz-g@mail.gmail.com> (raw)
In-Reply-To: <74a7f841-aef7-7748-725a-598ff8e4e5ea@inria.fr>
On Wed, Feb 1, 2023 at 9:29 AM Julia Lawall <julia.lawall@inria.fr> wrote:
>
>
>
> ---------- Forwarded message ----------
> Date: Wed, 1 Feb 2023 23:18:21 +0800
> From: kernel test robot <lkp@intel.com>
> To: oe-kbuild@lists.linux.dev
> Cc: lkp@intel.com, Julia Lawall <julia.lawall@inria.fr>
> Subject: [linux-next:master 8679/9815] drivers/of/platform.c:570:2-23: WARNING:
> Function "for_each_node_by_type" should have of_node_put() before break
> around line 575.
>
> BCC: lkp@intel.com
> CC: oe-kbuild-all@lists.linux.dev
> CC: Linux Memory Management List <linux-mm@kvack.org>
> TO: Michal Suchanek <msuchanek@suse.de>
> CC: Rob Herring <robh@kernel.org>
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 66eee64b235411d512bed4d672c2d00683239daf
> commit: 2b54c9b44c7e7ac4d6b2e67a10db591e227c9c07 [8679/9815] of: Make of framebuffer devices unique
> :::::: branch date: 11 hours ago
> :::::: commit date: 2 days ago
> config: microblaze-randconfig-c043-20230129 (https://download.01.org/0day-ci/archive/20230201/202302012320.Rl6PHBdQ-lkp@intel.com/config)
> compiler: microblaze-linux-gcc (GCC) 12.1.0
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Reported-by: Julia Lawall <julia.lawall@lip6.fr>
>
> cocci warnings: (new ones prefixed by >>)
> drivers/of/platform.c:557:2-23: WARNING: Function "for_each_node_by_type" should have of_node_put() before return around line 563.
> drivers/of/platform.c:557:2-23: WARNING: Function "for_each_node_by_type" should have of_node_put() before return around line 566.
> >> drivers/of/platform.c:570:2-23: WARNING: Function "for_each_node_by_type" should have of_node_put() before break around line 575.
I've reworked the commit to avoid all these. Thanks.
Rob
prev parent reply other threads:[~2023-02-01 16:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 15:27 Julia Lawall
2023-02-01 16:13 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqKBU7Barg+Ve01=AUZd0SrAkJT0i8QT0_kvKfo3Q3Wz-g@mail.gmail.com' \
--to=robh@kernel.org \
--cc=julia.lawall@inria.fr \
--cc=linux-mm@kvack.org \
--cc=msuchanek@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox