From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2DC0C77B61 for ; Mon, 10 Apr 2023 12:52:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFB6D280015; Mon, 10 Apr 2023 08:52:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DABC3280002; Mon, 10 Apr 2023 08:52:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4D41280015; Mon, 10 Apr 2023 08:52:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B1BBC280002 for ; Mon, 10 Apr 2023 08:52:53 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 834081602AF for ; Mon, 10 Apr 2023 12:52:53 +0000 (UTC) X-FDA: 80665471026.15.3BF2EBB Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id 80FDAC0015 for ; Mon, 10 Apr 2023 12:52:51 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FOc+1DqD; spf=pass (imf28.hostedemail.com: domain of robh+dt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=robh+dt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681131171; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hITquYcyTNb+hxNxWhMcQ11HWPPs8vP6VlUQ1svPu48=; b=zg4wqANMpgQBtBG04zRaJV34/x8DUWmSfc+3C57lvuL2SFR9pyybRcWppcuoH6ZDI0pwFw pm0kkfGVyUMjVUeos/ZlOTtZK6ijXWKQFXmtWM1c2XCnIT8BDB/5xFSlN6fuzgdgfTVaCx TH8Hn+np6A4IxjDa/DOK+oH15vnD6Sc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FOc+1DqD; spf=pass (imf28.hostedemail.com: domain of robh+dt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=robh+dt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681131171; a=rsa-sha256; cv=none; b=IFlDOZpbuiz4vSp6K3NwMRMNDAqHn3ojPwUqDTV+YNaLse1oIw1u47WuugRugFUwU+V0z3 QaxouXtU3Kylzl9GPESlZKdcwlqXWG87E/0nRFh9HXMk0bsjLDSrdh6dPqofPEvAjw+Qs7 WGMlx0rVyga+fBWp58f8rtDxnqpFW/c= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 628E560EA1 for ; Mon, 10 Apr 2023 12:52:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5994CC4339C for ; Mon, 10 Apr 2023 12:52:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681131169; bh=qk6WhIKn/+ELvEp+vyHHVRr7i+l4sUrOaHlfuQKbTD4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=FOc+1DqDaxlZ1pnaeB70DndeLACDRYjTX/jsFCkl5+TGS+We+sbE5zBHfIxbnkSF8 ZzPEIhHMVgWtlVXwzVdA0PeKIKSWB1TpjFEeKODs5uRQNcNsX8FbKFkFBF2r5hthn/ x15WbbFlfbzCt1OzMD9iZ5Myx2pej8D+8dl6OscBOggH3xxX8bjeGdir59CxO1Fq+V yUhh91NuynM9VBJ6OKQgnDvhH1szftwWapx8yIFYcEZtGHKaRgQjEDGsdD/+p0nff+ xM7/TY/h+cwNQtLA6R3QjsFB7MOTWEiL1mwR2rR5f6VcngBtZS8spmXh/qHqmz876v XZOz46hqTbGMw== Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-5491fa028adso420718707b3.10 for ; Mon, 10 Apr 2023 05:52:49 -0700 (PDT) X-Gm-Message-State: AAQBX9dE2QydrpkQX7hqMbmN68tftYwC3YTXXqZQWCsEdZel2tmyi8bl hgqc35p6qabDa/0+j4c8+X2VXszAlx/ea9TFUA== X-Google-Smtp-Source: AKy350aDRyQMV5T6mSbrLN2KN/1UzLpgACW1vknvF/Q03DFMH0R0/3LmWFu9WLLcHlBzT9xv1sRTcG7uq0fWVFnDrNk= X-Received: by 2002:a81:ad05:0:b0:545:ed8e:f4f6 with SMTP id l5-20020a81ad05000000b00545ed8ef4f6mr5632727ywh.5.1681131168306; Mon, 10 Apr 2023 05:52:48 -0700 (PDT) MIME-Version: 1.0 References: <20230410120017.41664-1-tanure@linux.com> <20230410120017.41664-2-tanure@linux.com> In-Reply-To: <20230410120017.41664-2-tanure@linux.com> From: Rob Herring Date: Mon, 10 Apr 2023 07:52:36 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/1] of: fdt: Scan /memreserve/ last To: Lucas Tanure Cc: Frank Rowand , Mike Rapoport , Andrew Morton , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, jbrunet@baylibre.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, martin.blumenstingl@googlemail.com, narmstrong@baylibre.com, stefan@agner.ch Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 80FDAC0015 X-Rspam-User: X-Stat-Signature: peyb4bkhmhiu5yx6yxme96ci71begn95 X-HE-Tag: 1681131171-466456 X-HE-Meta: U2FsdGVkX1+fMvLpW9BqBv49Hmr5noj/dvCm0pP5K7eq6ORHrwHaZa4FVQqg0PcxFlRgsGJknRFgRYH/7/lGfV5LFfTBIA80y3HwTkLpHyirHI/9iqqh/WqowEOW8Ng2hT7KDi94nzYPsCxd5OIURvS+HZC/gjWcGM7zlk+oIWg7Tf3fOLYlYLpn6NEgRhmeZbWjGlJw6tkyO9T4ptGhxntazWOj4/Je0QWb1WBbXz4ovwUTfnHytJZdnIzgC6SgtbuMyypZREsz8KlW08JenqWeKwuqrxfbHYLHb7K9b1qx/WG8dRgouDwaXPoanGJsMJNj4z0kSHlAtGyhw3eQTOA/wZZVf6km6CWfocFQ2EA/wJF6xClFR9eDm3nUV4Iv0qNWHyNzW26BueLcFNwfl1KD2w95LHvRooTQSPZYQmKbN6G1JTzrePALE0zrr1txSFxsiBBtiSer6eKTf+eaaIFcSX5yWF7VjpoN48IVv5r+w9us+6YmISChAr26i6NlNQW1+6FvtEsHzb7phn9gsq0f60ctOF4A6448nkvavCFtBPjjFARoi3GgfSnWga4PU8HwKy8ttFMiXtuN5Lcp0koJ4RwY5a6hdFkoF0Ul6y7hgNE/P3MMnjDTePB71hPM3Hl/74PIAxRX5DKcaLj0DYKzQ/WcOAoyb9eorOiR6h9EIG80p2JixD74ga1dPwWasNcpkwXJZmLzWI1HkTTgSUMr/vm0jipLgGbG8RXM1oshmSziNz2xl4pqLIhknxnwBH0XFh0TN9iVbfC4t/zXUQlD4We3CPTTgT7/C+dsNNdtVatduifx6/3E1kC+BbLNbSindfeAUSc+zzUxB+eli2cqAa3aSTZj0rVCbmr2xZxj2BNNLgzSZu0Kr7RYeWO9wFj+tGQ8dPP9RjuJeihfpH0j2thN6Usw+9lhC16NtydHolKXwVfi+Ki74Kqs7hu1EyA0+pc+cazCfh0aFK+ eFv+Rf93 0ggRMXLeAyDiftAOa/WJp/EPdwdABpnPKB3P7WA56A1oaA8pX012GOig8VXKH/h1Ej8i5dm7Rjg+Z+00Wnaf0Ft1W2reMpBx/CETUukb+CmhsPRid5/2hW7p4X1Q3DkT154BlmTo4jAZ6VETXyu0kaxKfhaURsiiYiIQuDEPJ1x7Z66RROaZdqH7ufkLJbotiopYKFaB+h9FNqXH9raIu3BvI6NgFTARYoj1BPcwf0BjX76qHOj83boJwFGtTLr62hPwtB7XQ7ddpcmW4g78quRTPGvqL5h5nR8FuGqrcZtBx1lw/GhS6e4QJqypwx/oAQpOgIwkHffVFOlfRAGqPEDqElmzejMNZmFn5kSvC+MXjsaIZnhO61L1qzDYO2PLmlcbpIIInO8sgV7msnu/WWpdM57+WnjoPnm0P/oFmFrlTWyGUgy4EZZf3BB/9xe/hMA6Z7MRUty5b+23KV91OhFUXNJf4Fn4jTd1BygooP9848ygA8rHrCSAM5w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 10, 2023 at 7:00=E2=80=AFAM Lucas Tanure wro= te: > > Change the order of scanning /memreserve/ and /reserved-memory node. > /reserved-memory node should go first, as it has a more updated > description of the memory regions and it can apply flags, like nomap. > Also, /memreserve/ should avoid reserving regions described in > /reserved-memory node. Like I said on v1, I think doing this has a high chance of causing regressions on other platforms. It should probably not go to stable for some time after a kernel release. > Signed-off-by: Lucas Tanure > --- > drivers/of/fdt.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c > index d1a68b6d03b3..26e608d8025d 100644 > --- a/drivers/of/fdt.c > +++ b/drivers/of/fdt.c > @@ -635,16 +635,21 @@ void __init early_init_fdt_scan_reserved_mem(void) > if (!initial_boot_params) > return; > > + fdt_scan_reserved_mem(); > + fdt_reserve_elfcorehdr(); > + > /* Process header /memreserve/ fields */ > for (n =3D 0; ; n++) { > fdt_get_mem_rsv(initial_boot_params, n, &base, &size); > if (!size) > break; > + if (memblock_overlaps_region(&memblock.memory, base, size= ) && > + memblock_is_region_reserved(base, size)) Just to make sure, a partial overlap will still get reserved? > + break; Shouldn't we continue to the next entry rather than stopping. > + > memblock_reserve(base, size); > } > > - fdt_scan_reserved_mem(); > - fdt_reserve_elfcorehdr(); > fdt_init_reserved_mem(); > } > > -- > 2.40.0 >