From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by kanga.kvack.org (Postfix) with ESMTP id 08A796B0031 for ; Fri, 13 Dec 2013 15:56:52 -0500 (EST) Received: by mail-wi0-f173.google.com with SMTP id hn9so1672299wib.6 for ; Fri, 13 Dec 2013 12:56:52 -0800 (PST) Received: from mail-we0-x231.google.com (mail-we0-x231.google.com [2a00:1450:400c:c03::231]) by mx.google.com with ESMTPS id g4si180419wiz.47.2013.12.13.12.56.51 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 13 Dec 2013 12:56:51 -0800 (PST) Received: by mail-we0-f177.google.com with SMTP id u56so2391763wes.22 for ; Fri, 13 Dec 2013 12:56:51 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20131122172147.GA6477@cerebellum.variantweb.net> References: <1384965522-5788-1-git-send-email-ddstreet@ieee.org> <20131122172147.GA6477@cerebellum.variantweb.net> From: Dan Streetman Date: Fri, 13 Dec 2013 15:56:31 -0500 Message-ID: Subject: Re: [PATCH] mm/zswap: change params from hidden to ro Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Seth Jennings , Andrew Morton , Greg Kroah-Hartman Cc: linux-mm@kvack.org, linux-kernel , Bob Liu , Minchan Kim , Weijie Yang On Fri, Nov 22, 2013 at 12:21 PM, Seth Jennings wrote: > On Wed, Nov 20, 2013 at 11:38:42AM -0500, Dan Streetman wrote: >> The "compressor" and "enabled" params are currently hidden, >> this changes them to read-only, so userspace can tell if >> zswap is enabled or not and see what compressor is in use. > > Reasonable to me. > > Acked-by: Seth Jennings Ping to see if this patch could get picked up. > >> >> Signed-off-by: Dan Streetman >> --- >> mm/zswap.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/mm/zswap.c b/mm/zswap.c >> index d93510c..36b268b 100644 >> --- a/mm/zswap.c >> +++ b/mm/zswap.c >> @@ -77,12 +77,12 @@ static u64 zswap_duplicate_entry; >> **********************************/ >> /* Enable/disable zswap (disabled by default, fixed at boot for now) */ >> static bool zswap_enabled __read_mostly; >> -module_param_named(enabled, zswap_enabled, bool, 0); >> +module_param_named(enabled, zswap_enabled, bool, 0444); >> >> /* Compressor to be used by zswap (fixed at boot for now) */ >> #define ZSWAP_COMPRESSOR_DEFAULT "lzo" >> static char *zswap_compressor = ZSWAP_COMPRESSOR_DEFAULT; >> -module_param_named(compressor, zswap_compressor, charp, 0); >> +module_param_named(compressor, zswap_compressor, charp, 0444); >> >> /* The maximum percentage of memory that the compressed pool can occupy */ >> static unsigned int zswap_max_pool_percent = 20; >> -- >> 1.8.3.1 >> >> -- >> To unsubscribe, send a message with 'unsubscribe linux-mm' in >> the body to majordomo@kvack.org. For more info on Linux MM, >> see: http://www.linux-mm.org/ . >> Don't email: email@kvack.org -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org