From: Dan Streetman <ddstreet@ieee.org>
To: Seth Jennings <sjennings@variantweb.net>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-mm@kvack.org, linux-kernel <linux-kernel@vger.kernel.org>,
Bob Liu <bob.liu@oracle.com>, Minchan Kim <minchan@kernel.org>,
Weijie Yang <weijie.yang@samsung.com>
Subject: Re: [PATCH] mm/zswap: change params from hidden to ro
Date: Fri, 13 Dec 2013 15:56:31 -0500 [thread overview]
Message-ID: <CALZtONBo-6_BKKT62BTzH3qyD4A+bxj781yGPa00fuFQ4TYdBQ@mail.gmail.com> (raw)
In-Reply-To: <20131122172147.GA6477@cerebellum.variantweb.net>
On Fri, Nov 22, 2013 at 12:21 PM, Seth Jennings
<sjennings@variantweb.net> wrote:
> On Wed, Nov 20, 2013 at 11:38:42AM -0500, Dan Streetman wrote:
>> The "compressor" and "enabled" params are currently hidden,
>> this changes them to read-only, so userspace can tell if
>> zswap is enabled or not and see what compressor is in use.
>
> Reasonable to me.
>
> Acked-by: Seth Jennings <sjennings@variantweb.net>
Ping to see if this patch could get picked up.
>
>>
>> Signed-off-by: Dan Streetman <ddstreet@ieee.org>
>> ---
>> mm/zswap.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/mm/zswap.c b/mm/zswap.c
>> index d93510c..36b268b 100644
>> --- a/mm/zswap.c
>> +++ b/mm/zswap.c
>> @@ -77,12 +77,12 @@ static u64 zswap_duplicate_entry;
>> **********************************/
>> /* Enable/disable zswap (disabled by default, fixed at boot for now) */
>> static bool zswap_enabled __read_mostly;
>> -module_param_named(enabled, zswap_enabled, bool, 0);
>> +module_param_named(enabled, zswap_enabled, bool, 0444);
>>
>> /* Compressor to be used by zswap (fixed at boot for now) */
>> #define ZSWAP_COMPRESSOR_DEFAULT "lzo"
>> static char *zswap_compressor = ZSWAP_COMPRESSOR_DEFAULT;
>> -module_param_named(compressor, zswap_compressor, charp, 0);
>> +module_param_named(compressor, zswap_compressor, charp, 0444);
>>
>> /* The maximum percentage of memory that the compressed pool can occupy */
>> static unsigned int zswap_max_pool_percent = 20;
>> --
>> 1.8.3.1
>>
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to majordomo@kvack.org. For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-12-13 20:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 16:38 Dan Streetman
2013-11-20 17:33 ` Vladimir Murzin
2013-11-20 17:52 ` Dan Streetman
2013-11-21 3:12 ` Weijie Yang
2013-11-21 22:36 ` Dan Streetman
2013-11-22 7:38 ` Vladimir Murzin
2013-11-22 17:18 ` Dan Streetman
2013-11-24 14:15 ` Vladimir Murzin
2013-11-22 17:21 ` Seth Jennings
2013-12-13 20:56 ` Dan Streetman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALZtONBo-6_BKKT62BTzH3qyD4A+bxj781yGPa00fuFQ4TYdBQ@mail.gmail.com \
--to=ddstreet@ieee.org \
--cc=akpm@linux-foundation.org \
--cc=bob.liu@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=sjennings@variantweb.net \
--cc=weijie.yang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox