From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f172.google.com (mail-we0-f172.google.com [74.125.82.172]) by kanga.kvack.org (Postfix) with ESMTP id 933826B003B for ; Mon, 14 Jul 2014 14:11:04 -0400 (EDT) Received: by mail-we0-f172.google.com with SMTP id x48so2734228wes.17 for ; Mon, 14 Jul 2014 11:11:04 -0700 (PDT) Received: from mail-wi0-x234.google.com (mail-wi0-x234.google.com [2a00:1450:400c:c05::234]) by mx.google.com with ESMTPS id cn2si5905788wib.24.2014.07.14.11.11.02 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 14 Jul 2014 11:11:03 -0700 (PDT) Received: by mail-wi0-f180.google.com with SMTP id n3so3037968wiv.1 for ; Mon, 14 Jul 2014 11:11:02 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1404337536-11037-1-git-send-email-ddstreet@ieee.org> References: <1401747586-11861-1-git-send-email-ddstreet@ieee.org> <1404337536-11037-1-git-send-email-ddstreet@ieee.org> From: Dan Streetman Date: Mon, 14 Jul 2014 14:10:42 -0400 Message-ID: Subject: Re: [PATCHv5 0/4] mm/zpool: add common api for zswap to use zbud/zsmalloc Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Seth Jennings , Andrew Morton Cc: Dan Streetman , Bob Liu , Nitin Gupta , Hugh Dickins , Minchan Kim , Weijie Yang , Mel Gorman , Rik van Riel , Johannes Weiner , Sergey Senozhatsky , Linux-MM , linux-kernel Andrew, any thoughts on this latest version of the patch set? Let me know if I missed anything or you have any other suggestions. Seth, did you get a chance to review this and/or test it out? On Wed, Jul 2, 2014 at 5:45 PM, Dan Streetman wrote: > In order to allow zswap users to choose between zbud and zsmalloc for > the compressed storage pool, this patch set adds a new api "zpool" that > provides an interface to both zbud and zsmalloc. This does not include > implementing shrinking in zsmalloc, which will be sent separately. > > I believe Seth originally was using zsmalloc for swap, but there were > concerns about how significant the impact of shrinking zsmalloc would > be when zswap had to start reclaiming pages. That still may be an > issue, but this at least allows users to choose themselves whether > they want a lower-density or higher-density compressed storage medium. > At least for situations where zswap reclaim is never or rarely reached, > it probably makes sense to use the higher density of zsmalloc. > > Note this patch set does not change zram to use zpool, although that > change should be possible as well. > > --- > Changes since v4 : https://lkml.org/lkml/2014/6/2/711 > -omit first patch, that removed gfp_t param from zpool_malloc() > -move function doc from zpool.h to zpool.c > -move module usage refcounting into patch that adds zpool > -add extra refcounting to prevent driver unregister if in use > -add doc clarifying concurrency usage > -make zbud/zsmalloc zpool functions static > -typo corrections > > Changes since v3 : https://lkml.org/lkml/2014/5/24/130 > -In zpool_shrink() use # pages instead of # bytes > -Add reclaimed param to zpool_shrink() to indicate to caller > # pages actually reclaimed > -move module usage counting to zpool, from zbud/zsmalloc > -update zbud_zpool_shrink() to call zbud_reclaim_page() in a > loop until requested # pages have been reclaimed (or error) > > Changes since v2 : https://lkml.org/lkml/2014/5/7/927 > -Change zpool to use driver registration instead of hardcoding > implementations > -Add module use counting in zbud/zsmalloc > > Changes since v1 https://lkml.org/lkml/2014/4/19/97 > -remove zsmalloc shrinking > -change zbud size param type from unsigned int to size_t > -remove zpool fallback creation > -zswap manually falls back to zbud if specified type fails > > > Dan Streetman (4): > mm/zbud: change zbud_alloc size type to size_t > mm/zpool: implement common zpool api to zbud/zsmalloc > mm/zpool: zbud/zsmalloc implement zpool > mm/zpool: update zswap to use zpool > > include/linux/zbud.h | 2 +- > include/linux/zpool.h | 106 +++++++++++++++ > mm/Kconfig | 43 +++--- > mm/Makefile | 1 + > mm/zbud.c | 98 +++++++++++++- > mm/zpool.c | 364 ++++++++++++++++++++++++++++++++++++++++++++++++++ > mm/zsmalloc.c | 84 ++++++++++++ > mm/zswap.c | 75 ++++++----- > 8 files changed, 722 insertions(+), 51 deletions(-) > create mode 100644 include/linux/zpool.h > create mode 100644 mm/zpool.c > > -- > 1.8.3.1 > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org