Re: [linux-next:master 6299/6518] mm/zswap.c:759:1: warning: '__zswap_param_set' uses dynamic stack allocation

[Dan Streetman <ddstreet@ieee.org>]

On Thu, Aug 6, 2015 at 9:59 PM, kbuild test robot
<fengguang.wu@intel.com> wrote:
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   c6b169e6ffb962068153bd92b0c4ecbd731a122f
> commit: e2e60954eae9929a982d12b6ff24a91b37822f34 [6299/6518] zswap: change zpool/compressor at runtime
> config: s390-allyesconfig (attached as .config)
> reproduce:
>   wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>   chmod +x ~/bin/make.cross
>   git checkout e2e60954eae9929a982d12b6ff24a91b37822f34
>   # save the attached .config to linux build tree
>   make.cross ARCH=s390
>
> All warnings (new ones prefixed by >>):
>
>    mm/zswap.c: In function '__zswap_param_set':
>>> mm/zswap.c:759:1: warning: '__zswap_param_set' uses dynamic stack allocation

ugh, ok.  It really should be fine, but I'll send a patch to use a
static-sized array instead; we know it's never more than 64 bytes.


>     }
>     ^
>
> vim +/__zswap_param_set +759 mm/zswap.c
>
>    743                   * list; if it's new (and empty) then it'll be removed and
>    744                   * destroyed by the put after we drop the lock
>    745                   */
>    746                  list_add_tail_rcu(&pool->list, &zswap_pools);
>    747                  put_pool = pool;
>    748          }
>    749
>    750          spin_unlock(&zswap_pools_lock);
>    751
>    752          /* drop the ref from either the old current pool,
>    753           * or the new pool we failed to add
>    754           */
>    755          if (put_pool)
>    756                  zswap_pool_put(put_pool);
>    757
>    758          return ret;
>  > 759  }
>    760
>    761  static int zswap_compressor_param_set(const char *val,
>    762                                        const struct kernel_param *kp)
>    763  {
>    764          return __zswap_param_set(val, kp, zswap_zpool_type, NULL);
>    765  }
>    766
>    767  static int zswap_zpool_param_set(const char *val,
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>