From: Dan Streetman <ddstreet@ieee.org>
To: sjennings@variantweb.net
Cc: linux-mm@kvack.org, linux-kernel <linux-kernel@vger.kernel.org>,
minchan@kernel.org, bob.liu@oracle.com, weijie.yang@samsung.com,
k.kozlowski@samsung.com
Subject: mm/zswap: change to writethrough
Date: Mon, 11 Nov 2013 14:12:12 -0500 [thread overview]
Message-ID: <CALZtONAxsYxLizARV3Aam_n7534g5gh_FFkTz6jb-0Q9gThuBQ@mail.gmail.com> (raw)
Seth, have you (or anyone else) considered making zswap a writethrough
cache instead of writeback? I think that it would significantly help
the case where zswap fills up and starts writing back its oldest pages
to disc - all the decompression work would be avoided since zswap
could just evict old pages and forget about them, and it seems likely
that when zswap is full that's probably the worst time to add extra
work/delay, while adding extra disc IO (presumably using dma) before
zswap is full doesn't seem to me like it would have much impact,
except in the case where zswap isn't full but there is so little free
memory that new allocs are waiting on swap-out.
Besides the additional disc IO that obviously comes with making zswap
writethrough (additional only before zswap fills up), are there any
other disadvantages? Is it a common situation for there to be no
memory left and get_free_page actively waiting on swap-out, but before
zswap fills up?
Making it writethrough also could open up other possible improvements,
like making the compression and storage of new swap-out pages async,
so the compression doesn't delay the write out to disc.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2013-11-11 19:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 19:12 Dan Streetman [this message]
2013-11-12 9:11 ` Bob Liu
2013-11-12 14:24 ` Dan Streetman
2013-11-13 15:40 ` Seth Jennings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALZtONAxsYxLizARV3Aam_n7534g5gh_FFkTz6jb-0Q9gThuBQ@mail.gmail.com \
--to=ddstreet@ieee.org \
--cc=bob.liu@oracle.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=sjennings@variantweb.net \
--cc=weijie.yang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox