linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dan Streetman <ddstreet@ieee.org>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] zpool: Delete an error message for a failed memory allocation in zpool_create_pool()
Date: Wed, 16 Aug 2017 07:19:12 -0400	[thread overview]
Message-ID: <CALZtONACUD_EjnBh71accGgLZ+aH44pORv7aBpVDYPgZsBgyow@mail.gmail.com> (raw)
In-Reply-To: <81cdf225-ebaa-19dc-30d8-80ec6cfab6cd@users.sourceforge.net>

On Mon, Aug 14, 2017 at 7:15 AM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 14 Aug 2017 12:57:16 +0200
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Acked-by: Dan Streetman <ddstreet@ieee.org>

> ---
>  mm/zpool.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/mm/zpool.c b/mm/zpool.c
> index fd3ff719c32c..fe1943f7d844 100644
> --- a/mm/zpool.c
> +++ b/mm/zpool.c
> @@ -172,7 +172,6 @@ struct zpool *zpool_create_pool(const char *type, const char *name, gfp_t gfp,
>
>         zpool = kmalloc(sizeof(*zpool), gfp);
>         if (!zpool) {
> -               pr_err("couldn't create zpool - out of memory\n");
>                 zpool_put_driver(driver);
>                 return NULL;
>         }
> --
> 2.14.0
>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-08-16 11:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-14 11:14 [PATCH 0/2] zpool: Adjustments for zpool_create_pool() SF Markus Elfring
2017-08-14 11:15 ` [PATCH 1/2] zpool: Delete an error message for a failed memory allocation in zpool_create_pool() SF Markus Elfring
2017-08-16 11:19   ` Dan Streetman [this message]
2017-08-14 11:16 ` [PATCH 2/2] zpool: Use common error handling code " SF Markus Elfring
2017-08-16 11:19   ` Dan Streetman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALZtONACUD_EjnBh71accGgLZ+aH44pORv7aBpVDYPgZsBgyow@mail.gmail.com \
    --to=ddstreet@ieee.org \
    --cc=elfring@users.sourceforge.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox