From: Dan Streetman <ddstreet@ieee.org>
To: Vladimir Murzin <murzin.v@gmail.com>
Cc: linux-mm@kvack.org, Seth Jennings <sjennings@variantweb.net>,
linux-kernel <linux-kernel@vger.kernel.org>,
Bob Liu <bob.liu@oracle.com>, Minchan Kim <minchan@kernel.org>,
Weijie Yang <weijie.yang@samsung.com>
Subject: Re: [PATCH] mm/zswap: change params from hidden to ro
Date: Wed, 20 Nov 2013 12:52:47 -0500 [thread overview]
Message-ID: <CALZtONA81=R4abFMpMMtDZKQe0s-8+JxvEfZO3NEZ910VwRDmw@mail.gmail.com> (raw)
In-Reply-To: <20131120173347.GA2369@hp530>
On Wed, Nov 20, 2013 at 12:33 PM, Vladimir Murzin <murzin.v@gmail.com> wrote:
> Hi Dan!
>
> On Wed, Nov 20, 2013 at 11:38:42AM -0500, Dan Streetman wrote:
>> The "compressor" and "enabled" params are currently hidden,
>> this changes them to read-only, so userspace can tell if
>> zswap is enabled or not and see what compressor is in use.
>
> Could you elaborate more why this pice of information is necessary for
> userspace?
For anyone interested in zswap, it's handy to be able to tell if it's
enabled or not ;-) Technically people can check to see if the zswap
debug files are in /sys/kernel/debug/zswap, but I think the actual
"enabled" param is more obvious. And the compressor param is really
the only way anyone from userspace can see what compressor's being
used; that's helpful to know for anyone that might want to be using a
non-default compressor.
And of course, eventually we'll want to make the params writable, so
the compressor can be changed dynamically, and zswap can be enabled or
disabled dynamically (or at least enabled after boot).
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-11-20 17:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 16:38 Dan Streetman
2013-11-20 17:33 ` Vladimir Murzin
2013-11-20 17:52 ` Dan Streetman [this message]
2013-11-21 3:12 ` Weijie Yang
2013-11-21 22:36 ` Dan Streetman
2013-11-22 7:38 ` Vladimir Murzin
2013-11-22 17:18 ` Dan Streetman
2013-11-24 14:15 ` Vladimir Murzin
2013-11-22 17:21 ` Seth Jennings
2013-12-13 20:56 ` Dan Streetman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALZtONA81=R4abFMpMMtDZKQe0s-8+JxvEfZO3NEZ910VwRDmw@mail.gmail.com' \
--to=ddstreet@ieee.org \
--cc=bob.liu@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=murzin.v@gmail.com \
--cc=sjennings@variantweb.net \
--cc=weijie.yang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox