From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f54.google.com (mail-wg0-f54.google.com [74.125.82.54]) by kanga.kvack.org (Postfix) with ESMTP id 4815B6B0038 for ; Fri, 22 Nov 2013 12:18:22 -0500 (EST) Received: by mail-wg0-f54.google.com with SMTP id n12so371686wgh.21 for ; Fri, 22 Nov 2013 09:18:21 -0800 (PST) Received: from mail-we0-x22f.google.com (mail-we0-x22f.google.com [2a00:1450:400c:c03::22f]) by mx.google.com with ESMTPS id de7si13379376wjc.82.2013.11.22.09.18.21 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 22 Nov 2013 09:18:21 -0800 (PST) Received: by mail-we0-f175.google.com with SMTP id p61so1455886wes.34 for ; Fri, 22 Nov 2013 09:18:21 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20131122073851.GB1853@hp530> References: <1384965522-5788-1-git-send-email-ddstreet@ieee.org> <20131120173347.GA2369@hp530> <20131122073851.GB1853@hp530> From: Dan Streetman Date: Fri, 22 Nov 2013 12:18:01 -0500 Message-ID: Subject: Re: [PATCH] mm/zswap: change params from hidden to ro Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Vladimir Murzin Cc: linux-mm@kvack.org, Seth Jennings , linux-kernel , Bob Liu , Minchan Kim , Weijie Yang On Fri, Nov 22, 2013 at 2:38 AM, Vladimir Murzin wrote: > On Wed, Nov 20, 2013 at 12:52:47PM -0500, Dan Streetman wrote: > On Wed, Nov > 20, 2013 at 12:33 PM, Vladimir Murzin wrote: > > Hi Dan! >> > >> > On Wed, Nov 20, 2013 at 11:38:42AM -0500, Dan Streetman wrote: >> >> The "compressor" and "enabled" params are currently hidden, >> >> this changes them to read-only, so userspace can tell if >> >> zswap is enabled or not and see what compressor is in use. >> > >> > Could you elaborate more why this pice of information is necessary for >> > userspace? >> >> For anyone interested in zswap, it's handy to be able to tell if it's >> enabled or not ;-) Technically people can check to see if the zswap >> debug files are in /sys/kernel/debug/zswap, but I think the actual >> "enabled" param is more obvious. And the compressor param is really >> the only way anyone from userspace can see what compressor's being >> used; that's helpful to know for anyone that might want to be using a >> non-default compressor. > > So, it is needed for user not userspace? I tend to think that users are smart > enough to check cmdline for that. Let's try a different way. Can you explain what the problem is with making these params user-readable? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org