linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Konstantin Khlebnikov <koct9i@gmail.com>
To: Konstantin Khlebnikov <koct9i@gmail.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Konstantin Khlebnikov <k.khlebnikov@samsung.com>,
	Andrey Ryabinin <ryabinin.a.a@gmail.com>,
	Rafael Aquini <aquini@redhat.com>,
	Stable <stable@vger.kernel.org>,
	Sasha Levin <sasha.levin@oracle.com>
Subject: Re: [PATCH v3 1/4] mm/balloon_compaction: redesign ballooned pages management
Date: Tue, 28 Oct 2014 23:56:15 +0400	[thread overview]
Message-ID: <CALYGNiOrNfxbCJggraxgiFOdvn3jki_751cpssi+p_eST0Wdgg@mail.gmail.com> (raw)
In-Reply-To: <20141028184719.GB29098@hydra.tuxags.com>

On Tue, Oct 28, 2014 at 9:47 PM, Matt Mullins <mmullins@mmlx.us> wrote:
> On Sat, Sep 27, 2014 at 11:15:16PM +0400, Konstantin Khlebnikov wrote:
>> This patch fixes all of them.
>
> It seems to have rendered virtio_balloon completely ineffective without
> CONFIG_COMPACTION and CONFIG_BALLOON_COMPACTION, even for the case that I'm
> expanding the memory available to my VM.

What do you mean by ineffective?

That it cannot handle fragmentation? I saw that without compaction
ballooning works even better:
it allocates pages without GFP_MOVABLE and buddy allocator returns
much less scattered pages.

>
> Was this intended?  Should Kconfig be updated so that VIRTIO_BALLOON depends on
> BALLOON_COMPACTION now?

Nope, this is independent feature.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2014-10-28 19:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-27 19:15 [PATCH v3 0/4] mm/balloon_compaction: fixes and cleanups Konstantin Khlebnikov
2014-09-27 19:15 ` [PATCH v3 1/4] mm/balloon_compaction: redesign ballooned pages management Konstantin Khlebnikov
2014-10-28 18:47   ` Matt Mullins
2014-10-28 19:56     ` Konstantin Khlebnikov [this message]
2014-10-28 20:23       ` Matt Mullins
2014-10-29 10:51         ` [PATCH] mm/balloon_compaction: fix deflation when compaction is disabled Konstantin Khlebnikov
2014-10-30  1:06           ` Matt Mullins
2014-09-27 19:15 ` [PATCH v3 2/4] mm/balloon_compaction: remove balloon mapping and flag AS_BALLOON_MAP Konstantin Khlebnikov
2014-09-27 19:15 ` [PATCH v3 3/4] mm/balloon_compaction: add vmstat counters and kpageflags bit Konstantin Khlebnikov
2014-09-27 19:15 ` [PATCH v3 4/4] selftests/vm/transhuge-stress: stress test for memory compaction Konstantin Khlebnikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALYGNiOrNfxbCJggraxgiFOdvn3jki_751cpssi+p_eST0Wdgg@mail.gmail.com \
    --to=koct9i@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=aquini@redhat.com \
    --cc=k.khlebnikov@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ryabinin.a.a@gmail.com \
    --cc=sasha.levin@oracle.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox