From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42527C5AD49 for ; Thu, 29 May 2025 12:31:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D43A76B0161; Thu, 29 May 2025 08:31:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF4946B0162; Thu, 29 May 2025 08:31:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE3276B0163; Thu, 29 May 2025 08:31:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9E34B6B0161 for ; Thu, 29 May 2025 08:31:14 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4303EE732C for ; Thu, 29 May 2025 12:31:14 +0000 (UTC) X-FDA: 83495880468.11.86BF4EF Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf10.hostedemail.com (Postfix) with ESMTP id 36FFAC0008 for ; Thu, 29 May 2025 12:31:11 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DsH4pkW6; spf=pass (imf10.hostedemail.com: domain of koct9i@gmail.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=koct9i@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748521872; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tq1cwOPaR4vKxoX32nv3/DyAYjBA3wRhSPzfXs5sjXU=; b=L2N0+v7Bm+tHfeI0c972lmtPmUoeXd1jJPW2H1m5d8yMoNKpMK+gtxx/TL7UBLqPzU+c6v 5bVMojuzdR4ra6D2egKf6dzAPPceU3Sydy0d42yiX9DUvCvalwsH85KV//VALrpWCGyT4R uUK0xQ2dc7Hgcx9nCpU67kAza2N5CkQ= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DsH4pkW6; spf=pass (imf10.hostedemail.com: domain of koct9i@gmail.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=koct9i@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748521872; a=rsa-sha256; cv=none; b=oEnBNP17wVvuPEbQ1OxvMllKmg7JZ2fjswN6AMEDluv16cpbzEV1jdhf2YlDUAoAw7n7uY XYy8L2riEi+wvbIHeLF25tjf2SrVKkNa3eZ9X3nAZdbB5/wG31eTrvVfUrdWo9q4MTtC7/ PfVt8bjk8Ee0wODFyiiWCND/RiN65eE= Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-3109f106867so948516a91.1 for ; Thu, 29 May 2025 05:31:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748521871; x=1749126671; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=tq1cwOPaR4vKxoX32nv3/DyAYjBA3wRhSPzfXs5sjXU=; b=DsH4pkW6rLJJ2/pmAC+uBOc0KIdPTKo12tvq/BjpWXI/xORDMD0gla28Q76Yttxq0b OxLtRNJ1aszph6mCJH8NEcj067GRIfASdbzMo6t2AbJw/p5tFbHPG0W40jdeQ4DNcKJF zNAgHcce9jz4Spw2r4Civ/gIbQ7g9zXrmnyDb46hJEl0KZrpGjGLgyV4VS5dIegzRNBl zFrj8qudqdhxQkOX+7SxJ7MSx3M/wiJmvVvvscOoq/S5NpZ7s/444icqKZgbmk5aqneQ OzEnGouWlrkLTgPep0Wlah9PXPP+/JpsWKCd2qd572E1/zYvI+qeWdaASGS+RlEyKQGx oagA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748521871; x=1749126671; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tq1cwOPaR4vKxoX32nv3/DyAYjBA3wRhSPzfXs5sjXU=; b=rrFrRNFZxgi1alKmP1vwazTjOPVaWEN8WCET7PGiYKp7sOdBI397BMNXb27FPWLVZd 0ICFyOY3GkynZSgJu/cQVRDa926xX9fFXRkNnu/JlcEc85/daccxITl9m6yx9jsRmh4D mHVXwgSjt8ZGhAHb7CmFrsBs1eMs9bpzg8BmnugVTgLeSaZLqbiYxwLePurpRTXgujkO A00Bwqb3JbMALcIDqdRnztcOXlyKtZ2nw0DCg3UQmu9QC3Pt3f3744yWaVlvLl2xr4lC tj+nY9+QzJtqpu4QEjmKkBgY1PU4Pw8TRfvARtScmKwr/ognpZdPUjW1O7Fjd+Zi+U5S 6lSg== X-Forwarded-Encrypted: i=1; AJvYcCWNU9ii/VwqK8YPOEWcZzQ+cyOJTrG7xNGkknpeT4qv9LA97t8TckI6SGlIaE+1o7+ThQayn8cM4A==@kvack.org X-Gm-Message-State: AOJu0YwtdxelZks1Mud32405mfNzDaE/n1sA1NvVfDbhASHacG28LD+U YWRtoHFpyG/vi/SVrvwe40AduTpkX3Hi+H6CDDZZbxUB1TrS7p6OqgAXBG5PS8rWNOb9XKaO7+v C/G2tJH1DOM8mpOPC6e9lYdtHTPuaOsc= X-Gm-Gg: ASbGnctkFH8ghlHAn52VGDpUpK3p3fKRr1q7S17bvi+ClqMBTQ6MQK6iX19z6z73ZEk Sf3uIH7dEesIgq8QGevjL4n7mIF2jznk4Pf0iB7SU64qxqk3/EicyRZdYGhZixja3uMdciV09Vp fjW9ZKGq4dEXAMid/07df/iMCqBYgEtmo3O1mPRVGjC3OM4xjR320NArE4NmwLU7Zwd4xys1DK2 0yF X-Google-Smtp-Source: AGHT+IGp4zLKOpGdYRvmDVdlnQvGHcsBhKQmRHDUVcglWg+1oqojMwVl/cOxeFOXeuqJpSpTyoxtX5MLpnOMxIiVSSs= X-Received: by 2002:a17:90b:2e83:b0:312:1516:5ef1 with SMTP id 98e67ed59e1d1-3121dc21454mr3407822a91.7.1748521870864; Thu, 29 May 2025 05:31:10 -0700 (PDT) MIME-Version: 1.0 References: <20250529103832.2937460-1-kirill.shutemov@linux.intel.com> <7ae9e9f9-80e7-4285-83f0-a0946d238243@suse.cz> In-Reply-To: From: Konstantin Khlebnikov Date: Thu, 29 May 2025 14:30:58 +0200 X-Gm-Features: AX0GCFuljSryuZeYsXkIUeJyWk2K7LZ8ro-jiJpu63bVcI17YSh4usFoQKWXwyE Message-ID: Subject: Re: [PATCH] mm: Fix vmstat after removing NR_BOUNCE To: "Kirill A. Shutemov" Cc: Vlastimil Babka , Andrew Morton , David Hildenbrand , lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hongyu Ning , stable@vger.kernel.org, Christoph Hellwig , Hannes Reinecke , Johannes Thumshirn , Jens Axboe Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Stat-Signature: 4bczdp446x96f8qiqxnuy7sqtfcmdyks X-Rspamd-Queue-Id: 36FFAC0008 X-Rspamd-Server: rspam11 X-HE-Tag: 1748521871-648889 X-HE-Meta: U2FsdGVkX1/CWP9zs6+QS9aM/PpQz2Sxes3/JTma5P+uSSnHdLg44nySW/sjjEwOIZ62mdp2TXnWUKdisv02JjgX4yzb/k9KNDOXpH+1XZ7D1YjD5pg1d2djiuGmWovrEGdvIDlU7qPbPs60FI/8xCnYAQPc386n+YtaUZHdbAzBg1yQBeLtekruQVG3loF123KYHW1RifX6N8S2QknGRaO0xiMgYgu+9dHhZuJaR4/ZVDcC/9vWhFKgtol36kC8NmqpvZhBoWrDoAvNLVW3gwtx4ajQ2LHsBwmbRHBM7MCySYiV3mr40ROzHFzPecNzOhOc0vIUGqS5HNhoeTezoiDnOcn7jv2hFtu2ewX/lk7ziwDdWpVR1RcCsTVF81ABZ5U9bEaVmvRwOyijpt2NKQCEMFB0p+rB/jFRdpSxxskgDe7iR01nagf4rK3/72ivvXYSDDfvUHqyz4BOpI6+Wy2tLpBWOg7XZu9ZCUGpDXE9E5p53ekRni76fs/L2VWsxJLHbobC/ux0EPPvsg+d31GGwGjlFA3O4GqBmzqVMXusxl1SsGfDZN7zOu4ljdt0svw3MVyBxaLT0lgIFbNHM/st1cuqhJ2T89gcZO4kN4mUrWn361mrP28mHs7TAl5q0HJwZKb1tIcMNCKWborWYGicOAuIcuLQfMffxILfdVOlhk01D9CrHacQxQBREBiPCqjm12sQQ8pbk1szT08fSWYMy38jxMwpk+GU7LJLDdFxojGg2GPjRlgfGgJI1YB+D8IfjIh/UThcIxo8UhAGZxj5MR/zI02n5s3NcB3YgeFFXvBfkCpkglHVQR3tan1zIjIFDXUafVDEguLzeCLeDpE+zx45RnrcJstbKMVG64nrUfrwMChYJbYB9+Mg1NcGR5WYxWQtS/o1qGPfw8fMEsuoD+9R4MSD9giCeNYxUQu9Wcymw7BUxbu7msaz/8ebvZvhjXWzuRpJyvVYa+d MGEM/j5L MfQ8Exf8xsGmMZl/msBFThfL/uAaUlHRsyIOEFh/ZQ2Wlz5ONS3Jdh9PBLHPEpG/AR5RaDzaASiKDdUK644yIwuPHwq2fpaQ9LHL0VYr/9QR5SkUctfWV5d2XlfBSWG/8s0KYPT4ZyqlFAGw97aJwdtQxR3uGXsEh3bnsyMS8NcvKLiNAUEascDttcUpKJNwjdtEIoZy76ijilWJZ4oIYuBcMON5OMhOtcS1XlaxLhyMUpuBjmseiIXPt/h/EhHyJ0j3JlqO8DoKTXuFxXbzc8ZeK7R8pL4nI+VitxDsTv8SMbA7dP4B+iEEOrIaM0a9Sb51z0L/cd9e3NGU/qlRNfxYuVLKJu5y1jIQvDEcWoRYmGCFq7fjbXQcfwNC/6Lpofgg6Mf39hCnUbHFwpzFo8qI+pKfOZ3kR3fiIbtN+ibv4NuWqYE23O0AlNr4SZtNUjjWuA/pxNiroqnwwnnL8qOVPSB+le6VeySJC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 29 May 2025 at 12:51, Kirill A. Shutemov wrote: > > On Thu, May 29, 2025 at 01:47:10PM +0300, Kirill A. Shutemov wrote: > > On Thu, May 29, 2025 at 12:40:21PM +0200, Vlastimil Babka wrote: > > > On 5/29/25 12:38, Kirill A. Shutemov wrote: > > > > Hongyu noticed that the nr_unaccepted counter kept growing even in the > > > > absence of unaccepted memory on the machine. > > > > > > > > This happens due to a commit that removed NR_BOUNCE: it removed the > > > > counter from the enum zone_stat_item, but left it in the vmstat_text > > > > array. > > > > > > > > As a result, all counters below nr_bounce in /proc/vmstat are > > > > shifted by one line, causing the numa_hit counter to be labeled as > > > > nr_unaccepted. > > > > > > > > To fix this issue, remove nr_bounce from the vmstat_text array. > > > > > > > > Signed-off-by: Kirill A. Shutemov > > > > Reported-by: Hongyu Ning > > > > Fixes: 194df9f66db8 ("mm: remove NR_BOUNCE zone stat") > > > > Cc: stable@vger.kernel.org > > > > Cc: Christoph Hellwig > > > > Cc: Hannes Reinecke > > > > Cc: Johannes Thumshirn > > > > Cc: Jens Axboe > > > > > > Is there a way to add a BUILD_BUG_ON to catch a future case like this one? > > > > There's > > > > BUILD_BUG_ON(ARRAY_SIZE(vmstat_text) < NR_VMSTAT_ITEMS); > > > > in vmstat_start(). > > > > Making it strict != seems to do the trick for my config. But it requires > > wider testing. > > > > I can prepare a patch for that. > > There was a strict check before 9d7ea9a297e6 ("mm/vmstat: add helpers to > get vmstat item names for each enum type"). Not sure if changing != to < > was intentional. > > Konstantin? I have no clue. Sorry. > > -- > Kiryl Shutsemau / Kirill A. Shutemov