From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f177.google.com (mail-lb0-f177.google.com [209.85.217.177]) by kanga.kvack.org (Postfix) with ESMTP id C1017280319 for ; Fri, 17 Jul 2015 05:37:42 -0400 (EDT) Received: by lbbyj8 with SMTP id yj8so58179542lbb.0 for ; Fri, 17 Jul 2015 02:37:42 -0700 (PDT) Received: from mail-la0-x235.google.com (mail-la0-x235.google.com. [2a00:1450:4010:c03::235]) by mx.google.com with ESMTPS id kw7si9400312lac.136.2015.07.17.02.37.40 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Jul 2015 02:37:41 -0700 (PDT) Received: by lagx9 with SMTP id x9so57967080lag.1 for ; Fri, 17 Jul 2015 02:37:40 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20150714131704.21442.17939.stgit@buzz> <20150714131705.21442.99279.stgit@buzz> Date: Fri, 17 Jul 2015 12:37:40 +0300 Message-ID: Subject: Re: [PATCH 2/2] mm/slub: disable merging after enabling debug in runtime From: Konstantin Khlebnikov Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Lameter Cc: Konstantin Khlebnikov , "linux-mm@kvack.org" , Andrew Morton , Linux Kernel Mailing List On Wed, Jul 15, 2015 at 12:18 AM, Christoph Lameter wrote: > > On Tue, 14 Jul 2015, Konstantin Khlebnikov wrote: >> > What breaks? >> >> The same commands from first patch: >> >> # echo 1 | tee /sys/kernel/slab/*/sanity_checks >> # modprobe configfs >> >> loading configfs now fails (without crashing kernel though) because of >> "sysfs: cannot create duplicate filename '/kernel/slab/:t-0000096'" > > Hrm.... Bad. Maybe drop the checks for the debug options that can be > configured when merging slabs? They do not influence the object layout > per definition. I don't understand that. Debug options do changes in object layout. Since they add significant performance overhead and cannot be undone in runtime it's unlikely that anyone who uses them don't care about merging after that. Also I don't see how merging could affect debugging in positive way (except debugging bugs in merging logic itself). -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org