From: Ying Han <yinghan@google.com>
To: Rik van Riel <riel@redhat.com>
Cc: Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>, Mel Gorman <mel@csn.ul.ie>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Hillf Danton <dhillf@gmail.com>, Hugh Dickins <hughd@google.com>,
KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Subject: Re: [PATCH V8 2/2] mm: memcg detect no memcgs above softlimit under zone reclaim
Date: Fri, 3 Aug 2012 09:30:19 -0700 [thread overview]
Message-ID: <CALWz4izRJqER=4feu0NJn4JeTX6r-utbNVbxHfTYG26XYVWOGg@mail.gmail.com> (raw)
In-Reply-To: <501BF98B.9030103@redhat.com>
On Fri, Aug 3, 2012 at 9:17 AM, Rik van Riel <riel@redhat.com> wrote:
> On 08/03/2012 10:02 AM, Michal Hocko wrote:
>>
>> On Thu 02-08-12 14:24:24, Ying Han wrote:
>
> shrink_lruvec(lruvec, sc);
>>>
>>>
>>> + if (!mem_cgroup_is_root(memcg))
>>> + over_softlimit = true;
>>> + }
>>> +
>>
>>
>> I think this is still not sufficient because you do not want to hammer
>> root in the ignore_softlimit case.
>
>
> Michal, please see my mail from a few days ago, describing how I
> plan to balance pressure between the various LRU lists.
>
> I hope to throw a prototype patch over the wall soon...
I assume this patch is still needed for your later ones, where your
patch will help to balance the
pressure better after start reclaiming.
--Ying
>
> --
> All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-08-03 16:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 21:24 Ying Han
2012-08-03 14:02 ` Michal Hocko
2012-08-03 16:17 ` Rik van Riel
2012-08-03 16:30 ` Ying Han [this message]
2012-08-06 13:26 ` Michal Hocko
2012-08-03 16:28 ` Ying Han
2012-08-06 13:30 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALWz4izRJqER=4feu0NJn4JeTX6r-utbNVbxHfTYG26XYVWOGg@mail.gmail.com' \
--to=yinghan@google.com \
--cc=akpm@linux-foundation.org \
--cc=dhillf@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=mhocko@suse.cz \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox