Re: [PATCH] mm: fix up the vmscan stat in vmstat

[Ying Han <yinghan@google.com>]

On Thu, Apr 12, 2012 at 3:36 PM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Thu, 12 Apr 2012 11:03:02 -0700
> Ying Han <yinghan@google.com> wrote:
>
>> It is always confusing on stat "pgsteal" where it counts both direct
>> reclaim as well as background reclaim. However, we have "kswapd_steal"
>> which also counts background reclaim value.
>>
>> This patch fixes it and also makes it match the existng "pgscan_" stats.
>>
>> Test:
>> pgsteal_kswapd_dma32 447623
>> pgsteal_kswapd_normal 42272677
>> pgsteal_kswapd_movable 0
>> pgsteal_direct_dma32 2801
>> pgsteal_direct_normal 44353270
>> pgsteal_direct_movable 0
>>
>> Signed-off-by: Ying Han <yinghan@google.com>
>> ---
>>  include/linux/vm_event_item.h |    5 +++--
>>  mm/vmscan.c                   |   11 ++++++++---
>>  mm/vmstat.c                   |    4 ++--
>
> I was going to have a big whine about the failure to update the
> /proc/vmstat documentation.  But we don't have any /proc/vmstat
> documentation.  That was a sneaky labor-saving device.

yeah, there were couple of times that I was looking for the
documentation for vmstat but failed. It turns out that I just need to
quickly look at the source code and find out what each field means.

maybe that gives us a hint only kernel developers cares about them :)

--Ying

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>