From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx152.postini.com [74.125.245.152]) by kanga.kvack.org (Postfix) with SMTP id 573B76B0044 for ; Mon, 23 Jul 2012 13:22:05 -0400 (EDT) Received: by lahi5 with SMTP id i5so147762lah.14 for ; Mon, 23 Jul 2012 10:22:03 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20120626075653.GD6713@tiehlicka.suse.cz> References: <1340616061-1955-1-git-send-email-glommer@parallels.com> <20120625204908.GL3869@google.com> <20120626075653.GD6713@tiehlicka.suse.cz> Date: Mon, 23 Jul 2012 10:22:03 -0700 Message-ID: Subject: Re: [PATCH] fix bad behavior in use_hierarchy file From: Ying Han Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Tejun Heo , Glauber Costa , cgroups@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , devel@openvz.org, Dhaval Giani , Kamezawa Hiroyuki , Johannes Weiner On Tue, Jun 26, 2012 at 12:56 AM, Michal Hocko wrote: > [Adding Ying to CC - they are using hierarchies AFAIU in their workloads] Sorry for late ( a month late ) to the thread. Our current production today doesn't support multi-hierarchy setup for memcg, and all the cgroups are flat under root at least on the memory resource perspective. However, we do have use_hierarchy set to 1 to root cgroup upfront. On the other hand, we started exploring nested cgroup since the flat configuration doesn't fullfill all our usecases. In that case, we will have configurations like: root-> A -> B -> C ( not sure about C but at least level to B). Of course, we will have use_hierarchy set to 1 on each level, and the mixed setting won't happen AFAIK. --Ying > > On Mon 25-06-12 13:49:08, Tejun Heo wrote: > [...] >> A bit of delta but is there any chance we can either deprecate >> .use_hierarhcy or at least make it global toggle instead of subtree >> thing? > > So what you are proposing is to have all subtrees of the root either > hierarchical or not, right? > >> This seems needlessly complicated. :( > > Toggle wouldn't help much I am afraid. We would still have to > distinguish (non)hierarchical cases. And I am not sure we can make > everything hierarchical easily. > Most users (from my experience) ignored use_hierarchy for some reasons > and the end results might be really unexpected for them if they used > deeper subtrees (which might be needed due to combination with other > controller(s)). > -- > Michal Hocko > SUSE Labs > SUSE LINUX s.r.o. > Lihovarska 1060/12 > 190 00 Praha 9 > Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org