From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10CC0C369CB for ; Tue, 22 Apr 2025 09:58:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 911CD6B0005; Tue, 22 Apr 2025 05:58:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C0056B0007; Tue, 22 Apr 2025 05:58:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 787976B0008; Tue, 22 Apr 2025 05:58:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5B7D06B0005 for ; Tue, 22 Apr 2025 05:58:49 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 97C7B1603FB for ; Tue, 22 Apr 2025 09:58:49 +0000 (UTC) X-FDA: 83361230778.11.A07D0BA Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) by imf15.hostedemail.com (Postfix) with ESMTP id B6FE1A0009 for ; Tue, 22 Apr 2025 09:58:47 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LyUtsO5i; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of dqfext@gmail.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=dqfext@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745315927; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PjrCn5Us5/CBE2x7oR1mzZ36tfGnDgSVCZsXXiw8h74=; b=gWLlbD2elMLic5mspfYi+1xFXol7VmJQm9pmIM8q0NZQWTnjpmMnwlB9O0D8IhUrFDarQq mzKdhTzx8jr7RX2RhHtIoQmMSqn0nKgnRKErTEL+hhmXqYnPLfplfgdcAF6bOlQkULTBFG N4wPPeGuZ6jSfgQyPHYKPyS7G0ljWeg= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LyUtsO5i; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of dqfext@gmail.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=dqfext@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745315927; a=rsa-sha256; cv=none; b=PoTd7VPtZ5Yn4BqDfbEOmWQ58tovajDqoGBsAsAw5memeoEAFF270kP2sdHtCho7GidCA9 f2fC/E4e40lmqwB02iKM8wb7KuN6OUMVtsmn2Fy4H4nOOOFG5NMLs+15FBNDbaa1/dx3Gt cu26cpCYqWmK9Zxyry2EbwA95/uYrR8= Received: by mail-yb1-f178.google.com with SMTP id 3f1490d57ef6-e7299e3ab5cso3077334276.1 for ; Tue, 22 Apr 2025 02:58:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745315927; x=1745920727; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PjrCn5Us5/CBE2x7oR1mzZ36tfGnDgSVCZsXXiw8h74=; b=LyUtsO5iArJIwG3jQDcNUDCNm/66aemSEGEvjli7Wmcd0GsaYcOfWpiRPYwnamI3OS wcHZWPgInmW3AMi3YyXvQk2K+JyOzgpMijMtnwjAuSmw3a5cF//PgpaWdWunCD5hY+wd DNuGouE9XGCaJgcGCZnQNh3551X1g93xo8oNhmB2J4X2fHMI6cjT9u53VldBrqXUFUDA J5VF8icFZRZOdeHTt88NBS5vU3GZJcnoeumDj+WANkSmjfErENFJ0d4pFmaQ/3rfCqds CaKuilrg+FTOxu0X4JHMhEbHVnvE7jGy4vT1EIbmNaNBTHz7viv21ttk0feM+JzYx/sr Jwaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745315927; x=1745920727; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PjrCn5Us5/CBE2x7oR1mzZ36tfGnDgSVCZsXXiw8h74=; b=rVdg5g6dd1y7D3VTUxaK/Sw8OlqYDdgOrMg2u2nuVphlvOD9huUs9UltXIExCrix0Z XHBQKWbj6YLeSzENnMAItTMW4WdCYT5QzR3wGjB23krLV5F1uowj0kfjxLvW0FMudoCB BdtOD3d5NmCQMotFiqTAhnxjzXvPDbHKo3ckZk/+eKXmRjNDrOk7Wlo3htSsoR/GYbFH LeyOWT60X4QkPWKxCT4k/hW4XxQMYwcmCiE2OXJh0tS0/bJXm19lp/aytJCLAUfMB83Z zAkpI/QRrsjtiwxjZ8422J3laKviwzHhLgN/y3nAjZowaGFA7nYOjbvRN5HwvkbO0U8r vzzA== X-Forwarded-Encrypted: i=1; AJvYcCXb+vAYd6ARlpZUq06oD0Jd0O0z5lg2dDUDUIhwe2ZE8Zgvo4MVoYWGp5RNdSKl8sNZAF3amLuZSA==@kvack.org X-Gm-Message-State: AOJu0Ywp/9oS7A5vuzCSlJByrbDZWu/FEPKyziX2r0ta0czvCugQUy6M yr9Q4Zmno4EnXlLas0v27vUlpQN5d23GeqfZW6vkxBxsXzUZ07E/A1U1iZEQi4rK0NVl4PTq4I5 +/3zvzX10GWLEaWHF4T0c72FFG9E= X-Gm-Gg: ASbGnctse5odehyPyO0LkqktQYgXGrjoI1FvOIiG7+AKzPf7GBY7IwFM3RaCxMSk3Vm zyM9ZuYGYYtajDFsusUSCIcorxFxk5h/WsrPRKXUDzLqzFyNsUyYDaJiRv2ug7ci7NmsNoHTPdX vU3due22Tj9iiIOrtus54BCCpGS+Q95lQp96H4Rg== X-Google-Smtp-Source: AGHT+IFa9eHNwML+ymb5oSKFoPmkm41+1ErmLYYbEUaMPtkXJY3kPro9S3dyOdL5slyrAUY8+txU6LBqOfIe00OdidA= X-Received: by 2002:a05:6902:2783:b0:e6d:e429:1d70 with SMTP id 3f1490d57ef6-e7297db6ddcmr20938516276.12.1745315926743; Tue, 22 Apr 2025 02:58:46 -0700 (PDT) MIME-Version: 1.0 References: <2025042251-energize-preorder-31cd@gregkh> <2025042237-express-coconut-592c@gregkh> <7bf68ddd-7204-4a8c-b7df-03ecb6aa2ad2@redhat.com> In-Reply-To: <7bf68ddd-7204-4a8c-b7df-03ecb6aa2ad2@redhat.com> From: Qingfang Deng Date: Tue, 22 Apr 2025 17:58:26 +0800 X-Gm-Features: ATxdqUHeTroRr_I6v_53FmIchDwXKcBxXvbg0MjCMzai7odyBA2mM_eG-m9PEmg Message-ID: Subject: Re: Please apply d2155fe54ddb to 5.10 and 5.4 To: David Hildenbrand Cc: Greg Kroah-Hartman , Sasha Levin , stable@vger.kernel.org, linux-mm@kvack.org, Zi Yan , Johannes Weiner , Brendan Jackman , Michal Hocko , Suren Baghdasaryan , Vlastimil Babka , Andrew Morton , Liu Xiang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: khx35ti764egi93chnhpxtumxfseccfi X-Rspamd-Queue-Id: B6FE1A0009 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1745315927-386742 X-HE-Meta: U2FsdGVkX1/d9MlHZ7oz2/F9RTN1ubhISpg/4ZOcxcYA9pLm8vJQ/Sc/1ZBr3N7LPgCkxF1VyVqDJPtchXX5WwaV3dzWlkf2Ms3f+PTiWVEPEMmElTPC1BvVfNPC811HwirdyuTJNlXxC6X65i2RIkuV7lAdzoxJulgolbO8FVkfNbpHyh6UxNXi1ZEU79pMyrHDXXM5ggn35Nfa9PvIk9qY63+SI/zng6CcGT6qXpvOkyDM8mTGUnCUd0wczG7GhHWuc+EeEbMk1l0ED6lub7GkTZ+/ZYNhwGgnQV6W3LPqcctyZmaRkcLfV2ptvDqn7iao3r4Ip23xGoTBVhHfzDIUE0cp0rXRgW0tjvVtQgJr6jttf7FzkKnyv3qGHW+r6w0jSe59roBIEOy/w5Kd47gmWrS6wGrjWX41R4nIX0vu7eBt4Q8UQArI77OVXAFbS/BwtqPqaCvt7nVWjuQ7hrJBL4ed4PAgaBzfwSqRHq4Jd4p+umeKYwS6mFTfeUA9x/iQyViYGwgwyfjxWcuK5ECd96ffDv71ckv2cv2IgQjXFWmcyo7eKzQZDhsBa9V/OVVqYSdR89aaYOPB3JxxQXTV2EcXRPHY2zbQAHS0XlD1u1aAmj8cXAorjeOuAyvp+MQzFE8fiowIpFm/e5vWijAUryu53TeuJ4Cur8ivCFFlA0c0DJ5E6akuTnoBpPAb5zErL6TrzKRQshBkG+pB2myMxoD+ayzF8Y9weCVaRbvtTCTJ6UIq+8YDDTRPwVta+Pq8ZsTCXYJUKn4LXi5udTvhTuhkMjxjBHgIiP1QxjCAsCVyfPIgXp5wJhiGl1wB4RfpJU7DD/vPEMumH8CiviXtUR5wiCEtXXpQ4MIqgp8LmOe3yUUF/rGsEGJB6puH1fbCtONZt5ArTO0j+5A5E7oPZbJ28cHD02K4V/g9VjKklKgrxaZaHgsoBoqCYK0rk/4+aVowA+1uTMFTEc0 snDIa9wU BsxJ/y7+4XwFoCpENCHBJ1ndz3JB24UoGilpUXiBK6Wn5yCI02BdpAxEexizz8oSYffI9MPjQf+QVTUOH7wHX0jgaKe8l23xYCpijF3tFowgo2t503GVJ5AkrYMdWPK/3ZlgMtN4Cnu69duNUwBxUSDMGuPBq5ug2jUJXt4hbj0D7bXwEuPjNnai5n+I0WJZXzKKsvOzK+RlzSC8XCM5CghiAJ+67+2gp24LAXOX177v1vGD095gbaK4R7r+pkRdhWgsKIAGMGqYixLsfEbmIR0zyJbdhVV3U0TVKb6xfkEa6j6ro5nW1ZSrdz+o/yfj/W/yGhYNw+3ZfUbZqSNEwWzHcvg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi David, On Tue, Apr 22, 2025 at 3:04=E2=80=AFPM David Hildenbrand wrote: > > Let me post it again: > > > > Please consider applying d2155fe54ddb ("mm: compaction: remove > > duplicate !list_empty(&sublist) check") to 5.10 and 5.4, as it > > resolves a -Wdangling-pointer warning in recent GCC versions: > > > > In function '__list_cut_position', > > inlined from 'list_cut_position' at ./include/linux/list.h:400:3, > > inlined from 'move_freelist_tail' at mm/compaction.c:1241:3: > > ./include/linux/list.h:370:21: warning: storing the address of local > > variable 'sublist' in '*&freepage_6(D)->D.15621.D.15566.lru.next' > > [-Wdangling-pointer=3D] > > The commit looks harmless. But I don't see how it could fix any warning? > > I mean, we replace two !list_empty() checks by a single one ... and the > warning is about list_cut_position() ? I have no idea, actually. Maybe the double !list_empty() confuses the compiler, making it think `sublist` can be referenced out of the scope? > > -- > Cheers, > > David / dhildenb >