From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx142.postini.com [74.125.245.142]) by kanga.kvack.org (Postfix) with SMTP id F2A336B0033 for ; Fri, 14 Jun 2013 14:13:26 -0400 (EDT) Received: by mail-pa0-f46.google.com with SMTP id fa11so888395pad.5 for ; Fri, 14 Jun 2013 11:13:26 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20130614111034.GA306@gmail.com> References: <1371204471-13518-1-git-send-email-heesub.shin@samsung.com> <20130614111034.GA306@gmail.com> Date: Sat, 15 Jun 2013 03:13:26 +0900 Message-ID: Subject: Re: [PATCH] mm: vmscan: remove redundant querying to shrinker From: HeeSub Shin Content-Type: multipart/alternative; boundary=047d7bacb51600785404df213437 Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: Heesub Shin , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mgorman@suse.de, riel@redhat.com, kyungmin.park@samsung.com, d.j.shin@samsung.com, sunae.seo@samsung.com --047d7bacb51600785404df213437 Content-Type: text/plain; charset=ISO-8859-1 Hello, On Fri, Jun 14, 2013 at 8:10 PM, Minchan Kim wrote: > > Hello, > > On Fri, Jun 14, 2013 at 07:07:51PM +0900, Heesub Shin wrote: > > shrink_slab() queries each slab cache to get the number of > > elements in it. In most cases such queries are cheap but, > > on some caches. For example, Android low-memory-killer, > > which is operates as a slab shrinker, does relatively > > long calculation once invoked and it is quite expensive. > > LMK as shrinker is really bad, which everybody didn't want > when we reviewed it a few years ago so that's a one of reason > LMK couldn't be promoted to mainline yet. So your motivation is > already not atrractive. ;-) > > > > > This patch removes redundant queries to shrinker function > > in the loop of shrink batch. > > I didn't review the patch and others don't want it, I guess. > Because slab shrink is under construction and many patches were > already merged into mmtom. Please look at latest mmotm tree. > > git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git > > If you concern is still in there and it's really big concern of MM > we should take care, NOT LMK, plese, resend it. > > I've noticed that there are huge changes there in the recent mmotm and you guys already settled the issue of my concern. I usually keep track changes in recent mm-tree, but this time I didn't. My bad :-) Many thanks for your comments! -- Heesub > Thanks. > > -- > Kind regards, > Minchan Kim > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org > --047d7bacb51600785404df213437 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hello,

On Fri, Jun 14, 2013 at 8:10 PM, M= inchan Kim <minchan@kernel.org> wrote:

Hello,

On Fri, Jun 14, 2013 at 07:07:51PM +0900, Heesub Shin wrote:
> shrink_slab() queries each slab cache to get the number of
> elements in it. In most cases such queries are cheap but,
> on some caches. For example, Android low-memory-killer,
> which is operates as a slab shrinker, does relatively
> long calculation once invoked and it is quite expensive.

LMK as shrinker is really bad, which everybody didn't want
when we reviewed it a few years ago so that's a one of reason
LMK couldn't be promoted to mainline yet. So your motivation is
already not atrractive. ;-)

>
> This patch removes redundant queries to shrinker function
> in the loop of shrink batch.

I didn't review the patch and others don't want it, I guess.<= br> Because slab shrink is under construction and many patches were
already merged into mmtom. Please look at latest mmotm tree.

=A0 =A0 =A0 =A0 git://git.kernel.org/pub/scm/linux/kernel/g= it/mhocko/mm.git


If you concern is still in there and it's really big concern of MM
we should take care, NOT LMK, plese, resend it.


I've noticed that there are huge changes there in the= recent mmotm and you guys already settled the issue of my concern. I usual= ly keep track changes in recent mm-tree, but this time I didn't. My bad= :-)

Many thanks for your comments!

--
Heesub=A0
=A0
Thanks.

--
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.= =A0For more info on Linux MM,
see: http://www.linu= x-mm.org/ .
Don't email: <a href=3Dmailto:"dont@kvack.org"> email@kva= ck.org </a>

--047d7bacb51600785404df213437-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org