On Fri, Jun 14, 2013 at 8:10 PM, Minchan Kim
<minchan@kernel.org> wrote:
Hello,
On Fri, Jun 14, 2013 at 07:07:51PM +0900, Heesub Shin wrote:
> shrink_slab() queries each slab cache to get the number of
> elements in it. In most cases such queries are cheap but,
> on some caches. For example, Android low-memory-killer,
> which is operates as a slab shrinker, does relatively
> long calculation once invoked and it is quite expensive.
LMK as shrinker is really bad, which everybody didn't want
when we reviewed it a few years ago so that's a one of reason
LMK couldn't be promoted to mainline yet. So your motivation is
already not atrractive. ;-)
>
> This patch removes redundant queries to shrinker function
> in the loop of shrink batch.
I didn't review the patch and others don't want it, I guess.
Because slab shrink is under construction and many patches were
already merged into mmtom. Please look at latest mmotm tree.
git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git
If you concern is still in there and it's really big concern of MM
we should take care, NOT LMK, plese, resend it.
I've noticed that there are huge changes there in the recent mmotm and you guys already settled the issue of my concern. I usually keep track changes in recent mm-tree, but this time I didn't. My bad :-)
Many thanks for your comments!
--
Heesub
Thanks.
--
Kind regards,
Minchan Kim