From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56C83C433E3 for ; Tue, 25 Aug 2020 01:40:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1549520738 for ; Tue, 25 Aug 2020 01:40:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qVYjfvfG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1549520738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9B8726B00B3; Mon, 24 Aug 2020 21:40:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 968C66B00B4; Mon, 24 Aug 2020 21:40:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 856476B00B5; Mon, 24 Aug 2020 21:40:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0209.hostedemail.com [216.40.44.209]) by kanga.kvack.org (Postfix) with ESMTP id 6F7336B00B3 for ; Mon, 24 Aug 2020 21:40:02 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 29B22362E for ; Tue, 25 Aug 2020 01:40:02 +0000 (UTC) X-FDA: 77187385044.10.soap96_2c0ede527057 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id F25B016A0D2 for ; Tue, 25 Aug 2020 01:40:01 +0000 (UTC) X-HE-Tag: soap96_2c0ede527057 X-Filterd-Recvd-Size: 4397 Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Tue, 25 Aug 2020 01:40:01 +0000 (UTC) Received: by mail-il1-f194.google.com with SMTP id 77so9065009ilc.5 for ; Mon, 24 Aug 2020 18:40:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yoiR+v9rO+JXIM35TpzuNUweu/a+mWGhR08Sf+gYpoE=; b=qVYjfvfGCAzq+gxatqSrfaeQ96FYChxURcFFoBc5HXjiJqoVg5Tdqs/0vFBZ5YSE/2 SE8aSLz2Cchy9al8OyFoMCAAgxuxkx/rG6U5R57KMI1JZK2vEb/CVOCC0c/VouiJsZST X9XuB47UsC4YojWP1A8+VcjPJs7w0c87sAn5iReaKh/H8eq0fGO0gLQI/VC33M61CDSN qKFLKg/JSDmdiYE4dp0TmJBQMd20UejWs28TkVjF5FpBTp6LAPeiJVEnxmLYkMioUVTP qWqHv22buV1/cxcPf+LLRnEBy48+coznSzonwcYoMeJbmVDpCWZc+KNd92zPM08/ihAy bI0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yoiR+v9rO+JXIM35TpzuNUweu/a+mWGhR08Sf+gYpoE=; b=ok+Filx4xqb/3ar+sQC0oYWJjmun/idha5Qc5nZTCQH/DCBRbMNAsy8nnNApfzlNiX IRDxPvTNYfZU4/UYtVR7rzS8XASbAvl/cllHO1B8C4qcPtasHobKSmoKYm2uZIPeBp6y joJRv2m03FWTt32xbM/wLAqi7QGdO985EN1qNrE6gamwmO1O1dOZ+JXnju88TeDi7rgx HH/p9MJSiC/mRmZqX8FJeDXAVloQ3zQ0opiM+/2lA0v7PzV1V61BpdCQoQ0XGOiPMYX5 JHT75YGvN5OF5qDPFvYYsBF5//tgXbm/N1VKozJ80VM6A3KXg6ZckbxQTEvyjfk/Z1gG xDJA== X-Gm-Message-State: AOAM533fdLrwnwQigWT2Fi1XnUaYiwzCWVSYB6F5nCRbOj5ksiw9QrLm xONPUhsdtjOR+bY4AhgsLscRh+dbf4byyA1YELU= X-Google-Smtp-Source: ABdhPJx0GCQd+VH/ciHeUEmZwX5OFuSMWk4a0K8nSG9UO2gwrrUAyTwcH+dYnw1X5Jf4O6U8fviHxbX6S9C4HsipWbk= X-Received: by 2002:a92:108:: with SMTP id 8mr7376238ilb.142.1598319600842; Mon, 24 Aug 2020 18:40:00 -0700 (PDT) MIME-Version: 1.0 References: <20200824014234.7109-1-laoar.shao@gmail.com> <20200824014234.7109-3-laoar.shao@gmail.com> <20200824130925.a3d2d2b75ac3a6b4eba72fb9@linux-foundation.org> <20200824205647.GG17456@casper.infradead.org> In-Reply-To: <20200824205647.GG17456@casper.infradead.org> From: Yafang Shao Date: Tue, 25 Aug 2020 09:39:25 +0800 Message-ID: Subject: Re: [PATCH v6 2/2] xfs: avoid transaction reservation recursion To: Matthew Wilcox Cc: Andrew Morton , Dave Chinner , Christoph Hellwig , "Darrick J. Wong" , Michal Hocko , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Linux MM Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: F25B016A0D2 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 25, 2020 at 4:56 AM Matthew Wilcox wrote: > > On Mon, Aug 24, 2020 at 01:09:25PM -0700, Andrew Morton wrote: > > On Mon, 24 Aug 2020 09:42:34 +0800 Yafang Shao wrote: > > > > > --- a/include/linux/iomap.h > > > +++ b/include/linux/iomap.h > > > @@ -271,4 +271,11 @@ int iomap_swapfile_activate(struct swap_info_struct *sis, > > > # define iomap_swapfile_activate(sis, swapfile, pagespan, ops) (-EIO) > > > #endif /* CONFIG_SWAP */ > > > > > > +/* Use the journal_info to indicate current is in a transaction */ > > > +static inline bool > > > +fstrans_context_active(void) > > > +{ > > > + return current->journal_info != NULL; > > > +} > > > > Why choose iomap.h for this? > > Because it gets used in iomap/buffered-io.c > > I don't think this is necessarily a useful abstraction, to be honest. > I'd just open-code 'if (current->journal_info)' or !current->journal_info, > whichever way round the code is: > > fs/btrfs/delalloc-space.c: if (current->journal_info) > fs/ceph/xattr.c: if (current->journal_info) { > fs/gfs2/bmap.c: if (current->journal_info) { > fs/jbd2/transaction.c: if (WARN_ON(current->journal_info)) { > fs/reiserfs/super.c: if (!current->journal_info) { > > (to pluck a few examples from existing filesystems) Make sense to me. I will update it in the next version. -- Thanks Yafang