From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DB92C5AD4C for ; Thu, 23 Nov 2023 12:22:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C02D86B064F; Thu, 23 Nov 2023 07:22:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BB21A6B0650; Thu, 23 Nov 2023 07:22:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7A2C6B0651; Thu, 23 Nov 2023 07:22:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 963E46B064F for ; Thu, 23 Nov 2023 07:22:13 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5AAB51207E7 for ; Thu, 23 Nov 2023 12:22:13 +0000 (UTC) X-FDA: 81489131346.30.5275B69 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) by imf01.hostedemail.com (Postfix) with ESMTP id 974364000F for ; Thu, 23 Nov 2023 12:22:11 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="bSD+W6p/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.222.176 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700742131; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w9b7hxZxggUNzWPZcEt2SSt9tvfb5uiUa5fxRekt8xM=; b=oa9cyLkVe1KQ+a/8d6ii4WZw2X6znmugOqhzEZtU1uxbzrmDySnHnDl7NL507eorV0ZQZm mzU07Pgg/x85TjQVhd2QkmEXKl+DLdFFJeOeO0Skzqt2y5poTxjZsCVSX/XgJp8uGj5/E6 YU+qoiIxxkB1J17DrxxxsQxrUtWBaW0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="bSD+W6p/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.222.176 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700742131; a=rsa-sha256; cv=none; b=REnvHz5eyu3Zh71zbHxE6+rwNxmiwlcfDif6b8pVk4Q9GX/k90U2mxoLNy5ee9uNNGlyl2 sQjJjb14A0JUKj200gZGIONf2vnh8b4hZxSQtFSpbJmiA1MBPBYzOmi1qDcz/y995vR/Xh lP1zkt11fMB6Abo4A+zbeh0LIaGhcKM= Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-77d606355e7so42175885a.2 for ; Thu, 23 Nov 2023 04:22:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700742130; x=1701346930; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=w9b7hxZxggUNzWPZcEt2SSt9tvfb5uiUa5fxRekt8xM=; b=bSD+W6p/bPjEQndNj+cy0zWdk6AWpGacm72B3MfFskWVrDnnmz20ncNuY56On+ZY5F nSOO1mIP4kdNW5RzLt1kLdV7AHc+vPI9b8zcTqzEACuE5ok83jxHoA3S5hBXOaoX516q 1IZcdfgMvJvFqiFmuKV9qgo/6AYpg+m0T2QOPx/eJkCzrKQyrslTM2jsnvKoLh9miPOt 7vFelWabprm4jUvrCzsNPHmuQDTgz5iHSXMD0/yyIDszsFcvqy1pw+7iU7Mgd0I1aidr slfXOtcuLg4o16NsAw7+tbNxyoXyMdiO8tcG1GC0sWo/PuL6dWQkizr0Wu0nnFAHfX7L P1aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700742130; x=1701346930; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w9b7hxZxggUNzWPZcEt2SSt9tvfb5uiUa5fxRekt8xM=; b=d1GffTGnRKxfTZBHoDzLQS++owJR3S5b431wP8fdD0zZaeTYNFInn+o7M6pAYm5ltp MVr7NYCgVMzdo5JbQYls5FtClSIqfsOF68Uq3KtJW45wUufvtK6yvob2hT+PaPkSujY9 HWaVEkm7cGDbHFzbRVV7HwEIiLo13nnS2P/1pXG7YTtWdNTpeQVf1W1r1DsimSfCcrQb trgbPbhwKgUSw7tFKaGQlAma1mWgb6B+N/PGbaBs3fTWm86kVXtfz8h96+ahbkimYXH6 aYyCdpgHrFIq8CEHoWl+o7K0/TTNxUYVPfW/dzDipuYJuLIdujW7dLslUE941wOaStoW FlAg== X-Gm-Message-State: AOJu0YzwMFpkFgzmg7Q8YqeOJMFvGaROfxm1cHpvGrZ02zNXGxxT8/iZ PQ6HoMeHPhZJrQmMzibAIyoor1tc4Y1sNWaUZTv+ay/N/zHDDw== X-Google-Smtp-Source: AGHT+IGV5ARiTvmQFIAC9uDVavWcbdxbAY4C8q2cxi8gW6E6IUDziRn+hFG4aSjasmgZgK5w/Ye/bBVfOR6njOUoJ4g= X-Received: by 2002:ad4:58e5:0:b0:67a:e8c:863b with SMTP id di5-20020ad458e5000000b0067a0e8c863bmr96257qvb.63.1700742130607; Thu, 23 Nov 2023 04:22:10 -0800 (PST) MIME-Version: 1.0 References: <20231122141559.4228-1-laoar.shao@gmail.com> <20231122141559.4228-3-laoar.shao@gmail.com> <87il5t7zi3.fsf@yhuang6-desk2.ccr.corp.intel.com> In-Reply-To: <87il5t7zi3.fsf@yhuang6-desk2.ccr.corp.intel.com> From: Yafang Shao Date: Thu, 23 Nov 2023 20:21:33 +0800 Message-ID: Subject: Re: [RFC PATCH v2 2/6] mm: mempolicy: Revise comment regarding mempolicy mode flags To: "Huang, Ying" Cc: akpm@linux-foundation.org, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, omosnace@redhat.com, mhocko@suse.com, linux-mm@kvack.org, linux-security-module@vger.kernel.org, bpf@vger.kernel.org, ligang.bdlg@bytedance.com, Eric Dumazet Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 974364000F X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ezzt9x9u94ruuiyubaguq8ouj4mhigao X-HE-Tag: 1700742131-840126 X-HE-Meta: U2FsdGVkX18vCdfgn9nGFEVOq7i1aSa309sMkBjDkRdYj2lHedOJpizm4No/+orBn71kAgrjSDQG8D5K3o8ZCXHqdr3kfA/lzXqMidy3hLNB5LAgwAhnMlXISJLBAZ9MxsXlXfTHbPr7oFLl6H/oK3YzmMmAJHWmB5cfeTgvKLivWpKgLV+zIgN4BroZHaahZEgb2aK2mgk2yS4HhSM0lYI9EyU5FyhHfX3vtV5bwjpfoh+CWD+WKylrWf9EQpaf4KowbvgOoYUBm43DhwuX9bZZJXKtl0T64PQcakj7aFeW5GANJ3ZEIOIaaecPw59K5HrVjrWTZCxKGsbLf8X/izAot92haAozGM3efcWqlDP2V7Ar9/6uwL2mPP0hzdh4t4y7kZnNpDbE6KgJ38BepQJtG9kIP4+r2TZlpFQi8f4iifJWnGxTPpKx4RKo162n+mLB0Tg0Fe3fNxcco8MeEX5L1tyebscx4y0+TruX71gdxJaNewJuvmoOq7rueeruMaoKBUwPJWDGmQVFu9IHjqHTu6K0pUkYvGtS1eBwEY/oesgrBqPi1as9+Azvm2dunUWC1gUo4bh60ORiaezJ0BCDEqDDQr0xju813WpJCeIkX0GV9+POcuX8GQ645OjbyV/qc7uTIMO9jlZrD/YWfWUyTsbS0y8rc8FNGUahjijzh7wUp8nfEzGJ9W7mNP5q1SRG2W9eng9ckjL8UiweXbpmBrVNt7rcV3+FOkl4/8CWQl25BL9xB6JdD3IgrTw0V5ACqdk/HWvVhFQXJatbpBE4yZejZmehK7oqZS970vrksrGHjs63Gmr7e6iPdlC7yKKgVU6lTQFIRk9E3Sxc11wE/3qKMoKiO1E0yCJqY1JbfCmNIL/TzfNnRsYXkRHJOc5acSxFS0kPom32xyrWAOaJepTseZndQ7WIgHnLRRFZu4yMMx9Ma5fPx8t2bMwh7fG2ZDX68K4WSYqqlbJ q0uzQg4g w9l1d+0IqjDBbCfwinQaUlMJv8mxrqmb9qc76lDpkMuT7fnXF+cBh3IVBnA3eD6xbZNBOdXClAsF3Ot2hCNIJ4oM8lfjUO9xliN05yZ2Akn7qT0XlDtQ0bXSqFgK12qq5i/pdu+XGGY99ZhFU/gKkGTQ9LM1yga14iDlRQ0BBRAssxeEgXpbIQNGc8SaYNKqANHvZdu9D8iVOi/etskfmokWetoIc1JFlDNXcGgV/gewnLzuwgxnTW2R98IGZFzdgUxwSFozkGIsp16nEwkJ6ssWs4ny4p5pALSVhO5qHTPkIR0hJ6ccauljKwqRWggIoMaGJjtndIHY33lzAYW3oMIziBxKNBttczBzkd/NRk1rHbAMK5sqHPAfjHWksPr2JgoMH0KE11dW5tEkUsSzbMergBMKrDsfZIGr+Nd+KzNRQdsV934/Mxo9Egf3+Tr9dBEtuhiPG2rJhcEIipfMCBz8g5CNrHrl67baD45RRlAeJceYc/qDzVkJB/OG1VozvvOq/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000024, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 23, 2023 at 2:32=E2=80=AFPM Huang, Ying = wrote: > > Yafang Shao writes: > > > MPOL_F_STATIC_NODES, MPOL_F_RELATIVE_NODES, and MPOL_F_NUMA_BALANCING a= re > > mode flags applicable to both set_mempolicy(2) and mbind(2) system call= s. > > It's worth noting that MPOL_F_NUMA_BALANCING was initially introduced i= n > > commit bda420b98505 ("numa balancing: migrate on fault among multiple b= ound > > nodes") exclusively for set_mempolicy(2). However, it was later made a > > shared flag for both set_mempolicy(2) and mbind(2) following > > commit 6d2aec9e123b ("mm/mempolicy: do not allow illegal > > MPOL_F_NUMA_BALANCING | MPOL_LOCAL in mbind()"). > > > > This revised version aims to clarify the details regarding the mode fla= gs. > > > > Signed-off-by: Yafang Shao > > Cc: Eric Dumazet > > Cc: "Huang, Ying" > > Thanks for fixing this. > > Reviewed-by: "Huang, Ying" > > And, please revise the manpage for mbind() too. As we have done for > set_mempolicy(), > > https://lore.kernel.org/all/20210120061235.148637-3-ying.huang@intel.com/ Thanks for your review. will do it. --=20 Regards Yafang