From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3821BC00140 for ; Sat, 13 Aug 2022 00:07:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD0126B0073; Fri, 12 Aug 2022 20:07:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B812F6B0075; Fri, 12 Aug 2022 20:07:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A216C8E0001; Fri, 12 Aug 2022 20:07:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 949B66B0073 for ; Fri, 12 Aug 2022 20:07:43 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 71343140A3C for ; Sat, 13 Aug 2022 00:07:43 +0000 (UTC) X-FDA: 79792630806.27.B8FAFE3 Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com [209.85.217.41]) by imf17.hostedemail.com (Postfix) with ESMTP id A78EB40073 for ; Sat, 13 Aug 2022 00:07:41 +0000 (UTC) Received: by mail-vs1-f41.google.com with SMTP id q190so2293925vsb.7 for ; Fri, 12 Aug 2022 17:07:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=e/GEPoh9oXwaicH1mqU0UxtQs3rb9zpYq6pzE3gMamU=; b=fI8PvmX9/t2PLgbwoyuy/E4fAMPOov0xE5a7OjGy1WUFHEUxwBcNvvqD5gSGVhNgOK WZw3lzfQQbHfVe/0Qj0NW4OPEGEgpST591KZOPILFcg+sqpKgN0t5MBjxK4tyAD/q4Lj jYCms26OXy4IHggn8pSfZFxRnAWvWI7Hd0dNIjAwzZLlX3bz+1tkMIrMO4RZcom9RklK xQ2xolwtYqrIeEOBL3tL/OTJkhg8kxtJk12IBEeDnKuGQZ6HXGmYTHY59ORJhR5EwtLT gIA0+1VDanZTFu0PZ9dsoj+ehsEartf/DGCZPFSZhYqTJV9VRPoUt4M2MC2+M2m6o8iv 0bSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=e/GEPoh9oXwaicH1mqU0UxtQs3rb9zpYq6pzE3gMamU=; b=UqK9Q4ZNS31W/cAQP3ZCBnsVjYlRwGUMayQAbeCXgFaIjQoPPpEj3l6RHe0bZAF4Wq bH2bQenr/9ke+Mwm/8azhklnVYZQleT5hjyMgIQG3jx3zaDMu7M7eHj7KRA8GRFMBz6W 9vAJ0bh6dft+9JRU8E+Tw24QCHrqma7ATLbedGdPL/nXU3i/CNj0e53BFu0UssMz/lTA +1ozOMTd3qFCg0j3q0N7u5a0a5fjMCam83N6rFs9kcA9yFV0R1rzEoSZe1ab5IbsFYzf 4pVgqtE1Vau91Qz2iOZtqlissmWsLP3prPlTiW1j6V8At2jHfd7YXAwCLMpywGJfuivB drCQ== X-Gm-Message-State: ACgBeo3cb6eDsdazTIpUdiSwiw1k1xAtO1FOBxQGTyoQnlFfVLxW0lq0 F6qxdo3V9NT298/dMlQBoAdhBl+M77dEKnG9AOY= X-Google-Smtp-Source: AA6agR6wxzw7R/QR4+tJWTD/bsN3E+UUPFlZUz6BEsv1/PilpMzsEYhAEcNJpaQv5Ng+IURcAxZqkfJ8+uoYx7n08b8= X-Received: by 2002:a05:6102:441c:b0:378:fcdd:d951 with SMTP id df28-20020a056102441c00b00378fcddd951mr2920620vsb.22.1660349261002; Fri, 12 Aug 2022 17:07:41 -0700 (PDT) MIME-Version: 1.0 References: <20220810151840.16394-1-laoar.shao@gmail.com> <20220810151840.16394-14-laoar.shao@gmail.com> <20220812165756.dxaqy3go567prr5s@google.com> In-Reply-To: <20220812165756.dxaqy3go567prr5s@google.com> From: Yafang Shao Date: Sat, 13 Aug 2022 08:07:04 +0800 Message-ID: Subject: Re: [PATCH bpf-next 13/15] mm, memcg: Add new helper get_obj_cgroup_from_cgroup To: Shakeel Butt Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin Lau , Song Liu , Yonghong Song , john fastabend , KP Singh , Stanislav Fomichev , Hao Luo , jolsa@kernel.org, Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , netdev , bpf , Linux MM Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660349261; a=rsa-sha256; cv=none; b=uCa8lSeuFLwUtYBxwMEsj1ZkSoOjAwCJvXLVB2GvjjupNc6ZSwNiYKn+Lkw2wYzug48UlZ jrU47/0GkdZxVR54GJqgpF4qyV9fvlCy7HLJZlnL8GQA+ocPAYPeaJ+rPQubZUZPmij6m7 3JJm4n1e9/9Uw1krBmwod3SrxkfALF0= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=fI8PvmX9; spf=pass (imf17.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.217.41 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660349261; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e/GEPoh9oXwaicH1mqU0UxtQs3rb9zpYq6pzE3gMamU=; b=qLHZBN3eT0TCT7rpj9ZpJpsd+W1X0rflBvuLwJ9m1JXcfF9dF4D3St1iFMrbyq8NXHXZF/ /KIUT5kYgieOfkxbzy+LB6ZIBVmhRxOJAtkuwOI3Jkdmrw1jcQQVGjdHGwjNRN9b+vVUb3 w0e3J9ktrzXVGaDHJfx8TccC44kRlCM= X-Rspam-User: X-Stat-Signature: 8um71wp1hqsr9xmzhs7qimqjb3k7h871 X-Rspamd-Queue-Id: A78EB40073 Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=fI8PvmX9; spf=pass (imf17.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.217.41 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam01 X-HE-Tag: 1660349261-921284 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Aug 13, 2022 at 12:57 AM Shakeel Butt wrote: > > On Wed, Aug 10, 2022 at 03:18:38PM +0000, Yafang Shao wrote: > > Introduce new helper get_obj_cgroup_from_cgroup() to get obj_cgroup from > > a specific cgroup. > > Can you please add couple of lines on why you need objcg? > Sure. will update in the next version. > > > > Signed-off-by: Yafang Shao > > --- > > include/linux/memcontrol.h | 1 + > > mm/memcontrol.c | 41 +++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 42 insertions(+) > > > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > > index 2f0a611..901a921 100644 > > --- a/include/linux/memcontrol.h > > +++ b/include/linux/memcontrol.h > > @@ -1713,6 +1713,7 @@ static inline void set_shrinker_bit(struct mem_cgroup *memcg, > > int __memcg_kmem_charge_page(struct page *page, gfp_t gfp, int order); > > void __memcg_kmem_uncharge_page(struct page *page, int order); > > > > +struct obj_cgroup *get_obj_cgroup_from_cgroup(struct cgroup *cgrp); > > struct obj_cgroup *get_obj_cgroup_from_current(void); > > struct obj_cgroup *get_obj_cgroup_from_page(struct page *page); > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index 618c366..762cffa 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -2908,6 +2908,47 @@ static struct obj_cgroup *__get_obj_cgroup_from_memcg(struct mem_cgroup *memcg) > > return objcg; > > } > > > > +static struct obj_cgroup *get_obj_cgroup_from_memcg(struct mem_cgroup *memcg) > > +{ > > + struct obj_cgroup *objcg; > > + > > + if (memcg_kmem_bypass()) > > + return NULL; > > + > > + rcu_read_lock(); > > + objcg = __get_obj_cgroup_from_memcg(memcg); > > + rcu_read_unlock(); > > + return objcg; > > +} > > + > > +struct obj_cgroup *get_obj_cgroup_from_cgroup(struct cgroup *cgrp) > > +{ > > + struct cgroup_subsys_state *css; > > + struct mem_cgroup *memcg; > > + struct obj_cgroup *objcg; > > + > > + rcu_read_lock(); > > + css = rcu_dereference(cgrp->subsys[memory_cgrp_id]); > > + if (!css || !css_tryget_online(css)) { > > + rcu_read_unlock(); > > + cgroup_put(cgrp); > > + return ERR_PTR(-EINVAL); > > + } > > + rcu_read_unlock(); > > + cgroup_put(cgrp); > > The above put seems out of place and buggy. > Thanks for pointing it out. The cgroup_put should be used in bpf_map_save_memcg(). I will update it. -- Regards Yafang