From: Yafang Shao <laoar.shao@gmail.com>
To: Michal Hocko <mhocko@suse.com>
Cc: Yosry Ahmed <yosryahmed@google.com>,
akpm@linux-foundation.org, hannes@cmpxchg.org,
roman.gushchin@linux.dev, shakeelb@google.com,
muchun.song@linux.dev, linux-mm@kvack.org
Subject: Re: [RFC PATCH] mm: Add reclaim type to memory.reclaim
Date: Tue, 27 Feb 2024 22:05:45 +0800 [thread overview]
Message-ID: <CALOAHbDqVDeTkyFzQJrnmTr+ZrEUjEkP4uir0HzKO1LN0cLuzg@mail.gmail.com> (raw)
In-Reply-To: <Zd3g9DsQwn92Wdk6@tiehlicka>
On Tue, Feb 27, 2024 at 9:17 PM Michal Hocko <mhocko@suse.com> wrote:
>
> On Tue 27-02-24 20:12:27, Yafang Shao wrote:
> > On Tue, Feb 27, 2024 at 8:09 PM Yafang Shao <laoar.shao@gmail.com> wrote:
> [...]
> > > > If that's the case, why was slabs info initially exposed through
> > > > /proc/slabinfo?
>
> because that helps to better understand the memory consumption by slab
> consumers.
>
> > > > Isn't that level of detail considered a kernel
> > > > implementation detail? Currently, users can identify which slab is
> > > > consuming the most memory but lack the ability to take action based on
> > > > that information. This suggests a flaw in the kernel implementation.
>
> I disgree!
>
> > > BTW, we even expose more detailed kernel implementation details
> > > through /sys/kernel/slab.
> > > That is really confusing...
> >
> > There is even a /sys/kernel/slab/dentry/shrink ....
> > oh please...
>
> We also have /proc/sys/vm/drop_caches and we have learned those are
> really terrible interfaces and we have good reasons to not replicate
> those into memcg interfaces. Using bad interfaces as an example is not
> the way argue for new ones.
And then we introduce a similar memory.reclaim......
--
Regards
Yafang
next prev parent reply other threads:[~2024-02-27 14:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-25 11:42 Yafang Shao
2024-02-26 4:17 ` Matthew Wilcox
2024-02-26 12:34 ` Yafang Shao
2024-02-26 13:16 ` Matthew Wilcox
2024-02-26 13:56 ` Yafang Shao
2024-02-26 14:04 ` Michal Hocko
2024-02-27 5:48 ` Yafang Shao
2024-02-27 9:05 ` Michal Hocko
2024-02-27 9:39 ` Yafang Shao
2024-02-27 9:43 ` Yosry Ahmed
2024-02-27 11:37 ` Yafang Shao
2024-02-27 11:40 ` Yosry Ahmed
2024-02-27 11:58 ` Yafang Shao
2024-02-27 12:09 ` Yafang Shao
2024-02-27 12:12 ` Yafang Shao
2024-02-27 13:17 ` Michal Hocko
2024-02-27 14:05 ` Yafang Shao [this message]
2024-02-27 9:45 ` Michal Hocko
2024-02-27 10:06 ` Yafang Shao
2024-02-27 13:20 ` Michal Hocko
2024-02-27 14:03 ` Yafang Shao
2024-02-27 14:51 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALOAHbDqVDeTkyFzQJrnmTr+ZrEUjEkP4uir0HzKO1LN0cLuzg@mail.gmail.com \
--to=laoar.shao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox