From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A5D9C433E0 for ; Mon, 20 Jul 2020 01:46:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E645E2250E for ; Mon, 20 Jul 2020 01:46:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VuVjX/Ww" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E645E2250E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3217F6B0003; Sun, 19 Jul 2020 21:46:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2AB046B0005; Sun, 19 Jul 2020 21:46:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1763C6B0006; Sun, 19 Jul 2020 21:46:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0030.hostedemail.com [216.40.44.30]) by kanga.kvack.org (Postfix) with ESMTP id F12C06B0003 for ; Sun, 19 Jul 2020 21:46:14 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 7CA1010EA13 for ; Mon, 20 Jul 2020 01:46:14 +0000 (UTC) X-FDA: 77056763868.13.coast13_2d0221226f20 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id E0FBB184818BA for ; Mon, 20 Jul 2020 01:43:45 +0000 (UTC) X-HE-Tag: coast13_2d0221226f20 X-Filterd-Recvd-Size: 3672 Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Jul 2020 01:43:45 +0000 (UTC) Received: by mail-io1-f65.google.com with SMTP id l17so15935117iok.7 for ; Sun, 19 Jul 2020 18:43:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nqg6+WQSI+aaybgIAIRpXFA6w0cfP2oqxfp5JV73u+s=; b=VuVjX/WwZwRn2w01SgY93rUbqGPPwL6FfuQ64NB9mf5KYy4msxCNnuJDUs0IVIB+up GLo5ymwT+DDAwTvMl0wZo7tvIDqioy/gGJ7wMhCvDWHbFqkbv2WdPFqHu+IL9vjV95e+ e+Gc8nn1gjmTW6lNY6rCwHMIiqtkCnsMK/TY7vCPU3e2ECdOPv9e7q9clV0vhI1K39j+ 181/9BNZsaXyWJGuqysy8Yi5/qG7iFfmIGjN2Zs6K74uZSPweo5rldcHlxu1B2S00mqi wRkqLW8jVYcaUUjMmRDGjpJvRy8KTgJKsuqDDwT9V5/Ml+4Yl+rGrGj1eRqreNi3z8WQ EboQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nqg6+WQSI+aaybgIAIRpXFA6w0cfP2oqxfp5JV73u+s=; b=RZu7cSY5J+9b0epI6BZzE+0opGHRiNunmrZEqnDCyt2esO+kw+99m5yaJznliLgaRh LB23ARSqRCQXb7UH0Smye2XLvEp935CDe4Hte0u/l68R49AQNA2hrACRuoPTTZ5yXD72 7kBg6GbsMNB8viG52+jPa2Dd7F87eD3RN7JXB9VgjmLomWS/jstTCgLo/zOvHNLW7sgF 5tT4C7Bw7esXff7enxCb8FhvXxp/eLNy/JKt86ns/0eu8wOP1vPBIB752nRZ6xVuYFc3 m47RLfeOo6QjcHaSo9syEhvRNmlN8i4DAdmsKeK7UxqOXg2RsFAE0MqiV3z8xYe+8dvt Nqfg== X-Gm-Message-State: AOAM531c6Z5bnXE1iWYFpX3yCTo3TUTel4nRIatX7AwCqyvWlXfMD3I8 jhSICDlCQNvZral4/CaFJ6q4kgvFoh8pTR0APFU= X-Google-Smtp-Source: ABdhPJz1P+EQwKPOCpA9AdpiynbMOEvzDOs4o5xowSKoVQOteUOoAzxle2ksh7OVj+xwv3VTG0qchAHFgKlzTKO3Qc0= X-Received: by 2002:a6b:c343:: with SMTP id t64mr21274636iof.66.1595209425100; Sun, 19 Jul 2020 18:43:45 -0700 (PDT) MIME-Version: 1.0 References: <1595166795-27587-1-git-send-email-laoar.shao@gmail.com> <37e3cb3d-67fc-d680-6b70-6c71b2a0f144@i-love.sakura.ne.jp> In-Reply-To: <37e3cb3d-67fc-d680-6b70-6c71b2a0f144@i-love.sakura.ne.jp> From: Yafang Shao Date: Mon, 20 Jul 2020 09:43:09 +0800 Message-ID: Subject: Re: [PATCH] mm, oom: show process exiting information in __oom_kill_process() To: Tetsuo Handa Cc: David Rientjes , Michal Hocko , Andrew Morton , Linux MM Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: E0FBB184818BA X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000122, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 20, 2020 at 7:20 AM Tetsuo Handa wrote: > > On 2020/07/19 22:53, Yafang Shao wrote: > > p = find_lock_task_mm(victim); > > if (!p) { > > + pr_info("Process %d (%s) is already exiting\n", > > + task_pid_nr(victim), victim->comm); > > Maybe > > + pr_info("%s: Process %d (%s) is already exiting\n", > + message, task_pid_nr(victim), victim->comm); > > line is easier to compare with > > pr_err("%s: Killed process %d (%s) total-vm:%lukB, anon-rss:%lukB, file-rss:%lukB, shmem-rss:%lukB, UID:%u pgtables:%lukB oom_score_adj:%hd\n", > message, task_pid_nr(victim), victim->comm, K(mm->total_vm), > > line? > Seems so. Thanks for the suggestion. > > put_task_struct(victim); > > return; -- Thanks Yafang