From: Yafang Shao <laoar.shao@gmail.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: David Rientjes <rientjes@google.com>,
Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH] mm, oom: show process exiting information in __oom_kill_process()
Date: Mon, 20 Jul 2020 09:43:09 +0800 [thread overview]
Message-ID: <CALOAHbDfBSdgfsmZbYWfK=PNw-Quv-Bnd=XEsjdVq5EHtOY4zQ@mail.gmail.com> (raw)
In-Reply-To: <37e3cb3d-67fc-d680-6b70-6c71b2a0f144@i-love.sakura.ne.jp>
On Mon, Jul 20, 2020 at 7:20 AM Tetsuo Handa
<penguin-kernel@i-love.sakura.ne.jp> wrote:
>
> On 2020/07/19 22:53, Yafang Shao wrote:
> > p = find_lock_task_mm(victim);
> > if (!p) {
> > + pr_info("Process %d (%s) is already exiting\n",
> > + task_pid_nr(victim), victim->comm);
>
> Maybe
>
> + pr_info("%s: Process %d (%s) is already exiting\n",
> + message, task_pid_nr(victim), victim->comm);
>
> line is easier to compare with
>
> pr_err("%s: Killed process %d (%s) total-vm:%lukB, anon-rss:%lukB, file-rss:%lukB, shmem-rss:%lukB, UID:%u pgtables:%lukB oom_score_adj:%hd\n",
> message, task_pid_nr(victim), victim->comm, K(mm->total_vm),
>
> line?
>
Seems so.
Thanks for the suggestion.
> > put_task_struct(victim);
> > return;
--
Thanks
Yafang
next prev parent reply other threads:[~2020-07-20 1:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-19 13:53 Yafang Shao
2020-07-19 23:20 ` Tetsuo Handa
2020-07-20 1:43 ` Yafang Shao [this message]
2020-07-20 7:16 ` Michal Hocko
2020-07-20 10:36 ` Yafang Shao
2020-07-20 11:06 ` Tetsuo Handa
2020-07-20 12:19 ` Yafang Shao
2020-07-20 13:11 ` Tetsuo Handa
2020-07-20 13:59 ` Yafang Shao
2020-07-20 13:41 ` Michal Hocko
2020-07-20 14:03 ` Tetsuo Handa
2020-07-20 14:23 ` Michal Hocko
2020-07-20 13:35 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALOAHbDfBSdgfsmZbYWfK=PNw-Quv-Bnd=XEsjdVq5EHtOY4zQ@mail.gmail.com' \
--to=laoar.shao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox